From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF07DC433ED for ; Tue, 20 Apr 2021 14:14:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60BD3613B6 for ; Tue, 20 Apr 2021 14:14:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60BD3613B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 99B516E830; Tue, 20 Apr 2021 14:14:49 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 976A989DEA; Tue, 20 Apr 2021 14:14:47 +0000 (UTC) IronPort-SDR: Fz9nuAD9X5sEx3re3IddpegxuXUyrXj+Q6HbvALPrWPyffLYjsDyT7qiY5NwjnGJQUGNb4yY8d ZWCFhRgK0IHA== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="192325053" X-IronPort-AV: E=Sophos;i="5.82,237,1613462400"; d="scan'208";a="192325053" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 07:14:46 -0700 IronPort-SDR: q/GQMT/wE/Kr2aQ6ZrfxZhx8yWoJSN1FQ0DyeD4QXmjxXaHoFZQWlL+UU+DixPiVNOH2H+pWkC Q07Owa5Fdlzw== X-IronPort-AV: E=Sophos;i="5.82,237,1613462400"; d="scan'208";a="426970209" Received: from jyick-mobl.amr.corp.intel.com (HELO intel.com) ([10.212.57.228]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 07:14:44 -0700 Date: Tue, 20 Apr 2021 10:14:42 -0400 From: Rodrigo Vivi To: Dan Carpenter Subject: Re: [PATCH] drm/i915: fix an error code in intel_overlay_do_put_image() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , kernel-janitors@vger.kernel.org, David Airlie , Pankaj Bharadiya , intel-gfx@lists.freedesktop.org, Chris Wilson , dri-devel@lists.freedesktop.org, Matthew Auld Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 14, 2021 at 09:02:24AM +0300, Dan Carpenter wrote: > This code should propagate the error from intel_overlay_pin_fb() > but currently it returns success. > > Fixes: 1b321026e213 ("drm/i915: Pass ww ctx to intel_pin_to_display_plane") > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vivi and pushed. thanks for the patch. > --- > drivers/gpu/drm/i915/display/intel_overlay.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c > index e477b6114a60..e5dadde422f7 100644 > --- a/drivers/gpu/drm/i915/display/intel_overlay.c > +++ b/drivers/gpu/drm/i915/display/intel_overlay.c > @@ -803,8 +803,10 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay, > atomic_inc(&dev_priv->gpu_error.pending_fb_pin); > > vma = intel_overlay_pin_fb(new_bo); > - if (IS_ERR(vma)) > + if (IS_ERR(vma)) { > + ret = PTR_ERR(vma); > goto out_pin_section; > + } > > i915_gem_object_flush_frontbuffer(new_bo, ORIGIN_DIRTYFB); > > -- > 2.30.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel