From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C891C001BA for ; Mon, 12 Apr 2021 16:37:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 379B36134F for ; Mon, 12 Apr 2021 16:37:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 379B36134F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7889A89DB2; Mon, 12 Apr 2021 16:37:04 +0000 (UTC) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B75589DB2 for ; Mon, 12 Apr 2021 16:37:03 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id a4so13632175wrr.2 for ; Mon, 12 Apr 2021 09:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hn1jkdSMbiHFhC217RD5V15xVqY7Z/IxbW7epuIvfuA=; b=ChsiF5MjK4r13FoZQSNDU9DxbxRVpHuJPicuUY0yqEe7TQvyNo57QDfQkv3oPzj0Rz 4r0zsR3EnLvIg8v4kn7O4Kwn3tkasth9AwkOySImVrPEFBUvmVryVihgiuu5W34cV9a5 KgoGKXqU7d6P2i/fHZprsai5V2KUqAX5A9TQQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hn1jkdSMbiHFhC217RD5V15xVqY7Z/IxbW7epuIvfuA=; b=nHfjYSe7gCEsLdzxxwwlTl1sKIKHzlh59Ah18oZDSakJDp+pAs1wD9sHHnThJV5OWG cMrgeWATeFqKlAF7rj6Bh3/wZUgVlDhhVn/V1eTYQ7XftNEUsVIDWrQDnlobSlg6Xdbj k3b6xUPbS1cUsyFlJQa21ayB0CeFTlxptQ1+rnViLbADjg+OXxCi7+BZ78W+e3gE20cL iLAbmCu7ybKdzDwKLveOTPX30bi78pCmPvxn+FrgXhqpFI7g3yZqPjR4Vn4Z/BMuSXMH sdCg0p1Cx49ha7KT5JP/xR1+j9kEd8c/9noaSnKEQFKydVmdLvQTc9BrsSX3Kd/Ywie3 GeSg== X-Gm-Message-State: AOAM532BLAFhL4y2opZN7BTUp/8o6fIGBxMAVaG5mTQOEcQmxHFirOly 6SbQB0VndKKI8nRIFRbcvT9nmQ== X-Google-Smtp-Source: ABdhPJxICcL4cgvgxh5LVfH2gmHVfijmlbEKGcrNaDqMIgAxnXszmjeui7GjULR8Q9jdsCBLUw6yNw== X-Received: by 2002:adf:f14b:: with SMTP id y11mr31567129wro.79.1618245422028; Mon, 12 Apr 2021 09:37:02 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l24sm16033921wmc.4.2021.04.12.09.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 09:37:01 -0700 (PDT) Date: Mon, 12 Apr 2021 18:36:59 +0200 From: Daniel Vetter To: Jani Nikula Subject: Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front Message-ID: References: <20210412090526.30547-1-matthew.auld@intel.com> <20210412090526.30547-19-matthew.auld@intel.com> <87lf9nijao.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87lf9nijao.fsf@intel.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Matthew Auld , Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Apr 12, 2021 at 07:01:19PM +0300, Jani Nikula wrote: > On Mon, 12 Apr 2021, Daniel Vetter wrote: > > And that's some serious wtf. Yes we've done some compile-time type > > casting automagic between i915_priv and dev in the past, and I think even > > that was bad taste. But it was justified with that we have these > > everywhere (especially in the mmio macros), and it would be a terrible > > flag day. > > FWIW, we had the dev_priv/dev macro trickery for a while to not have > that flag day conversion, until everything used i915 or &i915->drm. But > we got rid of it afterwards. Yay, and yes that was the plan to avoid the flag day. And not as a great coding pattern that everyone should imitate ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel