From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B55C433ED for ; Wed, 14 Apr 2021 09:10:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC8F16117A for ; Wed, 14 Apr 2021 09:10:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC8F16117A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F9CC6E4D4; Wed, 14 Apr 2021 09:10:51 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4553A6E503 for ; Wed, 14 Apr 2021 09:10:50 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id w7-20020a1cdf070000b0290125f388fb34so9690018wmg.0 for ; Wed, 14 Apr 2021 02:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xsQYX2UHTRaG1Vym45NrgNrdV4EUKH9oW8JvGS1IMYY=; b=aoXau1/tL0UuarbWeJEoRyF7u0YNWsS7WG34VfjL2OsY+mvp6dA2b8ofn7+jT4rAZJ mNlD9nYQyoqJP+Mave/iyaltyaBe0DW3YwUEKSpf797xQVpt776AwFuNHwN9OilD+gXu wW90zgCjrmLsyr7/rPn7mk4NbNHOaS3ksiWfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xsQYX2UHTRaG1Vym45NrgNrdV4EUKH9oW8JvGS1IMYY=; b=pSFX4+DcuQvvuAAX0Ge51zTWoUGOkvvyY5BXSi8a78OMxraN/BRQrByxGZU/KCUbeB 4z4Q3EGss4gGKP0r+MTfinCy8iG2YT1DBjyiLYosQ7YzA9/I0h4ToB3+kcIPBxHBNyI9 EKJIvNqaLINgpvP4AutrAmshnhmZjl9HQ2WPdahTdYuI6xbMzQM+qaJqxl49C8VKPIxq PUtxIl9spnEkMQCxqi7rN+ALWa22RUuJf0S9Q3MfIJBR2QS/vNCRYzo5KpsjsHWv5jz7 N0RbcAxV5adcrlR/vn1WYE1HQCN66sCHYufxRY5Bc4Aqgs1ohUPB0DUsaCd92qitFlDs udTg== X-Gm-Message-State: AOAM532Lo7WGtFGEwW88YKeRrU2TiEvTZrn/1cdoiiHcbg1zpZA3Tzak IAsThOqnoDRYZRK5fL4mUTEAhQ== X-Google-Smtp-Source: ABdhPJwmXoRmvMh89AnahmLC2e0I/Y6U+Jr4qUNzw+RsZa37BBNREfDXVI1QrkiIoxUzktM8lukOnQ== X-Received: by 2002:a1c:ac02:: with SMTP id v2mr1975777wme.111.1618391448838; Wed, 14 Apr 2021 02:10:48 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l9sm4359704wmq.2.2021.04.14.02.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 02:10:48 -0700 (PDT) Date: Wed, 14 Apr 2021 11:10:46 +0200 From: Daniel Vetter To: Liu Ying Subject: Re: [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly Message-ID: References: <20210413094904.3736372-1-daniel.vetter@ffwll.ch> <20210413094904.3736372-5-daniel.vetter@ffwll.ch> <290aef5ed13749d465eb19235aa87a2cef63dd2a.camel@pengutronix.de> <83a41b2e9636cb6a790b23843c6d2628d02c6997.camel@pengutronix.de> <9395e1fde2725d4fe01c206d9172b8acd7cdf921.camel@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9395e1fde2725d4fe01c206d9172b8acd7cdf921.camel@nxp.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , DRI Development , NXP Linux Team , Pengutronix Kernel Team , Daniel Vetter , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 14, 2021 at 10:24:22AM +0800, Liu Ying wrote: > Hi Daniel, > > On Tue, 2021-04-13 at 16:14 +0200, Lucas Stach wrote: > > Am Dienstag, dem 13.04.2021 um 16:04 +0200 schrieb Daniel Vetter: > > > On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > > > > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > > > > Since > > > > > > > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > > > > Author: Paul Kocialkowski > > > > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > > > > > > > drm: Auto-set allow_fb_modifiers when given modifiers at plane init > > > > > > > > > > this is done automatically as part of plane init, if drivers set the > > > > > modifier list correctly. Which is the case here. > > > > > > > > > > This one actually set it twice on top of what drm_plane_init does, so > > > > > double-redundant! > > > > > > > > That's not true. imx-dcss and imx-drm are two totally separate drivers. > > > > Maybe we should move imx-drm into its own ipuv3 directory one day to > > > > make this more clear. Change is still correct, though. > > > > > > Hm I greeped for drm_universal_plane_init and didn't find anythinf for the > > > imx main driver ... where are planes set up for that? Need to review that > > > they have the modifiers listed in all cases. > > > > That's in drivers/gpu/drm/imx/ipuv3-plane.c and modifiers are always > > set on plane init. Oh I didn't grep for the new drmm_universal_plane_alloc. Thanks for pointing this out. > > > > Regards, > > Lucas > > > > > > Reviewed-by: Lucas Stach > > > > > > > > > Signed-off-by: Daniel Vetter > > > > > Cc: Philipp Zabel > > > > > Cc: Shawn Guo > > > > > Cc: Sascha Hauer > > > > > Cc: Pengutronix Kernel Team > > > > > Cc: Fabio Estevam > > > > > Cc: NXP Linux Team > > > > > Cc: linux-arm-kernel@lists.infradead.org > > > > > --- > > > > > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - > > > > > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > > Nit: Since this patch touches two totally separate drivers(imx-dcss and > imx-drm), it would be good to split it into two patches. I think if you expect that, then you need to move the imx-drm driver into a subdirectory like dcss. And like e.g. drm/msm works too. As-is this is just kinda confusing for people not involved in imx. -Daniel > > Thanks, > Liu Ying > > > > > > 2 files changed, 2 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > index b549ce5e7607..37ae68a7fba5 100644 > > > > > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > > @@ -52,7 +52,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms) > > > > > config->min_height = 1; > > > > > config->max_width = 4096; > > > > > config->max_height = 4096; > > > > > - config->allow_fb_modifiers = true; > > > > > config->normalize_zpos = true; > > > > > > > > > > > > > > > > > > > > > > > > > config->funcs = &dcss_drm_mode_config_funcs; > > > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > > > > > index 2ded8e4f32d0..8be4edaec958 100644 > > > > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > > > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > > > > @@ -209,7 +209,6 @@ static int imx_drm_bind(struct device *dev) > > > > > drm->mode_config.max_height = 4096; > > > > > drm->mode_config.funcs = &imx_drm_mode_config_funcs; > > > > > drm->mode_config.helper_private = &imx_drm_mode_config_helpers; > > > > > - drm->mode_config.allow_fb_modifiers = true; > > > > > drm->mode_config.normalize_zpos = true; > > > > > > > > > > > > > > > > > > > > > > > > > ret = drmm_mode_config_init(drm); > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel