From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31272C433ED for ; Fri, 23 Apr 2021 21:46:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0C39613A9 for ; Fri, 23 Apr 2021 21:46:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0C39613A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A5276EC63; Fri, 23 Apr 2021 21:46:22 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49ADA6EC63 for ; Fri, 23 Apr 2021 21:46:20 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCBF6332; Fri, 23 Apr 2021 23:46:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619214378; bh=rjGwFCEF0/GZ/zC2VSb/X8kcWmw/weOdivulaQfnK1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pa5/0aguiiP6x3B3D1wRSawG42BC5McpolhB3ngY3FDeyAD+l3ODGGSu5HowE4Exi WfI7N2aTeYygB5Bd0IsGF5BsYBYiSXAPT/iJToT8jyyJOlFKtPENIovCYpA1F97pKp cbkPkew5CqZH6XJP8YTm6zMupl7uMhDlbjifC9vo= Date: Sat, 24 Apr 2021 00:46:12 +0300 From: Laurent Pinchart To: Randy Dunlap Subject: Re: [PATCH] drm: rcar-du: fix linker undefined references Message-ID: References: <20210423213727.27751-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210423213727.27751-1-rdunlap@infradead.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , Masahiro Yamada , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Jacopo Mondi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Randy, Thank you for the patch. On Fri, Apr 23, 2021 at 02:37:27PM -0700, Randy Dunlap wrote: > When DRM_RCAR_DU=y and DRM_RCAR_LVDS=m, there are several build errors > as reported by 'kernel test robot'. These can be corrected by changing > "imply" to "select". > > In looking at this, the same problem (build errors) happens when > DRM_RCAR_DU=y and DRM_RCAR_CMM=m, so again change the "imply" to > "select" here as well. > > These 2 changes fix the following 8 build/link errors: > > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_enable': > rcar_du_crtc.c:(.text+0x1be8): undefined reference to `rcar_lvds_clk_enable' > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_disable': > rcar_du_crtc.c:(.text+0x2438): undefined reference to `rcar_lvds_clk_disable' > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_drv.o: in function `rcar_du_init': > rcar_du_drv.c:(.init.text+0x14): undefined reference to `rcar_du_of_init' > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_encoder.o: in function `rcar_du_encoder_init': > rcar_du_encoder.c:(.text+0x1d4): undefined reference to `rcar_lvds_dual_link' > > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_cmm_setup': > rcar_du_crtc.c:(.text+0x380): undefined reference to `rcar_cmm_setup' > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_enable': > rcar_du_crtc.c:(.text+0x1c08): undefined reference to `rcar_cmm_enable' > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_disable': > rcar_du_crtc.c:(.text+0x231c): undefined reference to `rcar_cmm_disable' > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_kms.o: in function `rcar_du_modeset_init': > rcar_du_kms.c:(.text+0xd08): undefined reference to `rcar_cmm_init' > > Fixes: e08e934d6c28 ("drm: rcar-du: Add support for CMM") > Fixes: 02f2b30032c1 ("drm: rcar-du: lvds: Add API to enable/disable clock output") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Masahiro Yamada > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: dri-devel@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: Jacopo Mondi > --- > drivers/gpu/drm/rcar-du/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20210420.orig/drivers/gpu/drm/rcar-du/Kconfig > +++ linux-next-20210420/drivers/gpu/drm/rcar-du/Kconfig > @@ -4,8 +4,8 @@ config DRM_RCAR_DU > depends on DRM && OF > depends on ARM || ARM64 > depends on ARCH_RENESAS || COMPILE_TEST > - imply DRM_RCAR_CMM > - imply DRM_RCAR_LVDS > + select DRM_RCAR_CMM > + select DRM_RCAR_LVDS No all platforms that integrate a DU have CMM and/or LVDS support, so we shouldn't select the automatically. Would depends on DRM_RCAR_CMM || DRM_RCAR_CMM=n depends on DRM_RCAR_LVDS || DRM_RCAR_LVDS=n work ? I thought that's what "imply" meant, but it seems I got it wrong. > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > select DRM_GEM_CMA_HELPER -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel