From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B13C433B4 for ; Tue, 27 Apr 2021 11:07:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4948D6101D for ; Tue, 27 Apr 2021 11:07:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4948D6101D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94AAB6E07B; Tue, 27 Apr 2021 11:07:23 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id F41736E07B for ; Tue, 27 Apr 2021 11:07:22 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 14609613BF; Tue, 27 Apr 2021 11:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619521642; bh=BRo/eDbvQlGm4UOtynp97IJmtV6Q9jckxoge1aD3P8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jh9JnGp093zCnvaYasdWoryRUgj3/L5MRDmtQuQg+BjWAOQ5OEKlzlzlPzObTz7JH VbDJ1wAQrKlzmrXhiU8SgoM45udYfooPBeyhxbiU1X+pP71xcuOFSxzRHtud+Rj1Yz hgjA3Lg0mDE/PVEvfTG0zXZmwOvFuEt3V2SijFM0= Date: Tue, 27 Apr 2021 13:07:19 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Subject: Re: [PATCH v2 1/4] fbtft: Replace custom ->reset() with generic one Message-ID: References: <20210416142044.17766-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210416142044.17766-1-andriy.shevchenko@linux.intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Apr 16, 2021 at 05:20:41PM +0300, Andy Shevchenko wrote: > The custom ->reset() repeats the generic one, replace it. > > Note, in newer kernels the context of the function is a sleeping one, > it's fine to switch over to the sleeping functions. Keeping the reset > line asserted longer than 20 microseconds is also okay, it's an idling > state of the hardware. > > Fixes: b2ebd4be6fa1 ("staging: fbtft: add fb_agm1264k-fl driver") What does this "fix"? A bug or just a "it shouldn't have been done this way"? And as others pointed out, if you could put "staging: fbtft:" as a prefix here, that would be much better. thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel