From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB69C433B4 for ; Wed, 28 Apr 2021 09:25:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E42896141F for ; Wed, 28 Apr 2021 09:25:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E42896141F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D552A6EADA; Wed, 28 Apr 2021 09:25:56 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A99B6EADA for ; Wed, 28 Apr 2021 09:25:54 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D78F580AA; Wed, 28 Apr 2021 09:25:54 +0000 (UTC) Date: Wed, 28 Apr 2021 12:25:51 +0300 From: Tony Lindgren To: Tomi Valkeinen Subject: Re: [PATCH] drm/omap: Fix issue with clocks left on after resume Message-ID: References: <20210426141241.51985-1-tony@atomide.com> <0963c9fa-1b45-b742-ed9b-5c48d3a97987@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, Sebastian Reichel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Tony Lindgren [210427 10:54]: > * Tony Lindgren [210427 10:12]: > > * Tomi Valkeinen [210427 08:47]: > > > If I understand right, this is only an issue when the dss was not enabled > > > before the system suspend? And as the dispc is not enabled at suspend, > > > pm_runtime_force_suspend and pm_runtime_force_resume don't really do > > > anything. At resume, the DRM resume functionality causes omapdrm to call > > > pm_runtime_get and put, and this somehow causes the dss to stay enabled. > > > > We do have dss enabled at system suspend from omap_atomic_comit_tail() > > until pm_runtime_force_suspend(). Then we have pm_runtime_force_resume() > > enable it. > > Sorry I already forgot that pm_runtime_force_resume() is not enabling > it because pm_runtime_need_not_resume().. It's the omapdrm calling > pm_runtime_get() that enables the hardware on resume. > > > Then on resume PM runtime prevents disable of the hardware on resume path > > until after device_complete(). Until then we have rpm_suspend() return > > -EBUSY, and so the parent child_count is not going to get decreased. > > Something would have to handle the -EBUSY error here it seems. I sent out v2 patch with an updated description. Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel