From: Daniel Vetter <daniel@ffwll.ch>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 25/27] drm/i915/selftests: Take a VM in kernel_context()
Date: Wed, 5 May 2021 11:50:14 +0200 [thread overview]
Message-ID: <YJJqVh//VBhxWm/Z@phenom.ffwll.local> (raw)
In-Reply-To: <20210503155748.1961781-26-jason@jlekstrand.net>
On Mon, May 03, 2021 at 10:57:46AM -0500, Jason Ekstrand wrote:
> This better models where we want to go with contexts in general where
> things like the VM and engine set are create parameters instead of being
> set after the fact.
>
> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Looks reasonable.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> .../drm/i915/gem/selftests/i915_gem_context.c | 4 ++--
> .../gpu/drm/i915/gem/selftests/mock_context.c | 9 ++++++++-
> .../gpu/drm/i915/gem/selftests/mock_context.h | 4 +++-
> drivers/gpu/drm/i915/gt/selftest_execlists.c | 20 +++++++++----------
> drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +-
> 5 files changed, 24 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index 16ff64ab34a1b..76029d7143f6c 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -680,7 +680,7 @@ static int igt_ctx_exec(void *arg)
> struct i915_gem_context *ctx;
> struct intel_context *ce;
>
> - ctx = kernel_context(i915);
> + ctx = kernel_context(i915, NULL);
> if (IS_ERR(ctx)) {
> err = PTR_ERR(ctx);
> goto out_file;
> @@ -813,7 +813,7 @@ static int igt_shared_ctx_exec(void *arg)
> struct i915_gem_context *ctx;
> struct intel_context *ce;
>
> - ctx = kernel_context(i915);
> + ctx = kernel_context(i915, NULL);
> if (IS_ERR(ctx)) {
> err = PTR_ERR(ctx);
> goto out_test;
> diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> index 61aaac4a334cf..500ef27ba4771 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> @@ -150,7 +150,8 @@ live_context_for_engine(struct intel_engine_cs *engine, struct file *file)
> }
>
> struct i915_gem_context *
> -kernel_context(struct drm_i915_private *i915)
> +kernel_context(struct drm_i915_private *i915,
> + struct i915_address_space *vm)
> {
> struct i915_gem_context *ctx;
> struct i915_gem_proto_context *pc;
> @@ -159,6 +160,12 @@ kernel_context(struct drm_i915_private *i915)
> if (IS_ERR(pc))
> return ERR_CAST(pc);
>
> + if (vm) {
> + if (pc->vm)
> + i915_vm_put(pc->vm);
> + pc->vm = i915_vm_get(vm);
> + }
> +
> ctx = i915_gem_create_context(i915, pc);
> proto_context_close(pc);
> if (IS_ERR(ctx))
> diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.h b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
> index 2a6121d33352d..7a02fd9b5866a 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/mock_context.h
> +++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.h
> @@ -10,6 +10,7 @@
> struct file;
> struct drm_i915_private;
> struct intel_engine_cs;
> +struct i915_address_space;
>
> void mock_init_contexts(struct drm_i915_private *i915);
>
> @@ -25,7 +26,8 @@ live_context(struct drm_i915_private *i915, struct file *file);
> struct i915_gem_context *
> live_context_for_engine(struct intel_engine_cs *engine, struct file *file);
>
> -struct i915_gem_context *kernel_context(struct drm_i915_private *i915);
> +struct i915_gem_context *kernel_context(struct drm_i915_private *i915,
> + struct i915_address_space *vm);
> void kernel_context_close(struct i915_gem_context *ctx);
>
> #endif /* !__MOCK_CONTEXT_H */
> diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> index a0e75b71a3374..0989e024f7a03 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> @@ -1522,12 +1522,12 @@ static int live_busywait_preempt(void *arg)
> * preempt the busywaits used to synchronise between rings.
> */
>
> - ctx_hi = kernel_context(gt->i915);
> + ctx_hi = kernel_context(gt->i915, NULL);
> if (!ctx_hi)
> return -ENOMEM;
> ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
>
> - ctx_lo = kernel_context(gt->i915);
> + ctx_lo = kernel_context(gt->i915, NULL);
> if (!ctx_lo)
> goto err_ctx_hi;
> ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> @@ -1724,12 +1724,12 @@ static int live_preempt(void *arg)
> if (igt_spinner_init(&spin_lo, gt))
> goto err_spin_hi;
>
> - ctx_hi = kernel_context(gt->i915);
> + ctx_hi = kernel_context(gt->i915, NULL);
> if (!ctx_hi)
> goto err_spin_lo;
> ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
>
> - ctx_lo = kernel_context(gt->i915);
> + ctx_lo = kernel_context(gt->i915, NULL);
> if (!ctx_lo)
> goto err_ctx_hi;
> ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> @@ -1816,11 +1816,11 @@ static int live_late_preempt(void *arg)
> if (igt_spinner_init(&spin_lo, gt))
> goto err_spin_hi;
>
> - ctx_hi = kernel_context(gt->i915);
> + ctx_hi = kernel_context(gt->i915, NULL);
> if (!ctx_hi)
> goto err_spin_lo;
>
> - ctx_lo = kernel_context(gt->i915);
> + ctx_lo = kernel_context(gt->i915, NULL);
> if (!ctx_lo)
> goto err_ctx_hi;
>
> @@ -1910,7 +1910,7 @@ struct preempt_client {
>
> static int preempt_client_init(struct intel_gt *gt, struct preempt_client *c)
> {
> - c->ctx = kernel_context(gt->i915);
> + c->ctx = kernel_context(gt->i915, NULL);
> if (!c->ctx)
> return -ENOMEM;
>
> @@ -3367,12 +3367,12 @@ static int live_preempt_timeout(void *arg)
> if (igt_spinner_init(&spin_lo, gt))
> return -ENOMEM;
>
> - ctx_hi = kernel_context(gt->i915);
> + ctx_hi = kernel_context(gt->i915, NULL);
> if (!ctx_hi)
> goto err_spin_lo;
> ctx_hi->sched.priority = I915_CONTEXT_MAX_USER_PRIORITY;
>
> - ctx_lo = kernel_context(gt->i915);
> + ctx_lo = kernel_context(gt->i915, NULL);
> if (!ctx_lo)
> goto err_ctx_hi;
> ctx_lo->sched.priority = I915_CONTEXT_MIN_USER_PRIORITY;
> @@ -3659,7 +3659,7 @@ static int live_preempt_smoke(void *arg)
> }
>
> for (n = 0; n < smoke.ncontext; n++) {
> - smoke.contexts[n] = kernel_context(smoke.gt->i915);
> + smoke.contexts[n] = kernel_context(smoke.gt->i915, NULL);
> if (!smoke.contexts[n])
> goto err_ctx;
> }
> diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> index 746985971c3a6..3676eaf6b2aee 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> @@ -42,7 +42,7 @@ static int hang_init(struct hang *h, struct intel_gt *gt)
> memset(h, 0, sizeof(*h));
> h->gt = gt;
>
> - h->ctx = kernel_context(gt->i915);
> + h->ctx = kernel_context(gt->i915, NULL);
> if (IS_ERR(h->ctx))
> return PTR_ERR(h->ctx);
>
> --
> 2.31.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-05-05 9:50 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 15:57 [PATCH 00/27] drm/i915/gem: ioctl clean-ups (v5) Jason Ekstrand
2021-05-03 15:57 ` [PATCH 01/27] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE Jason Ekstrand
2021-05-03 15:57 ` [PATCH 02/27] drm/i915: Stop storing the ring size in the ring pointer Jason Ekstrand
2021-05-04 8:47 ` Daniel Vetter
2021-05-14 18:06 ` Jason Ekstrand
2021-05-03 15:57 ` [PATCH 03/27] drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP Jason Ekstrand
2021-05-04 8:48 ` [Intel-gfx] " Daniel Vetter
2021-05-03 15:57 ` [PATCH 04/27] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem (v2) Jason Ekstrand
2021-05-03 15:57 ` [PATCH 05/27] drm/i915/gem: Return void from context_apply_all Jason Ekstrand
2021-05-03 15:57 ` [PATCH 06/27] drm/i915: Drop the CONTEXT_CLONE API Jason Ekstrand
2021-05-04 8:50 ` [Intel-gfx] " Daniel Vetter
2021-05-14 18:07 ` Jason Ekstrand
2021-05-03 15:57 ` [PATCH 07/27] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4) Jason Ekstrand
2021-05-03 15:57 ` [PATCH 08/27] drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES Jason Ekstrand
2021-05-03 15:57 ` [PATCH 09/27] drm/i915/gem: Disallow bonding of virtual engines (v3) Jason Ekstrand
2021-05-03 15:57 ` [PATCH 10/27] drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT Jason Ekstrand
2021-05-04 8:56 ` Daniel Vetter
2021-05-14 18:19 ` Jason Ekstrand
2021-05-03 15:57 ` [PATCH 11/27] drm/i915/request: Remove the hook from await_execution Jason Ekstrand
2021-05-04 8:55 ` Daniel Vetter
2021-05-03 15:57 ` [PATCH 12/27] drm/i915/gem: Disallow creating contexts with too many engines Jason Ekstrand
2021-05-05 9:56 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-03 15:57 ` [PATCH 13/27] drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2) Jason Ekstrand
2021-05-03 15:57 ` [PATCH 14/27] drm/i915/gem: Add a separate validate_priority helper Jason Ekstrand
2021-05-03 15:57 ` [PATCH 15/27] drm/i915: Add gem/i915_gem_context.h to the docs Jason Ekstrand
2021-05-04 9:11 ` Daniel Vetter
2021-05-03 15:57 ` [PATCH 16/27] drm/i915/gem: Add an intermediate proto_context struct Jason Ekstrand
2021-05-04 16:13 ` Daniel Vetter
2021-06-02 21:53 ` Jason Ekstrand
2021-06-03 7:07 ` Daniel Vetter
2021-05-05 10:09 ` [Intel-gfx] " Tvrtko Ursulin
2021-05-03 15:57 ` [PATCH 17/27] drm/i915/gem: Rework error handling in default_engines Jason Ekstrand
2021-05-04 16:17 ` [Intel-gfx] " Daniel Vetter
2021-05-14 18:21 ` Jason Ekstrand
2021-05-03 15:57 ` [PATCH 18/27] drm/i915/gem: Optionally set SSEU in intel_context_set_gem Jason Ekstrand
2021-05-04 19:00 ` [Intel-gfx] " Daniel Vetter
2021-05-05 9:28 ` Tvrtko Ursulin
2021-05-05 9:47 ` Daniel Vetter
2021-05-05 9:52 ` Tvrtko Ursulin
2021-05-03 15:57 ` [PATCH 19/27] drm/i915/gem: Use the proto-context to handle create parameters Jason Ekstrand
2021-05-04 20:33 ` Daniel Vetter
2021-05-14 19:13 ` Jason Ekstrand
2021-05-17 13:40 ` Daniel Vetter
2021-05-17 17:04 ` Jason Ekstrand
2021-05-17 18:44 ` Daniel Vetter
2021-05-18 10:51 ` Jani Nikula
2021-05-03 15:57 ` [PATCH 20/27] drm/i915/gem: Return an error ptr from context_lookup Jason Ekstrand
2021-05-03 15:57 ` [PATCH 21/27] drm/i915/gt: Drop i915_address_space::file (v2) Jason Ekstrand
2021-05-03 15:57 ` [PATCH 22/27] drm/i915/gem: Delay context creation Jason Ekstrand
2021-05-03 19:38 ` [Intel-gfx] " kernel test robot
2021-05-04 20:53 ` Daniel Vetter
2021-05-04 20:53 ` Daniel Vetter
2021-05-03 15:57 ` [PATCH 23/27] drm/i915/gem: Don't allow changing the VM on running contexts Jason Ekstrand
2021-05-03 18:52 ` [Intel-gfx] " kernel test robot
2021-05-04 21:00 ` Daniel Vetter
2021-05-04 21:17 ` Daniel Vetter
2021-05-03 15:57 ` [PATCH 24/27] drm/i915/gem: Don't allow changing the engine set " Jason Ekstrand
2021-05-05 9:49 ` [Intel-gfx] " Daniel Vetter
2021-05-03 15:57 ` [PATCH 25/27] drm/i915/selftests: Take a VM in kernel_context() Jason Ekstrand
2021-05-05 9:50 ` Daniel Vetter [this message]
2021-05-03 15:57 ` [PATCH 26/27] i915/gem/selftests: Assign the VM at context creation in igt_shared_ctx_exec Jason Ekstrand
2021-05-05 9:53 ` [Intel-gfx] " Daniel Vetter
2021-05-03 15:57 ` [PATCH 27/27] drm/i915/gem: Roll all of context creation together Jason Ekstrand
2021-05-05 10:05 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJJqVh//VBhxWm/Z@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).