From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'
Date: Wed, 2 Jun 2021 19:23:30 +0300 [thread overview]
Message-ID: <YLewgiMzhlR//gzQ@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210602143300.2330146-19-lee.jones@linaro.org>
Hi Lee,
Thank you for the patch.
On Wed, Jun 02, 2021 at 03:32:52PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead
>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 82430ca9b9133..a1055d5055eab 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -797,7 +797,7 @@ static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp)
> }
>
> /**
> - * zynqmp_dp_link_train - Train the link
> + * zynqmp_dp_train - Train the link
The driver has other functions related to link training that start with
the zynqmp_dp_link_train_* prefix. I'd prefer renaming this function to
zynqmp_dp_link_train(). Bonus points if the same patch could rename
zynqmp_dp_train_loop() to zynqmp_dp_link_train_loop() too :-)
> * @dp: DisplayPort IP core structure
> *
> * Return: 0 if all trains are done successfully, or corresponding error code.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-06-02 16:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
2021-06-02 14:32 ` [RESEND 01/26] drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header Lee Jones
2021-06-02 14:32 ` [RESEND 02/26] drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant kernel-doc header Lee Jones
2021-06-02 14:32 ` [RESEND 03/26] drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header Lee Jones
2021-06-02 14:32 ` [RESEND 04/26] drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc header Lee Jones
2021-06-02 14:32 ` [RESEND 05/26] drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc headers Lee Jones
2021-06-02 14:32 ` [RESEND 06/26] drm/sti/sti_hda: Provide missing function names Lee Jones
2021-06-02 14:32 ` [RESEND 07/26] drm/sti/sti_tvout: Provide a bunch of " Lee Jones
2021-06-02 14:32 ` [RESEND 08/26] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' Lee Jones
2021-06-02 14:32 ` [RESEND 09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc' Lee Jones
2021-06-02 17:26 ` [Freedreno] " abhinavk
2021-06-02 14:32 ` [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses Lee Jones
2021-06-02 17:33 ` [Freedreno] " abhinavk
2021-06-04 8:32 ` Dmitry Baryshkov
2021-06-04 8:57 ` Lee Jones
2021-06-02 14:32 ` [RESEND 11/26] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues Lee Jones
2021-06-02 17:29 ` [Freedreno] " abhinavk
2021-06-02 14:32 ` [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses Lee Jones
2021-06-04 0:49 ` Dmitry Baryshkov
2021-06-02 14:32 ` [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' Lee Jones
2021-06-02 17:32 ` [Freedreno] " abhinavk
2021-06-02 23:52 ` Stephen Boyd
2021-06-02 14:32 ` [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot Lee Jones
2021-06-04 0:51 ` Dmitry Baryshkov
2021-06-02 14:32 ` [RESEND 15/26] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static Lee Jones
2021-06-02 14:32 ` [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, Lee Jones
2021-06-02 14:46 ` Harry Wentland
2021-06-02 16:23 ` Alex Deucher
2021-06-02 17:37 ` Lee Jones
2021-06-02 14:32 ` [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id' Lee Jones
2021-06-02 16:20 ` Laurent Pinchart
2021-06-03 11:30 ` Daniel Vetter
2021-06-02 14:32 ` [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' Lee Jones
2021-06-02 16:23 ` Laurent Pinchart [this message]
2021-06-02 17:38 ` Lee Jones
2021-06-02 14:32 ` [RESEND 19/26] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header Lee Jones
2021-06-02 14:32 ` [RESEND 20/26] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse Lee Jones
2021-06-02 14:32 ` [RESEND 21/26] drm/panel/panel-sitronix-st7701: " Lee Jones
2021-06-02 14:32 ` [RESEND 22/26] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format Lee Jones
2021-06-02 14:32 ` [RESEND 23/26] drm/exynos/exynos7_drm_decon: Fix incorrect naming of 'decon_shadow_protect_win()' Lee Jones
2021-06-02 14:32 ` [RESEND 24/26] drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps, res}_ioctl()' Lee Jones
2021-06-02 14:32 ` [RESEND 25/26] drm/vboxvideo/hgsmi_base: Place function names into headers Lee Jones
2021-06-02 14:33 ` [RESEND 26/26] drm/vboxvideo/modesetting: Provide function names for prototype headers Lee Jones
2021-06-03 11:34 ` [RESEND 00/26] Rid W=1 warnings from GPU Daniel Vetter
2021-06-03 11:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLewgiMzhlR//gzQ@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hyun.kwon@xilinx.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).