From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Kirti Wankhede <kwankhede@nvidia.com>,
linux-s390@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Jason Gunthorpe <jgg@nvidia.com>,
intel-gfx@lists.freedesktop.org,
Jason Herne <jjherne@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind
Date: Tue, 15 Jun 2021 07:18:15 +0200 [thread overview]
Message-ID: <YMg4F99j2nsjGxAz@kroah.com> (raw)
In-Reply-To: <20210614150846.4111871-4-hch@lst.de>
On Mon, Jun 14, 2021 at 05:08:39PM +0200, Christoph Hellwig wrote:
> Currently really_probe() returns 1 on success and 0 if the probe() call
> fails. This return code arrangement is designed to be useful for
> __device_attach_driver() which is walking the device list and trying every
> driver. 0 means to keep trying.
>
> However, it is not useful for the other places that call through to
> really_probe() that do actually want to see the probe() return code.
>
> For instance bind_store() would be better to return the actual error code
> from the driver's probe method, not discarding it and returning -ENODEV.
>
> Reorganize things so that really_probe() returns the error code from
> ->probe as a (inverted) positive number, and 0 for successful attach.
>
> With this, __device_attach_driver can ignore the (positive) probe errors,
> return 1 to exit the loop for a successful binding and pass on the
> other negative errors, while device_driver_attach simplify inverts the
> positive errors and returns all errors to the sysfs code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/base/bus.c | 6 +-----
> drivers/base/dd.c | 29 ++++++++++++++++++++---------
> 2 files changed, 21 insertions(+), 14 deletions(-)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-06-15 5:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210614150846.4111871-1-hch@lst.de>
[not found] ` <20210614150846.4111871-5-hch@lst.de>
2021-06-14 22:43 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind Jason Gunthorpe
[not found] ` <20210614150846.4111871-2-hch@lst.de>
2021-06-15 5:16 ` [PATCH 01/10] driver core: Pull required checks into driver_probe_device() Greg Kroah-Hartman
2021-06-15 10:27 ` Cornelia Huck
[not found] ` <20210614150846.4111871-3-hch@lst.de>
2021-06-14 18:47 ` [PATCH 02/10] driver core: Better distinguish probe errors in really_probe Kirti Wankhede
2021-06-15 5:17 ` Greg Kroah-Hartman
2021-06-15 5:21 ` Allow mdev drivers to directly create the vfio_device (v2 / alternative) Greg Kroah-Hartman
[not found] ` <20210615055021.GB21080@lst.de>
2021-06-15 15:27 ` Jason Gunthorpe
[not found] ` <20210614150846.4111871-4-hch@lst.de>
2021-06-15 5:18 ` Greg Kroah-Hartman [this message]
2021-06-15 10:31 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Cornelia Huck
[not found] ` <20210614150846.4111871-6-hch@lst.de>
2021-06-15 5:20 ` [PATCH 05/10] driver core: Export device_driver_attach() Greg Kroah-Hartman
2021-06-15 10:49 ` Cornelia Huck
[not found] ` <20210614150846.4111871-7-hch@lst.de>
2021-06-15 10:50 ` [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE Cornelia Huck
[not found] ` <20210614150846.4111871-8-hch@lst.de>
2021-06-15 10:54 ` [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMg4F99j2nsjGxAz@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).