From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55436C48BE6 for ; Wed, 16 Jun 2021 06:39:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BCCB61375 for ; Wed, 16 Jun 2021 06:39:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BCCB61375 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B332C6E509; Wed, 16 Jun 2021 06:39:46 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B0856E4F1; Wed, 16 Jun 2021 06:39:45 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3476061107; Wed, 16 Jun 2021 06:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623825585; bh=EaiCM4M1HV/P3rmM6VEHDeHmAfCx+R4BQyVTxflK9Rs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=epaxgNqHuYyJv4EAYE7ldLg69Mxe1hHr3+3rsbNb30tg0BFhlw89SENvOIoieBf33 HrKpn2jASbD8+ltQq/PkXuqainx2eVE7VIqE0yaDtRGv8wkEGBTI5LfsFDoT7cZ3tm FQktllr0bRzKCGZXXqa4iSepc5k04YuH8udl+DhY= Date: Wed, 16 Jun 2021 08:39:41 +0200 From: Greg Kroah-Hartman To: Jason Gunthorpe Subject: Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Message-ID: References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-8-hch@lst.de> <20210616000040.GE1002214@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210616000040.GE1002214@nvidia.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Kirti Wankhede , Christoph Hellwig , linux-s390@vger.kernel.org, Jonathan Corbet , "Rafael J. Wysocki" , Halil Pasic , Christian Borntraeger , intel-gfx@lists.freedesktop.org, Jason Herne , Vasily Gorbik , Heiko Carstens , Alex Williamson , Rodrigo Vivi , Tony Krowiak , Cornelia Huck Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 15, 2021 at 09:00:40PM -0300, Jason Gunthorpe wrote: > On Tue, Jun 15, 2021 at 04:11:29PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 15, 2021 at 03:35:16PM +0200, Christoph Hellwig wrote: > > > From: Jason Gunthorpe > > > > > > This allows a mdev driver to opt out of using vfio_mdev.c, instead the > > > driver will provide a 'struct mdev_driver' and register directly with the > > > driver core. > > > > > > Much of mdev_parent_ops becomes unused in this mode: > > > - create()/remove() are done via the mdev_driver probe()/remove() > > > - mdev_attr_groups becomes mdev_driver driver.dev_groups > > > - Wrapper function callbacks are replaced with the same ones from > > > struct vfio_device_ops > > > > > > Signed-off-by: Jason Gunthorpe > > > Signed-off-by: Christoph Hellwig > > > > Messy, but ok... > > Is there something you'd like to see changed, eg in later patches? > This whole work still has another approx 30 patches to go and much of > this ends up being erased once the drivers are all converted. If this mostly gets removed in the end, I'm happy. Let's see how it looks after all of that is done. This is going forward in the right way, so I do not object to this at all. thanks, greg k-h