dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Subject: Re: [PATCH] dt-bindings: display: renesas,du: Make resets optional on R-Car H1
Date: Thu, 17 Jun 2021 04:57:22 +0300	[thread overview]
Message-ID: <YMqsAkFfAU02t4oD@pendragon.ideasonboard.com> (raw)
In-Reply-To: <YIrU+tdcfQ/6ODRz@pendragon.ideasonboard.com>

Hi Geert,

On Thu, Apr 29, 2021 at 06:47:06PM +0300, Laurent Pinchart wrote:
> On Thu, Apr 29, 2021 at 02:47:31PM +0200, Geert Uytterhoeven wrote:
> > The "resets" property is not present on R-Car Gen1 SoCs.
> > Supporting it would require migrating from renesas,cpg-clocks to
> > renesas,cpg-mssr.
> > 
> > Reflect this in the DT bindings by removing the global "required:
> > resets".  All SoCs that do have "resets" properties already have
> > SoC-specific rules making it required.
> 
> Should we drop the
> 
>         resets:
> 	  maxItems: 1
> 
> from renesas,du-r8a7779 then ? And maybe the
> 
>   resets: true
> 
> in the general case ?

Any opinion on this ?

> > Fixes: 99d66127fad25ebb ("dt-bindings: display: renesas,du: Convert binding to YAML")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  Documentation/devicetree/bindings/display/renesas,du.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > index 552a99ce4f1280d7..e955034da53b86e2 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > @@ -89,7 +89,6 @@ required:
> >    - reg
> >    - clocks
> >    - interrupts
> > -  - resets
> >    - ports
> >  
> >  allOf:

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2021-06-17  1:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 12:47 [PATCH] dt-bindings: display: renesas, du: Make resets optional on R-Car H1 Geert Uytterhoeven
2021-04-29 15:47 ` [PATCH] dt-bindings: display: renesas,du: " Laurent Pinchart
2021-06-17  1:57   ` Laurent Pinchart [this message]
2021-06-17  7:22     ` [PATCH] dt-bindings: display: renesas, du: " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMqsAkFfAU02t4oD@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).