dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: linux-pm@vger.kernel.org, "Nicolas Chauvet" <kwizart@gmail.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Matt Merhar" <mattmerhar@protonmail.com>,
	"Peter Geis" <pgwipeout@gmail.com>,
	linux-tegra@vger.kernel.org,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: Re: [PATCH v18 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver
Date: Mon, 21 Jun 2021 13:01:28 +0200	[thread overview]
Message-ID: <YNBxiFXMS9rfT93c@orome.fritz.box> (raw)
In-Reply-To: <50912a57-aa43-58b0-02d2-6928578d6286@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

On Mon, Jun 21, 2021 at 07:19:15AM +0300, Dmitry Osipenko wrote:
> 07.06.2021 01:40, Dmitry Osipenko пишет:
> > 01.06.2021 07:21, Dmitry Osipenko пишет:
> >> This series adds memory bandwidth management to the NVIDIA Tegra DRM driver,
> >> which is done using interconnect framework. It fixes display corruption that
> >> happens due to insufficient memory bandwidth.
> >>
> >> Changelog:
> >>
> >> v18: - Moved total peak bandwidth from CRTC state to plane state and removed
> >>        dummy plane bandwidth state initialization from T186+ plane hub. This
> >>        was suggested by Thierry Reding to v17.
> >>
> >>      - I haven't done anything about the cursor's plane bandwidth which
> >>        doesn't contribute to overlapping bandwidths for a small sized
> >>        window because it works okay as-is.
> > 
> > Thierry, will you take these patches for 5.14?
> > 
> 
> The display controller does _NOT_WORK_ properly without bandwidth
> management.

That's surprising. So either it has never worked before (which I think
I'd know) or something has caused this regression recently. In the
latter case we need to identify what that was and revert (or fix) it.

> Can we get this patch into 5.14? What is the problem?

There was not enough time to review and test this, so I didn't feel
comfortable picking it up so close to the -rc6 cut-off. I plan to pick
this up early in the v5.14 release cycle and target v5.15.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-06-21 10:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01  4:21 [PATCH v18 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver Dmitry Osipenko
2021-06-01  4:21 ` [PATCH v18 1/2] drm/tegra: dc: Support memory bandwidth management Dmitry Osipenko
2021-06-01  4:21 ` [PATCH v18 2/2] drm/tegra: dc: Extend debug stats with total number of events Dmitry Osipenko
2021-06-06 22:40 ` [PATCH v18 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver Dmitry Osipenko
2021-06-21  4:19   ` Dmitry Osipenko
2021-06-21 11:01     ` Thierry Reding [this message]
2021-06-21 11:43       ` Dmitry Osipenko
2021-07-18 20:59         ` Dmitry Osipenko
2021-08-13 10:33   ` Thierry Reding
2021-08-13 13:27     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNBxiFXMS9rfT93c@orome.fritz.box \
    --to=thierry.reding@gmail.com \
    --cc=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=kwizart@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mattmerhar@protonmail.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=pgwipeout@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).