Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jonathan Liu <net147@gmail.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Sam Ravnborg <sam@ravnborg.org>, Jonas Karlman <jonas@kwiboo.se>,
	Sandy Huang <hjc@rock-chips.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Philippe Cornu <philippe.cornu@st.com>,
	Yannick Fertre <yannick.fertre@st.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Vincent Abriou <vincent.abriou@st.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe
Date: Thu, 24 Jun 2021 15:51:05 +0300	[thread overview]
Message-ID: <YNR/uQrS75s5BILs@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CANwerB1AiiT3oXCpwP83M1=ES9M-yQoLuZO5f=eVxA42MkEbiA@mail.gmail.com>

CC'ing Maxime Ripard.

Maxime, is this similar to the issue we've recently discussed with the
VC4 DSI encoder ?

On Thu, Jun 24, 2021 at 10:39:48PM +1000, Jonathan Liu wrote:
> On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote:
> > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote:
> > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote:
> > > > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
> > > >         dw_mipi_dsi_debugfs_init(dsi);
> > > >         pm_runtime_enable(dev);
> > > >
> > > > +       ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0,
> > > > +                                         &panel, &bridge);
> > > > +       if (ret)
> > > > +               return ERR_PTR(ret);
> > >
> > > On RK3399 if the error is EPROBE_DEFER, __dw_mipi_dsi_probe can be
> > > called again and result in the following errors:
> > > [    0.717589] debugfs: Directory 'ff960000.mipi' with parent '/' already present!
> > > [    0.717601] dw-mipi-dsi-rockchip ff960000.mipi: failed to create debugfs root
> > > [    0.717606] dw-mipi-dsi-rockchip ff960000.mipi: Unbalanced pm_runtime_enable!
> >
> > Is this when you test bridge on rk3399 or panel?
> 
> MIPI-DSI to LVDS bridge.

-- 
Regards,

Laurent Pinchart