From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-fbdev@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH resend 3/5] video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range()
Date: Mon, 19 Jul 2021 21:07:32 +0200 [thread overview]
Message-ID: <YPXNdJNpYoPSpxSb@ravnborg.org> (raw)
In-Reply-To: <20210714145804.2530727-4-geert@linux-m68k.org>
Hi Geert,
On Wed, Jul 14, 2021 at 04:58:02PM +0200, Geert Uytterhoeven wrote:
> Extract the code to set the column and page ranges into a helper
> function.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/video/fbdev/ssd1307fb.c | 61 +++++++++++++++++++--------------
> 1 file changed, 36 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 6d7bd025bca1a175..cfa27ea0feab4f01 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -152,6 +152,38 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd)
> return ret;
> }
>
> +static int ssd1307fb_set_address_range(struct ssd1307fb_par *par, u8 col_start,
> + u8 cols, u8 page_start, u8 pages)
> +{
Bikeshedding, but I think a dedicated function for col_range and another
for page_range had been simpler to read.
With or wihout this change:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
> + u8 col_end = col_start + cols - 1;
> + u8 page_end = page_start + pages - 1;
> + int ret;
> +
> + /* Set column range */
> + ret = ssd1307fb_write_cmd(par->client, SSD1307FB_SET_COL_RANGE);
> + if (ret < 0)
> + return ret;
> +
> + ret = ssd1307fb_write_cmd(par->client, col_start);
> + if (ret < 0)
> + return ret;
> +
> + ret = ssd1307fb_write_cmd(par->client, col_end);
> + if (ret < 0)
> + return ret;
> +
> + /* Set page range */
> + ret = ssd1307fb_write_cmd(par->client, SSD1307FB_SET_PAGE_RANGE);
> + if (ret < 0)
> + return ret;
> +
> + ret = ssd1307fb_write_cmd(par->client, page_start);
> + if (ret < 0)
> + return ret;
> +
> + return ssd1307fb_write_cmd(par->client, page_end);
> +}
> +
> static int ssd1307fb_update_display(struct ssd1307fb_par *par)
> {
> struct ssd1307fb_array *array;
> @@ -461,31 +493,10 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
> if (ret < 0)
> return ret;
>
> - /* Set column range */
> - ret = ssd1307fb_write_cmd(par->client, SSD1307FB_SET_COL_RANGE);
> - if (ret < 0)
> - return ret;
> -
> - ret = ssd1307fb_write_cmd(par->client, par->col_offset);
> - if (ret < 0)
> - return ret;
> -
> - ret = ssd1307fb_write_cmd(par->client, par->col_offset + par->width - 1);
> - if (ret < 0)
> - return ret;
> -
> - /* Set page range */
> - ret = ssd1307fb_write_cmd(par->client, SSD1307FB_SET_PAGE_RANGE);
> - if (ret < 0)
> - return ret;
> -
> - ret = ssd1307fb_write_cmd(par->client, par->page_offset);
> - if (ret < 0)
> - return ret;
> -
> - ret = ssd1307fb_write_cmd(par->client,
> - par->page_offset +
> - DIV_ROUND_UP(par->height, 8) - 1);
> + /* Set column and page range */
> + ret = ssd1307fb_set_address_range(par, par->col_offset, par->width,
> + par->page_offset,
> + DIV_ROUND_UP(par->height, 8));
> if (ret < 0)
> return ret;
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-07-19 19:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 14:57 [PATCH resend 0/5] video: fbdev: ssd1307fb: Optimizations and improvements Geert Uytterhoeven
2021-07-14 14:58 ` [PATCH resend 1/5] video: fbdev: ssd1307fb: Propagate errors via ssd1307fb_update_display() Geert Uytterhoeven
2021-07-14 14:58 ` [PATCH resend 2/5] video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display() Geert Uytterhoeven
2021-07-19 19:05 ` Sam Ravnborg
2021-07-20 7:43 ` Geert Uytterhoeven
2021-07-20 14:41 ` Sam Ravnborg
2021-07-14 14:58 ` [PATCH resend 3/5] video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range() Geert Uytterhoeven
2021-07-19 19:07 ` Sam Ravnborg [this message]
2021-07-20 7:51 ` Geert Uytterhoeven
2021-07-14 14:58 ` [PATCH resend 4/5] video: fbdev: ssd1307fb: Optimize screen updates Geert Uytterhoeven
2021-07-19 19:21 ` Sam Ravnborg
2021-07-20 7:56 ` Geert Uytterhoeven
2021-07-20 9:16 ` Geert Uytterhoeven
2021-07-20 14:39 ` Sam Ravnborg
2021-07-14 14:58 ` [PATCH resend 5/5] video: fbdev: ssd1307fb: Cache address ranges Geert Uytterhoeven
2021-07-14 15:27 ` [PATCH resend 0/5] video: fbdev: ssd1307fb: Optimizations and improvements Sam Ravnborg
2021-07-15 6:54 ` Geert Uytterhoeven
2021-07-20 14:53 ` Daniel Vetter
2021-07-19 19:23 ` Sam Ravnborg
2021-07-20 7:33 ` Geert Uytterhoeven
2021-07-20 14:45 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPXNdJNpYoPSpxSb@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).