From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BBF7C07E95 for ; Tue, 20 Jul 2021 14:45:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02D55611CE for ; Tue, 20 Jul 2021 14:45:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02D55611CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 680896E183; Tue, 20 Jul 2021 14:45:45 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8099D6E183 for ; Tue, 20 Jul 2021 14:45:44 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 2a39336e-e969-11eb-9082-0050568c148b; Tue, 20 Jul 2021 14:45:45 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id A6564194B81; Tue, 20 Jul 2021 16:45:58 +0200 (CEST) Date: Tue, 20 Jul 2021 16:45:41 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Geert Uytterhoeven Subject: Re: [PATCH resend 0/5] video: fbdev: ssd1307fb: Optimizations and improvements Message-ID: References: <20210714145804.2530727-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Fbdev development list , David Airlie , Linux Kernel Mailing List , DRI Development Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Geert, On Tue, Jul 20, 2021 at 09:33:11AM +0200, Geert Uytterhoeven wrote: > Hi Sam, > > On Mon, Jul 19, 2021 at 9:23 PM Sam Ravnborg wrote: > > On Wed, Jul 14, 2021 at 04:57:59PM +0200, Geert Uytterhoeven wrote: > > > This patch series optimizes console operations on ssd1307fb, after the > > > customary fixes and cleanups. > > > > > > Currently, each screen update triggers an I2C transfer of all screen > > > data, up to 1 KiB of data for a 128x64 display, which takes at least 20 > > > ms in Fast mode. While many displays are smaller, and thus require less > > > data to be transferred, 20 ms is still an optimistic value, as the > > > actual data transfer may be much slower, especially on bitbanged I2C > > > drivers. After this series, the amount of data transfer is reduced, as > > > fillrect, copyarea, and imageblit only update the rectangle that > > > changed. > > > > > > This has been tested on an Adafruit FeatherWing OLED with an SSD1306 > > > controller and a 128x32 OLED, connected to an OrangeCrab ECP5 FPGA board > > > running a 64 MHz VexRiscv RISC-V softcore, where it reduced the CPU > > > usage for blinking the cursor from more than 70% to ca. 10%. > > > > > > Thanks for your comments! > > > > > > Geert Uytterhoeven (5): > > > video: fbdev: ssd1307fb: Propagate errors via > > > ssd1307fb_update_display() > > > video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display() > > > video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range() > > > video: fbdev: ssd1307fb: Optimize screen updates > > > video: fbdev: ssd1307fb: Cache address ranges > > > > A few comments left for a couple of patches. > > The remaining patches are: > > Acked-by: Sam Ravnborg > > Thank you! > > > Do you have commit rights to drm-misc-next? > > No I have not (and I don't think I should). I would love to have you around for the fbdev stuff, as you knows a ton more about fbdev than I do - I am just pretending. And it would then be good if you could apply patches too. I for one may be off for shorter or longer periods as this is purely driven by interest. Note: I assume you will resend the series - then I can apply. Sam