From: Sam Ravnborg <sam@ravnborg.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org,
Robert Foss <robert.foss@linaro.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 03/10] drm/bridge: Add documentation sections
Date: Tue, 20 Jul 2021 21:51:30 +0200 [thread overview]
Message-ID: <YPcpQuWF9eod5s7R@ravnborg.org> (raw)
In-Reply-To: <20210720134525.563936-4-maxime@cerno.tech>
On Tue, Jul 20, 2021 at 03:45:18PM +0200, Maxime Ripard wrote:
> The bridge documentation overview is quite packed already, and we'll add
> some more documentation that isn't part of an overview at all.
>
> Let's add some sections to the documentation to separare each bits.
s/separare/separate/
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> Documentation/gpu/drm-kms-helpers.rst | 6 ++++++
> drivers/gpu/drm/drm_bridge.c | 14 +++++++++-----
> 2 files changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst
> index 389892f36185..10f8df7aecc0 100644
> --- a/Documentation/gpu/drm-kms-helpers.rst
> +++ b/Documentation/gpu/drm-kms-helpers.rst
> @@ -151,6 +151,12 @@ Overview
> .. kernel-doc:: drivers/gpu/drm/drm_bridge.c
> :doc: overview
>
> +Display Driver Integration
> +--------------------------
> +
> +.. kernel-doc:: drivers/gpu/drm/drm_bridge.c
> + :doc: display driver integration
> +
> Bridge Operations
> -----------------
>
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index aef8c9f4fb9f..c9a950bfdfe5 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -50,6 +50,15 @@
> * Chaining multiple bridges to the output of a bridge, or the same bridge to
> * the output of different bridges, is not supported.
> *
> + * &drm_bridge, like &drm_panel, aren't &drm_mode_object entities like planes,
> + * CRTCs, encoders or connectors and hence are not visible to userspace. They
> + * just provide additional hooks to get the desired output at the end of the
> + * encoder chain.
> + */
> +
> +/**
> + * DOC: display driver integration
> + *
> * Display drivers are responsible for linking encoders with the first bridge
> * in the chains. This is done by acquiring the appropriate bridge with
> * drm_of_get_next(). Once acquired, the bridge shall be attached to the
> @@ -84,11 +93,6 @@
> * helper to create the &drm_connector, or implement it manually on top of the
> * connector-related operations exposed by the bridge (see the overview
> * documentation of bridge operations for more details).
> - *
> - * &drm_bridge, like &drm_panel, aren't &drm_mode_object entities like planes,
> - * CRTCs, encoders or connectors and hence are not visible to userspace. They
> - * just provide additional hooks to get the desired output at the end of the
> - * encoder chain.
> */
>
> static DEFINE_MUTEX(bridge_lock);
> --
> 2.31.1
next prev parent reply other threads:[~2021-07-20 19:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 13:45 [PATCH 00/10] drm/bridge: Make panel and bridge probe order consistent Maxime Ripard
2021-07-20 13:45 ` [PATCH 01/10] Revert "drm/vc4: dsi: Only register our component once a DSI device is attached" Maxime Ripard
2021-07-20 13:45 ` [PATCH 02/10] drm/bridge: Add a function to abstract away panels Maxime Ripard
2021-07-20 17:34 ` Sam Ravnborg
2021-07-22 7:49 ` Jagan Teki
2021-07-20 13:45 ` [PATCH 03/10] drm/bridge: Add documentation sections Maxime Ripard
2021-07-20 19:51 ` Sam Ravnborg [this message]
2021-07-20 13:45 ` [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges Maxime Ripard
2021-07-21 12:05 ` Daniel Vetter
2021-07-21 12:06 ` Daniel Vetter
2021-07-26 15:16 ` Maxime Ripard
2021-07-27 9:20 ` Daniel Vetter
2021-07-28 13:27 ` Maxime Ripard
2021-07-27 9:42 ` Jagan Teki
2021-07-28 13:35 ` Maxime Ripard
2021-08-05 12:19 ` Jagan Teki
2021-07-20 13:45 ` [PATCH 05/10] drm/panel: Create attach and detach callbacks Maxime Ripard
2021-07-20 19:53 ` Sam Ravnborg
2021-07-22 7:53 ` Jagan Teki
2021-07-20 13:45 ` [PATCH 06/10] drm/bridge: panel: Call attach and detach for the panel Maxime Ripard
2021-07-20 19:56 ` Sam Ravnborg
2021-07-20 13:45 ` [PATCH 07/10] drm/vc4: dsi: Switch to drm_of_get_next Maxime Ripard
2021-07-20 13:45 ` [PATCH 08/10] drm/panel: raspberrypi-touchscreen: Prevent double-free Maxime Ripard
2021-07-20 17:19 ` Sam Ravnborg
2021-07-22 9:38 ` Maxime Ripard
2021-07-20 13:45 ` [PATCH 09/10] drm/panel: raspberrypi-touchscreen: Use the attach hook Maxime Ripard
2021-07-20 13:45 ` [PATCH 10/10] drm/panel: raspberrypi-touchscreen: Remove MIPI-DSI driver Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPcpQuWF9eod5s7R@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).