From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: freedreno@lists.freedesktop.org,
Jonathan Marek <jonathan@marek.ca>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org,
Abhinav Kumar <abhinavk@codeaurora.org>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v4 5/7] drm/msm/dp: stop calling set_encoder_mode callback
Date: Sat, 24 Jul 2021 23:08:09 -0500 [thread overview]
Message-ID: <YPzjqYLVM/G/YzrD@yoga> (raw)
In-Reply-To: <20210717124016.316020-6-dmitry.baryshkov@linaro.org>
On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote:
> None of the display drivers now implement set_encoder_mode callback.
> Stop calling it from the modeset init code.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 051c1be1de7e..70b319a8fe83 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -102,8 +102,6 @@ struct dp_display_private {
> struct dp_display_mode dp_mode;
> struct msm_dp dp_display;
>
> - bool encoder_mode_set;
> -
> /* wait for audio signaling */
> struct completion audio_comp;
>
> @@ -283,20 +281,6 @@ static void dp_display_send_hpd_event(struct msm_dp *dp_display)
> }
>
>
> -static void dp_display_set_encoder_mode(struct dp_display_private *dp)
> -{
> - struct msm_drm_private *priv = dp->dp_display.drm_dev->dev_private;
> - struct msm_kms *kms = priv->kms;
> -
> - if (!dp->encoder_mode_set && dp->dp_display.encoder &&
> - kms->funcs->set_encoder_mode) {
> - kms->funcs->set_encoder_mode(kms,
> - dp->dp_display.encoder, false);
> -
> - dp->encoder_mode_set = true;
> - }
> -}
> -
> static int dp_display_send_hpd_notification(struct dp_display_private *dp,
> bool hpd)
> {
> @@ -369,8 +353,6 @@ static void dp_display_host_init(struct dp_display_private *dp, int reset)
> if (dp->usbpd->orientation == ORIENTATION_CC2)
> flip = true;
>
> - dp_display_set_encoder_mode(dp);
> -
> dp_power_init(dp->power, flip);
> dp_ctrl_host_init(dp->ctrl, flip, reset);
> dp_aux_init(dp->aux);
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-07-25 4:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 12:40 [PATCH v4 0/7] drm/msm/dpu: add support for independent DSI config Dmitry Baryshkov
2021-07-17 12:40 ` [PATCH v4 1/7] drm/msm/dsi: rename dual DSI to bonded DSI Dmitry Baryshkov
2021-07-23 3:07 ` Bjorn Andersson
2021-07-17 12:40 ` [PATCH v4 2/7] drm/msm/dsi: add three helper functions Dmitry Baryshkov
2021-07-19 10:31 ` kernel test robot
2021-07-25 4:05 ` Bjorn Andersson
2021-07-17 12:40 ` [PATCH v4 3/7] drm/msm/dpu: support setting up two independent DSI connectors Dmitry Baryshkov
2021-07-25 4:06 ` Bjorn Andersson
2021-07-17 12:40 ` [PATCH v4 4/7] drm/msm/mdp5: move mdp5_encoder_set_intf_mode after msm_dsi_modeset_init Dmitry Baryshkov
2021-07-25 4:07 ` Bjorn Andersson
2021-07-17 12:40 ` [PATCH v4 5/7] drm/msm/dp: stop calling set_encoder_mode callback Dmitry Baryshkov
2021-07-25 4:08 ` Bjorn Andersson [this message]
2021-07-17 12:40 ` [PATCH v4 6/7] drm/msm/dsi: " Dmitry Baryshkov
2021-07-25 4:08 ` Bjorn Andersson
2021-07-17 12:40 ` [PATCH v4 7/7] drm/msm/kms: drop " Dmitry Baryshkov
2021-07-25 4:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPzjqYLVM/G/YzrD@yoga \
--to=bjorn.andersson@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).