From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 651FAC4338F for ; Sun, 25 Jul 2021 04:08:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09C2C606A5 for ; Sun, 25 Jul 2021 04:08:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 09C2C606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83C2F6E11A; Sun, 25 Jul 2021 04:08:44 +0000 (UTC) Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61BA7737F2 for ; Sun, 25 Jul 2021 04:08:43 +0000 (UTC) Received: by mail-oi1-x230.google.com with SMTP id t14so6930423oiw.0 for ; Sat, 24 Jul 2021 21:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4EjfvfsCnIfJzIDqvMiXOdpA/RzqpY5JQx4yaoDus44=; b=Jm+R2TZ+MdhwPbsYW1kVKkQA6nDkRYzbmlD/yofrxgzHwLK7t19MpoIKD6uOoWemxp sm65mjbLVqTScU1C4waH/P/YysQdP8QiBNTI4tWLlfoA6SpAHm1pPLAY4SnV1PDKnnzF aBiL9AnCApEOXZBP262szkx3jtCSS4jPdpZgK1Dgpr/F4Fiias0ZDuumQH7tIHmP6pPj u5ax97GViXY0U4UOja9medD97eN8NHfhORYWoABvzB8dd/zN+Qogv2Ar61uuB+8cCSSi fP23+PnBtvCu7lQMqfx0fo4X9zgn4Zk+I+Mtol3KKMAb7XOxTn+xXVE3OA2rkcEG5gy5 SLIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4EjfvfsCnIfJzIDqvMiXOdpA/RzqpY5JQx4yaoDus44=; b=Mt4uaxUtk26/r8vGGXlY84vuwTUBR705kBimIiNXlMOU3qGQcN3rt4IuNJZseJxMtT l2uJ5W5JmaCu1aF+5DSGUEhDUwGsPNxzJE/4Tbv6r4zd/ETHebnRERv6K/6vWWEAY/qP CtydFCeZlEQwavpOwsB8DHMA38od3iiT7SwL3bgcSjdIEC4TaOxT0HX5BftOoLJHcTNj 56WM7oz8ihVGoT301GHORKyAOY+TjzxZsLgIjA2NfZqTsFsqQMkNUtY9H67pB4emnvCR WcifCpVYS6jQB1FO3UOlLhtIfoyshtd2EK7qZuq5brpYnMa0vlAFR3PpylZKbw88FQYm 48Cg== X-Gm-Message-State: AOAM533iornYOX996uLH7edbAjlETH2KJXCyYkZYQS3bxwe3m/miEoIe utYPd94xpjifmArs6M9BeGzttg== X-Google-Smtp-Source: ABdhPJyB37DGqI8iRmzu9V40UiIvFN1SGDEs+M+0N/hhyYA86IxgTCxFn3+xl2//CQoduQBQIB4wtQ== X-Received: by 2002:a54:468d:: with SMTP id k13mr353628oic.100.1627186122781; Sat, 24 Jul 2021 21:08:42 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r1sm1510858ooc.16.2021.07.24.21.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 21:08:42 -0700 (PDT) Date: Sat, 24 Jul 2021 23:08:40 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Subject: Re: [PATCH v4 6/7] drm/msm/dsi: stop calling set_encoder_mode callback Message-ID: References: <20210717124016.316020-1-dmitry.baryshkov@linaro.org> <20210717124016.316020-7-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210717124016.316020-7-dmitry.baryshkov@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Jonathan Marek , Stephen Boyd , linux-arm-msm@vger.kernel.org, Abhinav Kumar , David Airlie , dri-devel@lists.freedesktop.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > None of the display drivers now implement set_encoder_mode callback. > Stop calling it from the modeset init code. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dsi/dsi.c | 2 -- > drivers/gpu/drm/msm/dsi/dsi.h | 1 - > drivers/gpu/drm/msm/dsi/dsi_manager.c | 12 ------------ > 3 files changed, 15 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c > index 5201d7eb0490..77c8dba297d8 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.c > +++ b/drivers/gpu/drm/msm/dsi/dsi.c > @@ -251,8 +251,6 @@ int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev, > goto fail; > } > > - msm_dsi_manager_setup_encoder(msm_dsi->id); > - > priv->bridges[priv->num_bridges++] = msm_dsi->bridge; > priv->connectors[priv->num_connectors++] = msm_dsi->connector; > > diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h > index 856a532850c0..e0c3c4409377 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.h > +++ b/drivers/gpu/drm/msm/dsi/dsi.h > @@ -80,7 +80,6 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 id); > struct drm_connector *msm_dsi_manager_ext_bridge_init(u8 id); > int msm_dsi_manager_cmd_xfer(int id, const struct mipi_dsi_msg *msg); > bool msm_dsi_manager_cmd_xfer_trigger(int id, u32 dma_base, u32 len); > -void msm_dsi_manager_setup_encoder(int id); > int msm_dsi_manager_register(struct msm_dsi *msm_dsi); > void msm_dsi_manager_unregister(struct msm_dsi *msm_dsi); > bool msm_dsi_manager_validate_current_config(u8 id); > diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c > index 27d3b9ebf831..693078e68fd4 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c > @@ -216,18 +216,6 @@ static int dsi_mgr_bridge_get_id(struct drm_bridge *bridge) > return dsi_bridge->id; > } > > -void msm_dsi_manager_setup_encoder(int id) > -{ > - struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id); > - struct msm_drm_private *priv = msm_dsi->dev->dev_private; > - struct msm_kms *kms = priv->kms; > - struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi); > - > - if (encoder && kms->funcs->set_encoder_mode) > - kms->funcs->set_encoder_mode(kms, encoder, > - msm_dsi_is_cmd_mode(msm_dsi)); > -} > - > static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) > { > struct msm_drm_private *priv = conn->dev->dev_private; > -- > 2.30.2 >