From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2582C4320E for ; Wed, 28 Jul 2021 20:11:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D4D461040 for ; Wed, 28 Jul 2021 20:11:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D4D461040 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D52AD6E0D5; Wed, 28 Jul 2021 20:11:46 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C83A6E0D5 for ; Wed, 28 Jul 2021 20:11:45 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 11b79c7f-efe0-11eb-8d1a-0050568cd888; Wed, 28 Jul 2021 20:12:01 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 82FBC194B23; Wed, 28 Jul 2021 22:12:02 +0200 (CEST) Date: Wed, 28 Jul 2021 22:11:39 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Dan.Sneddon@microchip.com Subject: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces Message-ID: References: <20210727182721.17981-4-tzimmermann@suse.de> <3d2f6b84-dd07-d925-a8b8-2bfd5fc736d9@microchip.com> <2f04b986-6b41-62f9-1587-23818b841655@suse.de> <793514f6-0270-771b-fe36-f82edf4e5fd2@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, liviu.dudau@arm.com, amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, tzimmermann@suse.de, edmund.j.dea@intel.com, s.hauer@pengutronix.de, alison.wang@nxp.com, dri-devel@lists.freedesktop.org, sean@poorly.run, linux-arm-kernel@lists.infradead.org, tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi, Nicolas.Ferre@microchip.com, christian.koenig@amd.com, kernel@pengutronix.de, alexander.deucher@amd.com, shawnguo@kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dan, > > > > I think I got it - we need to set irq_enabled to true. > > The documentation says so: > > " > > * @irq_enabled: > > * > > * Indicates that interrupt handling is enabled, specifically vblank > > * handling. Drivers which don't use drm_irq_install() need to set this > > * to true manually. > > " > > > > Can you try to add the following line: > > > > > > +static int atmel_hlcdc_dc_irq_install(struct drm_device *dev, unsigned int irq) > > +{ > > + int ret; > > + > > + if (irq == IRQ_NOTCONNECTED) > > + return -ENOTCONN; > > + > > > > dev->irq_enabled = true; <= THIS LINE > > > > > > + atmel_hlcdc_dc_irq_disable(dev); > > + > > + ret = request_irq(irq, atmel_hlcdc_dc_irq_handler, 0, dev->driver->name, dev); > > + if (ret) > > + return ret; > > > > I hope this fixes it. > > It does! With the irq_enabled line added everything is looking good. Great, thanks for testing. Thomas - I assume you will do a re-spin and there is likely some fixes for the applied IRQ conversions too. Note - irq_enabled must be cleared if request_irq fails. I did not include this in the testing here. Sam