From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D75FC4338F for ; Thu, 29 Jul 2021 16:50:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9882D60EFD for ; Thu, 29 Jul 2021 16:50:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9882D60EFD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 030A06EDF2; Thu, 29 Jul 2021 16:50:29 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2210D6EDF3 for ; Thu, 29 Jul 2021 16:50:27 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 1c1c2356-f08d-11eb-8d1a-0050568cd888; Thu, 29 Jul 2021 16:50:41 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id D1FF4194B1F; Thu, 29 Jul 2021 18:50:41 +0200 (CEST) Date: Thu, 29 Jul 2021 18:50:17 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Robert Foss Subject: Re: [RFC PATCH 05/17] drm/exynos: dsi: Get the mode from bridge Message-ID: References: <20210704090230.26489-1-jagan@amarulasolutions.com> <20210704090230.26489-6-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , Neil Armstrong , Krzysztof Kozlowski , Seung-Woo Kim , NXP Linux Team , dri-devel , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Jagan Teki , Daniel Vetter , linux-amarula , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jul 29, 2021 at 03:20:17PM +0200, Robert Foss wrote: > Hey Jagan, > > On Sun, 4 Jul 2021 at 11:04, Jagan Teki wrote: > > > > Now the exynos dsi driver is fully aware of bridge > > handling, so get the display mode from bridge, mode_set > > API instead of legacy encoder crtc. > > > > This makes bridge usage more efficient instead of relying > > on encoder stack. > > > > Add mode_set in drm_bridge_funcs. > > > > Signed-off-by: Jagan Teki > > --- > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > index d828be07c325..99a1b8c22313 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > @@ -275,6 +275,7 @@ struct exynos_dsi { > > u32 format; > > > > int state; > > + struct drm_display_mode mode; > > struct drm_property *brightness; > > struct completion completed; > > > > @@ -881,7 +882,7 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) > > > > static void exynos_dsi_set_display_mode(struct exynos_dsi *dsi) > > { > > - struct drm_display_mode *m = &dsi->encoder.crtc->state->adjusted_mode; > > + struct drm_display_mode *m = &dsi->mode; > > unsigned int num_bits_resol = dsi->driver_data->num_bits_resol; > > u32 reg; > > > > @@ -1411,6 +1412,15 @@ static void exynos_dsi_bridge_disable(struct drm_bridge *bridge) > > pm_runtime_put_sync(dsi->dev); > > } > > > > +static void exynos_dsi_bridge_mode_set(struct drm_bridge *bridge, > > + const struct drm_display_mode *mode, > > + const struct drm_display_mode *adjusted_mode) > > +{ > > + struct exynos_dsi *dsi = bridge_to_dsi(bridge); > > + > > + drm_mode_copy(&dsi->mode, adjusted_mode); > > +} > > + > > static int exynos_dsi_panel_or_bridge(struct exynos_dsi *dsi, > > struct device_node *node) > > { > > @@ -1451,6 +1461,7 @@ static int exynos_dsi_bridge_attach(struct drm_bridge *bridge, > > static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { > > .enable = exynos_dsi_bridge_enable, > > .disable = exynos_dsi_bridge_disable, > > + .mode_set = exynos_dsi_bridge_mode_set, > > As far as I understand it, .enable(), .disable() &.mode_set() are > deprecated[1] and should be replaced by atomic_enable(), > atomic_disable() & atomic_enable() respectively. > > [1] https://lore.kernel.org/dri-devel/20210722062246.2512666-8-sam@ravnborg.org/ Correct, we are slowly moving away from the deprecated bridge functions. Need to find time to update my patchset that address some of this. Sam