From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E6DC432BE for ; Sun, 22 Aug 2021 00:01:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8D1D61183 for ; Sun, 22 Aug 2021 00:01:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E8D1D61183 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0701E89D42; Sun, 22 Aug 2021 00:01:41 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C13489D42 for ; Sun, 22 Aug 2021 00:01:39 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8400A8F; Sun, 22 Aug 2021 02:01:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1629590496; bh=prBVbLvTR9FFd7PKJjWNml62nJaJOiTBu5r2+3c7/ZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sxxdMuMp65CVwW5gbnQE+fFviTitztJJqwK7ELD4u5vaSVC38+wqdfeSF+hPPYY1L d689wdTNy1QiLQ/3GTgU2dyditoOuw/MaTjb3NaNKL9LAvMDqy9choQwHBDoBIzbfL zvBMr4K62rlgxnLlhXwZc+1ca0+fCvtHGlgOOpyo= Date: Sun, 22 Aug 2021 03:01:27 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: DRI Development , Linux-Renesas , Kieran Bingham Subject: Re: [PATCH v3 2/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper Message-ID: References: <20210520065046.28978-1-laurent.pinchart+renesas@ideasonboard.com> <20210520065046.28978-3-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Geert, On Tue, Aug 10, 2021 at 05:51:57PM +0200, Geert Uytterhoeven wrote: > On Tue, Aug 10, 2021 at 5:47 PM Geert Uytterhoeven wrote: > > On Thu, May 20, 2021 at 8:51 AM Laurent Pinchart wrote: > > > Replace the manual panel handling with usage of the DRM panel bridge > > > helper. This simplifies the driver, and brings support for > > > DRM_BRIDGE_ATTACH_NO_CONNECTOR as an added bonus. > > > > > > Signed-off-by: Laurent Pinchart > > > > Thanks for your patch, which is now commit e9e056949c927e5b ("drm: > > rcar-du: lvds: Convert to DRM panel bridge helper") in drm-next. > > > > This causes the following scary messages in the kernel log on Ebisu-4D: > > > > [drm:drm_bridge_attach] *ERROR* failed to attach bridge > > > Reverting this commit fixes the issue. > > Oops, that's not true (should not write tentative messages while booting > a test kernel, and press send without checking first ;-) > > Reverting the commit doesn't seem to make a difference. > But the parent 5bcc48395b9f35da ("drm: bridge: dw-hdmi: Attach to > next bridge if available") of the bad commit is fine. Thanks for the report. I've reproduced this and will send a fix shortly. -- Regards, Laurent Pinchart