From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Abhinav Kumar <abhinavk@codeaurora.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Kuogee Hsieh <khsieh@codeaurora.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers
Date: Fri, 27 Aug 2021 12:14:18 -0500 [thread overview]
Message-ID: <YSkdaljt7DPbyTDe@builder.lan> (raw)
In-Reply-To: <CAE-0n52YaQXQ4-=bR5ffMHOMp7CyFnCS-u9a2pddvaRUQhLrog@mail.gmail.com>
On Fri 27 Aug 00:20 CDT 2021, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2021-08-25 16:42:31)
> > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> > index 2c7de43f655a..4a6132c18e57 100644
> > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> > +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> > @@ -78,6 +78,8 @@ struct dp_display_private {
> > char *name;
> > int irq;
> >
> > + int id;
> > +
> > /* state variables */
> > bool core_initialized;
> > bool hpd_irq_on;
> > @@ -115,8 +117,19 @@ struct dp_display_private {
> > struct dp_audio *audio;
> > };
> >
> > +
> > +struct msm_dp_config {
> > + phys_addr_t io_start[3];
>
> Can this be made into another struct, like msm_dp_desc, that also
> indicates what type of DP connector it is, i.e. eDP vs DP? That would
> help me understand in modetest and /sys/class/drm what sort of connector
> is probing. dp_drm_connector_init() would need to pass the type of
> connector appropriately. Right now, eDP connectors still show up as DP
> instead of eDP in sysfs.
>
I like it, will spin a v3 with this.
Regards,
Bjorn
> > + size_t num_dp;
> > +};
> > +
> > +static const struct msm_dp_config sc7180_dp_cfg = {
> > + .io_start = { 0x0ae90000 },
> > + .num_dp = 1,
> > +};
> > +
> > static const struct of_device_id dp_dt_match[] = {
> > - {.compatible = "qcom,sc7180-dp"},
> > + { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> > {}
> > };
> >
next prev parent reply other threads:[~2021-08-27 17:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 23:42 [PATCH v2 0/5] drm/msm/dp: Support multiple DP instances and add sc8180x Bjorn Andersson
2021-08-25 23:42 ` [PATCH v2 1/5] drm/msm/dp: Remove global g_dp_display variable Bjorn Andersson
2021-08-26 6:54 ` Stephen Boyd
2021-08-25 23:42 ` [PATCH v2 2/5] drm/msm/dp: Modify prototype of encoder based API Bjorn Andersson
2021-08-26 7:06 ` Stephen Boyd
2021-08-25 23:42 ` [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers Bjorn Andersson
2021-08-26 7:13 ` Stephen Boyd
2021-08-26 16:57 ` Bjorn Andersson
2021-08-26 17:59 ` Stephen Boyd
2021-08-27 5:20 ` Stephen Boyd
2021-08-27 17:14 ` Bjorn Andersson [this message]
2021-09-28 17:22 ` khsieh
2021-10-01 13:58 ` Doug Anderson
2021-10-01 14:18 ` Bjorn Andersson
2021-08-25 23:42 ` [PATCH v2 4/5] dt-bindings: msm/dp: Add SC8180x compatibles Bjorn Andersson
2021-08-25 23:42 ` [PATCH v2 5/5] drm/msm/dp: Add sc8180x DP controllers Bjorn Andersson
2021-08-26 7:14 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSkdaljt7DPbyTDe@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).