From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E431EC433EF for ; Mon, 18 Oct 2021 19:58:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F28C61038 for ; Mon, 18 Oct 2021 19:58:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F28C61038 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B581B6E0F8; Mon, 18 Oct 2021 19:58:15 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id D36786E0F8 for ; Mon, 18 Oct 2021 19:58:14 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E04118F1; Mon, 18 Oct 2021 21:58:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1634587092; bh=h9q17lnxPlSuYfsSjKylh2YK+JZl6xp76jzw6AuN+eI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aOSt/e+TKryBtJKxp0QWaHcaNM47x892oLl///9lUx3rQkcQiFf9h2DocYYLKScAH e2uNJKZd8+yjGoMNftbMY6P/FCTj3yXf91DXft0D1XB+uoz3jbMRazgJmj8dr4Wpfv xXzVh9/gc/peA5/itmBm5F4sK06uQG2+90uhXVlI= Date: Mon, 18 Oct 2021 22:57:55 +0300 From: Laurent Pinchart To: Marek Vasut Cc: dri-devel@lists.freedesktop.org, Rob Herring , Sam Ravnborg , devicetree@vger.kernel.org Subject: Re: [PATCH v5 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select Message-ID: References: <20211017001204.299940-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Marek, On Mon, Oct 18, 2021 at 09:47:13PM +0200, Marek Vasut wrote: > On 10/18/21 8:08 PM, Laurent Pinchart wrote: > > [...] > > >> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > >> index 1faae3e323a4..708de84ac138 100644 > >> --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > >> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > >> @@ -79,6 +79,14 @@ properties: > >> - port@0 > >> - port@1 > >> > >> + pclk-sample: > >> + description: > >> + Data sampling on rising or falling edge. > >> + enum: > >> + - 0 # Falling edge > >> + - 1 # Rising edge > >> + default: 0 > >> + > > > > Shouldn't this be moved to the endpoint, the same way data-mapping is > > defined as an endpoint property ? > > The strapping is a chip property, not port property, so no. For this particular chip that's true. I'm still not convinced overall. For some cases it could be a per-port property, and moving it there for lvds-codec too could allow implementing helpers to parse DT properties, without much drawback for this particular use case as far as I can see. It's hard to predict the future with certainty of course, so I won't insist. -- Regards, Laurent Pinchart