dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: virtio-dev@lists.oasis-open.org, kraxel@redhat.com,
	dri-devel@lists.freedesktop.org,
	Gurchetan Singh <gurchetansingh@chromium.org>
Subject: Re: [PATCH v3 11/12] drm/virtio: implement context init: add virtio_gpu_fence_event
Date: Mon, 15 Nov 2021 15:16:26 +0100	[thread overview]
Message-ID: <YZJrutLaiwozLfSw@phenom.ffwll.local> (raw)
In-Reply-To: <YY/RBOdU6+SgbRrq@kroah.com>

On Sat, Nov 13, 2021 at 03:51:48PM +0100, Greg KH wrote:
> On Tue, Sep 21, 2021 at 04:20:23PM -0700, Gurchetan Singh wrote:
> > Similar to DRM_VMW_EVENT_FENCE_SIGNALED.  Sends a pollable event
> > to the DRM file descriptor when a fence on a specific ring is
> > signaled.
> > 
> > One difference is the event is not exposed via the UAPI -- this is
> > because host responses are on a shared memory buffer of type
> > BLOB_MEM_GUEST [this is the common way to receive responses with
> > virtgpu].  As such, there is no context specific read(..)
> > implementation either -- just a poll(..) implementation.
> > 
> > Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
> > Acked-by: Nicholas Verne <nverne@chromium.org>
> > ---
> >  drivers/gpu/drm/virtio/virtgpu_drv.c   | 43 +++++++++++++++++++++++++-
> >  drivers/gpu/drm/virtio/virtgpu_drv.h   |  7 +++++
> >  drivers/gpu/drm/virtio/virtgpu_fence.c | 10 ++++++
> >  drivers/gpu/drm/virtio/virtgpu_ioctl.c | 34 ++++++++++++++++++++
> >  4 files changed, 93 insertions(+), 1 deletion(-)
> 
> This commit seems to cause a crash in a virtual drm gpu driver for
> Android.  I have reverted this, and the next commit in the series from
> Linus's tree and all is good again.
> 
> Any ideas?

Well no, but also this patch looks very questionable of hand-rolling
drm_poll. Yes you can do driver private events like
DRM_VMW_EVENT_FENCE_SIGNALED, that's fine. But you really should not need
to hand-roll the poll callback. vmwgfx (which generally is a very old
driver which has lots of custom stuff, so not a great example) doesn't do
that either.

So that part should go no matter what I think.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2021-11-15 14:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21 23:20 [PATCH v3 00/12] Context types, v3 Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 01/12] virtio-gpu api: multiple context types with explicit initialization Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 02/12] drm/virtgpu api: create context init feature Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 03/12] drm/virtio: implement context init: track valid capabilities in a mask Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 04/12] drm/virtio: implement context init: probe for feature Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 05/12] drm/virtio: implement context init: support init ioctl Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 06/12] drm/virtio: implement context init: track {ring_idx, emit_fence_info} in virtio_gpu_fence Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 07/12] drm/virtio: implement context init: plumb {base_fence_ctx, ring_idx} to virtio_gpu_fence_alloc Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 08/12] drm/virtio: implement context init: stop using drv->context when creating fence Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 09/12] drm/virtio: implement context init: allocate an array of fence contexts Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 10/12] drm/virtio: implement context init: handle VIRTGPU_CONTEXT_PARAM_POLL_RINGS_MASK Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 11/12] drm/virtio: implement context init: add virtio_gpu_fence_event Gurchetan Singh
2021-11-13 14:51   ` Greg KH
2021-11-15 14:16     ` Daniel Vetter [this message]
2021-11-15 19:26       ` Kasireddy, Vivek
2021-11-16 15:43         ` Daniel Vetter
2021-11-17  2:31           ` Gurchetan Singh
2021-11-18  8:53             ` Daniel Vetter
2021-11-19 17:43               ` Rob Clark
2021-11-20  1:38                 ` Gurchetan Singh
2021-09-21 23:20 ` [PATCH v3 12/12] drm/virtio: implement context init: advertise feature to userspace Gurchetan Singh
2021-09-29  7:33 ` [PATCH v3 00/12] Context types, v3 Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZJrutLaiwozLfSw@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gurchetansingh@chromium.org \
    --cc=kraxel@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).