From: Johannes Stezenbach <js@sig21.net>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] Revert "drm/fb-helper: improve DRM fbdev emulation device names"
Date: Sat, 4 Dec 2021 13:41:13 +0100 [thread overview]
Message-ID: <Yath6T5ET17GbkI7@sig21.net> (raw)
In-Reply-To: <20211020165740.3011927-1-javierm@redhat.com>
Hi,
On Wed, Oct 20, 2021 at 06:57:40PM +0200, Javier Martinez Canillas wrote:
> This reverts commit b3484d2b03e4c940a9598aa841a52d69729c582a.
>
> That change attempted to improve the DRM drivers fbdev emulation device
> names to avoid having confusing names like "simpledrmdrmfb" in /proc/fb.
>
> But unfortunately, there are user-space programs such as pm-utils that
> match against the fbdev names and so broke after the mentioned commit.
>
> Since the names in /proc/fb are used by tools that consider it an uAPI,
> let's restore the old names even when this lead to silly names like the
> one mentioned above.
I would like to ask about the fate of this patch. It doesn't
seem to have been picked up by anyone, does it?
Thanks,
Johannes
> Fixes: b3484d2b03e4 ("drm/fb-helper: improve DRM fbdev emulation device names")
> Reported-by: Johannes Stezenbach <js@sig21.net>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>
> Changes in v2:
> - Add a comment explaining that the current /proc/fb names are an uAPI.
> - Add a Fixes: tag so it can be cherry-picked by stable kernels.
> - Add Ville Syrjälä's Reviewed-by tag.
>
> drivers/gpu/drm/drm_fb_helper.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 8e7a124d6c5a..22bf690910b2 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -1743,7 +1743,13 @@ void drm_fb_helper_fill_info(struct fb_info *info,
> sizes->fb_width, sizes->fb_height);
>
> info->par = fb_helper;
> - snprintf(info->fix.id, sizeof(info->fix.id), "%s",
> + /*
> + * The DRM drivers fbdev emulation device name can be confusing if the
> + * driver name also has a "drm" suffix on it. Leading to names such as
> + * "simpledrmdrmfb" in /proc/fb. Unfortunately, it's an uAPI and can't
> + * be changed due user-space tools (e.g: pm-utils) matching against it.
> + */
> + snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb",
> fb_helper->dev->driver->name);
>
> }
> --
> 2.31.1
>
>
next prev parent reply other threads:[~2021-12-06 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 16:57 [PATCH v2] Revert "drm/fb-helper: improve DRM fbdev emulation device names" Javier Martinez Canillas
2021-12-04 12:41 ` Johannes Stezenbach [this message]
2021-12-09 12:27 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yath6T5ET17GbkI7@sig21.net \
--to=js@sig21.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).