From: Andi Shyti <andi.shyti@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
"Andi Shyti" <andi@etezian.org>,
"Intel GFX" <intel-gfx@lists.freedesktop.org>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"DRI Devel" <dri-devel@lists.freedesktop.org>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Andi Shyti" <andi.shyti@linux.intel.com>
Subject: Re: [PATCH v6 08/11] drm/i915/pxp: Use to_gt() helper
Date: Fri, 10 Dec 2021 02:21:53 +0200 [thread overview]
Message-ID: <YbKdoQWaVYzRUobN@intel.intel> (raw)
In-Reply-To: <20211209235904.GV2219399@mdroper-desk1.amr.corp.intel.com>
Hi Matt,
> > -static inline struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev)
> > +static struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev)
>
> Was dropping the inline here intentional? It doesn't seem like there's
> any reason to drop it, and if it was intentional the whitespace isn't
> quite right.
No, it wasn't intentional and it's strange that checkpatch
didn't catch it. I will resend this one.
Thanks!
Andi
next prev parent reply other threads:[~2021-12-10 0:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 13:25 [PATCH v6 00/11] More preparation for multi gt patches Andi Shyti
2021-12-09 13:25 ` [PATCH v6 01/11] drm/i915: Store backpointer to GT in uncore Andi Shyti
2021-12-09 17:06 ` [Intel-gfx] " Jani Nikula
2021-12-09 17:26 ` Andi Shyti
2021-12-09 13:25 ` [PATCH v6 02/11] drm/i915: Introduce to_gt() helper Andi Shyti
2021-12-09 23:00 ` Matt Roper
2021-12-09 13:25 ` [PATCH v6 03/11] drm/i915/display: Use " Andi Shyti
2021-12-09 23:03 ` Matt Roper
2021-12-09 13:25 ` [PATCH v6 04/11] drm/i915/gt: " Andi Shyti
2021-12-09 23:33 ` Matt Roper
2021-12-09 13:25 ` [PATCH v6 05/11] drm/i915/gem: " Andi Shyti
2021-12-09 23:50 ` Matt Roper
2021-12-09 13:25 ` [PATCH v6 06/11] drm/i915/gvt: " Andi Shyti
2021-12-09 23:51 ` Matt Roper
2021-12-09 13:25 ` [PATCH v6 07/11] drm/i915/selftests: " Andi Shyti
2021-12-09 23:55 ` Matt Roper
2021-12-09 13:25 ` [PATCH v6 08/11] drm/i915/pxp: " Andi Shyti
2021-12-09 23:59 ` Matt Roper
2021-12-10 0:21 ` Andi Shyti [this message]
2021-12-10 0:22 ` Matt Roper
2021-12-10 1:07 ` [PATCH v7 " Andi Shyti
2021-12-10 15:27 ` Matt Roper
2021-12-09 13:25 ` [PATCH v6 09/11] drm/i915: " Andi Shyti
2021-12-10 0:02 ` Matt Roper
2021-12-09 13:25 ` [PATCH v6 10/11] drm/i915: Use to_gt() helper for GGTT accesses Andi Shyti
2021-12-10 0:18 ` Matt Roper
2021-12-10 2:11 ` Andi Shyti
2021-12-09 13:25 ` [PATCH v6 11/11] drm/i915: Rename i915->gt to i915->gt0 Andi Shyti
2021-12-10 0:19 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbKdoQWaVYzRUobN@intel.intel \
--to=andi.shyti@linux.intel.com \
--cc=andi@etezian.org \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.winiarski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).