From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CFA4C433F5 for ; Tue, 21 Dec 2021 14:31:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F232113601; Tue, 21 Dec 2021 14:31:28 +0000 (UTC) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id F27501135E4 for ; Tue, 21 Dec 2021 14:31:26 +0000 (UTC) Received: by mail-qk1-f177.google.com with SMTP id m186so12687420qkb.4 for ; Tue, 21 Dec 2021 06:31:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZCiw0bZKYIpEoDjhVNnDiHVYSk1x/IQUJgn5e6PHxuI=; b=Viups05K03YLW0GpWwl3/r0G/+4DOnubBRE40PgaPXXtCNNcTQQjyCj9aWViloDmaq 6CixflmBT8e4i144MtphTHG2Z6Tq9nxuRz9SzbrXseeoCNCh/14Ba+LkIJJ6pJE3pUGE zNWiU1l1iijlUXGSc/EH+V9MAXuWVajNT/dKEeRknNr3NCRJj2DepwBU8W+9/H/bjk7y DvaIEIN+l8h4v4vDQhKYYVS05YAN2eP5koqIWoknJmhigiDI1eWKTK727yuKYugV74Vq QL0+hefmXULP2hGjmjIxa6MKwKRjizk1WV6eAmxt4Myv2W+sKuFVz63w6XWa3NzA0sPV F1yA== X-Gm-Message-State: AOAM531p34doHS1eP6EX+CEKuzNeJZ8DBtO0ANyVZdlxInAh4gQH/4N0 1vlNbRC9i8uM6UFlqrRB0g== X-Google-Smtp-Source: ABdhPJwbiZg2cLWCqLWG6kO5T5YieBNWdxELfhYlFtD+O7MYmC3zikpr/lWeCSO3xNhRskwxyCeFrQ== X-Received: by 2002:a05:620a:470e:: with SMTP id bs14mr2147958qkb.210.1640097086038; Tue, 21 Dec 2021 06:31:26 -0800 (PST) Received: from robh.at.kernel.org ([24.55.105.145]) by smtp.gmail.com with ESMTPSA id f8sm17586444qtk.1.2021.12.21.06.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 06:31:25 -0800 (PST) Received: (nullmailer pid 1358250 invoked by uid 1000); Tue, 21 Dec 2021 14:31:23 -0000 Date: Tue, 21 Dec 2021 10:31:23 -0400 From: Rob Herring To: Sascha Hauer Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Message-ID: References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. The problem with this series is it breaks an old kernel with new dt. You can partially mitigate that with stable kernel backport, but IMO keeping the old name is not a burden to maintain. And given RK3399 is widely used including by me, we should not be breaking compatibility. So allow for ref in addition to vpll if you like, but only use 'ref' for new users. And add a comment in the schema to that effect. Rob > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 6e09dd2ee05ac..3b40219e3ea60 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -47,11 +47,12 @@ properties: > - enum: > - cec > - grf > - - vpll > + - ref > - enum: > - grf > - - vpll > - - const: vpll > + - ref > + - const: > + - ref > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle > -- > 2.30.2 > >