From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC7A4C433F5 for ; Thu, 6 Jan 2022 17:55:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D44410EACD; Thu, 6 Jan 2022 17:55:27 +0000 (UTC) Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59E6710EA7C for ; Thu, 6 Jan 2022 17:55:25 +0000 (UTC) Received: by mail-oi1-x232.google.com with SMTP id t204so4775207oie.7 for ; Thu, 06 Jan 2022 09:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o/foTQodVBgucFBn3ZXK6eaXM/2HEpmwpEOS38R0Rek=; b=hSPPXlxyyC2hbirInmbjImCpaolGvJHLT9KFRGDIBcFrz3Y80wKjpkaTPBHchK9EIk PSckyZlYigING79StXqVL/Ouu92/C21UyDwwG+ll4MJIWxZU1NYAqESwjMJEusctC7ou ZEURei8f7xz/4Eo3e9J99cANW/ooDYTMt+p3WmHpHTw5pcXX8CQIt28e5cS/sXxjvnrz 5fcXJAK5q7Z+40rj/jPt3LZtvrtjDmGCyypPlAZcrg+mxzoQgHNqcZ+AyO9Q62148Yuq 2gjBZIldTpKVLD1bLmPpazjsJdQcFZjRO7Ns955K+ipsxALI9xpXpNPmXwkBCjFmjX5x uU7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o/foTQodVBgucFBn3ZXK6eaXM/2HEpmwpEOS38R0Rek=; b=dTkZD+Cyw6Bar1dYrN3nHem/7prtOG8Yb77QRcyHxfTPWkHk8NYeidGEIHEvg5RlE1 R9aEQ9sA6dfIIP4q4RrNm6efoCLl+dGczrjBVFfBc/dDPxA4hfzAsBYECmP3W0UnOsYx /W3SyBgQ0V0mVN4Q36JFolMJSDepmaArumMDDwy7fzPeBZPT6XnP3bkvT2dY7hehnx2p wAZ4ooy1G2TmLVBVkIsoBGr6lZJXaUV1EtLbaK/Ac66TIhPptXRFp9OD9QvNTkvlIA8z rjo0eLv1kKPhifUcPedmqO1nMEIfFuzzi4S8lrCyG0Z4p2q9BM4b7ehnoV6mwhl9Yw71 yneQ== X-Gm-Message-State: AOAM532Le8dugKLlqxNKf05RCF+R1hoBA5o4rU+Ev+WBhnZX71AOL8Fx gTNHzGC/fpWhEAXfsdxJjpS8zgF7Y7gopg== X-Google-Smtp-Source: ABdhPJwfDQwmg+hs7VU/d33Ah9U7qOEmt0rKxDrLc243J4pADglOmvW5+20L18kjkmYeFF1HelWKSA== X-Received: by 2002:a54:4014:: with SMTP id x20mr7154337oie.129.1641491724590; Thu, 06 Jan 2022 09:55:24 -0800 (PST) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z24sm463628otk.20.2022.01.06.09.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 09:55:24 -0800 (PST) Date: Thu, 6 Jan 2022 09:56:11 -0800 From: Bjorn Andersson To: Kuogee Hsieh Subject: Re: [PATCH v3] drm/msm/dp: populate connector of struct dp_panel Message-ID: References: <1641489335-20975-1-git-send-email-quic_khsieh@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1641489335-20975-1-git-send-email-quic_khsieh@quicinc.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_sbillaka@quicinc.com, quic_abhinavk@quicinc.com, airlied@linux.ie, freedreno@lists.freedesktop.org, vkoul@kernel.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, dmitry.baryshkov@linaro.org, aravindh@codeaurora.org, sean@poorly.run, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu 06 Jan 09:15 PST 2022, Kuogee Hsieh wrote: > We never assign struct dp_panel::connector, instead the connector is > stored in struct msm_dp::connector. When we run compliance testing test > case 4.2.2.6 dp_panel_handle_sink_request() won't have a valid edid set I unfortunately have no idea what test 4.2.2.6 is or how it ends up in dp_panel_handle_sink_request() with panel->connector being NULL. Your new commit message is much better, but I still would like to have something describing why this particular test case triggers this bug, how does it differ from normal execution, is it a race, does the test involve failing edid reads??? > in struct dp_panel::edid so we'll try to use the connectors > real_edid_checksum and hit a NULL pointer dereference error because the > connector pointer is never assigned. > > Changes in V2: > -- populate panel connector at msm_dp_modeset_init() instead of at dp_panel_read_sink_caps() > > Changes in V3: > -- remove unhelpful kernel crash trace commit text > -- remove renaming dp_display parameter to dp > > Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read") > Signee-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_display.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 3449d3f..40a059d 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1499,6 +1499,7 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev, > struct drm_encoder *encoder) > { > struct msm_drm_private *priv; > + struct dp_display_private *dp_priv; > int ret; > > if (WARN_ON(!encoder) || WARN_ON(!dp_display) || WARN_ON(!dev)) > @@ -1507,6 +1508,8 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev, > priv = dev->dev_private; > dp_display->drm_dev = dev; > > + dp_priv = container_of(dp_display, struct dp_display_private, dp_display); > + > ret = dp_display_request_irq(dp_display); > if (ret) { > DRM_ERROR("request_irq failed, ret=%d\n", ret); > @@ -1524,6 +1527,8 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev, > return ret; > } > > + dp_priv->panel->connector = dp_display->connector; The placement of this assignment in msm_dp_modeset_init() makes much more sense than what you had in v1, so I think this looks good. Thanks, Bjorn > + > priv->connectors[priv->num_connectors++] = dp_display->connector; > return 0; > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >