From: Matt Roper <matthew.d.roper@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/uncore: Warn only if unclaimed access remains flagged
Date: Fri, 8 Apr 2022 09:51:29 -0700 [thread overview]
Message-ID: <YlBoEQsevdFahwYJ@mdroper-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <20220408164837.3845786-1-lucas.demarchi@intel.com>
On Fri, Apr 08, 2022 at 09:48:37AM -0700, Lucas De Marchi wrote:
> Commit 4b276ed3c7ac ("drm/i915/uncore: Warn on previous unclaimed
> accesses") tried to improve our report of unclaimed register access,
> however it unveiled cases that were not previously causing any harm.
>
> Downgrade the first message to debug so we can still see them and
> eventually fix, but don't warn.
>
> Fixes: 4b276ed3c7ac ("drm/i915/uncore: Warn on previous unclaimed accesses")
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>
> Tested on top of intel/CI_DRM_11471 as drm-tip is currently broken by
> other things.
>
> drivers/gpu/drm/i915/intel_uncore.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index df59ec88459e..83517a703eb6 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -1518,13 +1518,11 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore,
> const i915_reg_t reg,
> const bool read)
> {
> - if (drm_WARN(&uncore->i915->drm,
> - check_for_unclaimed_mmio(uncore),
> - "Unclaimed access detected before %s register 0x%x\n",
> - read ? "read from" : "write to",
> - i915_mmio_reg_offset(reg)))
> - /* Only report the first N failures */
> - uncore->i915->params.mmio_debug--;
> + if (check_for_unclaimed_mmio(uncore))
> + drm_dbg(&uncore->i915->drm,
> + "Unclaimed access detected before %s register 0x%x\n",
> + read ? "read from" : "write to",
> + i915_mmio_reg_offset(reg));
> }
>
> static inline void
> --
> 2.35.1
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
prev parent reply other threads:[~2022-04-08 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 16:48 [PATCH] drm/i915/uncore: Warn only if unclaimed access remains flagged Lucas De Marchi
2022-04-08 16:51 ` Matt Roper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlBoEQsevdFahwYJ@mdroper-desk1.amr.corp.intel.com \
--to=matthew.d.roper@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).