From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05FEAC433EF for ; Mon, 11 Apr 2022 22:27:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C7AD10E090; Mon, 11 Apr 2022 22:27:58 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BC0B10E090; Mon, 11 Apr 2022 22:27:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC88761776; Mon, 11 Apr 2022 22:27:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E97D8C385A3; Mon, 11 Apr 2022 22:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649716074; bh=6KzJ2U0BFdGw2Dd8rbf6y6V7A15Lm+p/0Tn+UumRDOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K1j63g7tC590U21DUMNKsqyemPNIWT5VJStqo81Au9EANSGT1x8e/D6dg3f3YIF4y sdAmklvNYIdvtDt49nAP4g09t7MSmq2d13Hw3qUzXrSdxpNEVbwgLk1cf41huMgutF FztrMpiy6b7Pb8REOkIOuFmDgjiKjPaKD/PzAhhEs5iicxB0MzxjBoG5Z+4bEn54/D xHqtspxYuySq+RsBQGt80Uj2LOq+BWxtGb0zwumjr75AskF8IIjXiQBx6nFQ2cxPR+ PnIq10asbaoKbshZcqKpZk+T4WsiytfXKdL5xQHiS7bT9KRdxjhurlCbkr3IsuzJdd ae9r6UZHnkyWg== Date: Mon, 11 Apr 2022 15:27:47 -0700 From: Nathan Chancellor To: Daniel Vetter Subject: Re: [PATCH v3 14/17] fbcon: Move console_lock for register/unlink/unregister Message-ID: References: <20220405210335.3434130-1-daniel.vetter@ffwll.ch> <20220405210335.3434130-15-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220405210335.3434130-15-daniel.vetter@ffwll.ch> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiyu Yang , Du Cheng , Tetsuo Handa , Greg Kroah-Hartman , Intel Graphics Development , Zheyu Ma , DRI Development , Claudio Suarez , Matthew Wilcox , Thomas Zimmermann , Zhen Lei , Alex Deucher , Daniel Vetter , Sam Ravnborg , Guenter Roeck Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel, On Tue, Apr 05, 2022 at 11:03:32PM +0200, Daniel Vetter wrote: > Ideally console_lock becomes an implementation detail of fbcon.c and > doesn't show up anywhere in fbmem.c. We're still pretty far from that, > but at least the register/unregister code is there now. > > With this the do_fb_ioctl() handler is the only code in fbmem.c still > calling console_lock(). > > Acked-by: Sam Ravnborg > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Du Cheng > Cc: Claudio Suarez > Cc: Greg Kroah-Hartman > Cc: Tetsuo Handa > Cc: Matthew Wilcox > Cc: Sam Ravnborg > Cc: Zheyu Ma > Cc: Guenter Roeck > Cc: Alex Deucher > Cc: Zhen Lei > Cc: Xiyu Yang This patch as commit 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister") in next-20220411 causes a lock up on my test Intel desktop; I get no output on my display and I cannot ssh into the machine. Bisect log below. If back out of this patch and the ones that follow in this series on top of next-20220411, everything works properly (i.e. 'git diff 6e7da3af008b^..efc3acbc105a | git apply -R'). What information would be helpful for debugging this? The system has an i7-11700 in it and it is booting under UEFI, so I assume it should be using EFI_FB. I am happy to offer any debugging information or test any patches. # bad: [d12d7e1cfe38e0c36d28c7a9fbbc436ad0d17c14] Add linux-next specific files for 20220411 # good: [8b57b3046107b50ebecb65537a172ef3d6cec673] Merge tag 'tty-5.18-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty git bisect start 'd12d7e1cfe38e0c36d28c7a9fbbc436ad0d17c14' '8b57b3046107b50ebecb65537a172ef3d6cec673' # bad: [8f0b3ef070bd35e80da1caa85824fc344fb6b82e] Merge branch 'for-linux-next' of git://anongit.freedesktop.org/drm/drm-misc git bisect bad 8f0b3ef070bd35e80da1caa85824fc344fb6b82e # good: [69ae2d6587df089ec1c21bddddc7852df403d3ce] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git git bisect good 69ae2d6587df089ec1c21bddddc7852df403d3ce # good: [43ffc7321ed6ce13e5424fa687576f4442c25f9d] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git git bisect good 43ffc7321ed6ce13e5424fa687576f4442c25f9d # good: [d44c2642c40b6c11e4a0afc76d491287c074376c] drm/gem: Delete gem array fencing helpers git bisect good d44c2642c40b6c11e4a0afc76d491287c074376c # good: [3223e922ccf8b5c3dd0b05faeaba407655ee0774] orinoco: Prepare cleanup of powerpc's asm/prom.h git bisect good 3223e922ccf8b5c3dd0b05faeaba407655ee0774 # good: [689333136327b6cd618df85d83d79f2aa620d585] fbcon: Move fbcon_bmove(_rec) functions git bisect good 689333136327b6cd618df85d83d79f2aa620d585 # good: [840db0076b05a1dd4c2ded8d08f8481e0297d09f] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git git bisect good 840db0076b05a1dd4c2ded8d08f8481e0297d09f # bad: [6e7da3af008b72520f5318507f455f344b27f022] fbcon: Move console_lock for register/unlink/unregister git bisect bad 6e7da3af008b72520f5318507f455f344b27f022 # good: [6b2060cf9138a2cd5f3468a949d3869abed049ef] fb: Delete fb_info->queue git bisect good 6b2060cf9138a2cd5f3468a949d3869abed049ef # good: [d443d93864726ad68c0a741d1e7b03934a9af143] fbcon: move more common code into fb_open() git bisect good d443d93864726ad68c0a741d1e7b03934a9af143 # good: [43553559121ca90965b572cf8a1d6d0fd618b449] fbcon: Consistently protect deferred_takeover with console_lock() git bisect good 43553559121ca90965b572cf8a1d6d0fd618b449 # first bad commit: [6e7da3af008b72520f5318507f455f344b27f022] fbcon: Move console_lock for register/unlink/unregister Cheers, Nathan