dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Rob Clark <robdclark@gmail.com>
Cc: "Sean Paul" <sean@poorly.run>,
	"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	"Michel Dänzer" <michel.daenzer@mailbox.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	freedreno <freedreno@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Freedreno] Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory
Date: Wed, 11 May 2022 22:24:37 -0400	[thread overview]
Message-ID: <Ynxv5WGMd0aJYM5a@mit.edu> (raw)
In-Reply-To: <CAF6AEGsmD-CNGj4bAE952JQpquaWA+Nxo5TGpFiHqaPK9doP-g@mail.gmail.com>

On Wed, May 11, 2022 at 06:33:32AM -0700, Rob Clark wrote:
> 
> And ofc we want the expectations to be in the kernel tree because
> there could be, for example, differences between -fixes and -next
> branches.  (Or even stable kernel branches if/when we get to the point
> of running CI on those.)

There are tradeoffs both ways, whether the patches are kept separate,
opr in the kernel tree.

In the file system world, when we discover a bug, very often a test
case is found to test the fix, and to protect us against regressions.
It has one other benefit; since the tests (xfstests) are kept separate
from the kernel, it's a useful way to identify when some patch didn't
get automatically backported to a LTS or distro kernel.  (For example,
because the patch didn't cherry-pick cleanly and the manual backport
process fell through the cracks.)

It does make things annoying when we have bugs that can not be safely
backported (which results in tests that fail on the LTS kernel without
kernel-version exclude files), and/or when the expectations change
between versions.  (Although to be honest, for us, the more common
annoyance is when some userspace package --- e.g., bash or coreutils
or util-linux --- changes their output, and we have to add filter
functions to accomodate expected output differences.)

						- Ted

  parent reply	other threads:[~2022-05-12  2:24 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  7:01 [RFC] drm/msm: Add initial ci/ subdirectory Tomeu Vizoso
2022-05-10 14:13 ` [RFC v2] " Tomeu Vizoso
2022-05-10 19:39   ` [Freedreno] " Jessica Zhang
2022-05-10 20:25     ` Rob Clark
2022-05-11 17:12       ` Daniel Vetter
2022-05-11 17:46         ` Rob Clark
2022-05-11 19:14           ` Daniel Vetter
2022-05-11 20:32             ` Rob Clark
2022-05-11 21:09               ` Daniel Vetter
2022-05-12 13:28           ` Tomeu Vizoso
2022-05-12 14:02             ` Daniel Vetter
2022-05-11  4:25     ` Tomeu Vizoso
2022-05-11  5:06   ` Adding CI results to the kernel tree was " Dave Airlie
2022-05-11  6:22     ` Greg Kroah-Hartman
2022-05-11 10:26       ` Michel Dänzer
2022-05-11 11:50         ` Greg Kroah-Hartman
2022-05-11 13:33           ` [Freedreno] " Rob Clark
2022-05-11 16:43             ` Daniel Vetter
2022-05-11 17:23               ` Rob Clark
2022-05-12  2:24             ` Theodore Ts'o [this message]
2022-05-11 17:33     ` Linus Torvalds
2022-05-11 18:39       ` Rob Clark
2022-05-11 19:08         ` Linus Torvalds
2022-05-11 19:12           ` Linus Torvalds
2022-05-11 20:14             ` [Freedreno] " Rob Clark
2022-05-11 20:06           ` Rob Clark
2022-05-11 19:39       ` Daniel Vetter
2022-05-11  6:15   ` [RFC v3] " Tomeu Vizoso
2022-05-11 13:20     ` Rob Clark
2022-05-11 14:03       ` Tomeu Vizoso
2022-05-17  8:16     ` [RFC v4] drm: " Tomeu Vizoso
2022-05-17  9:18       ` Neil Armstrong
2022-05-17  9:24         ` Tomeu Vizoso
2022-07-26 18:16       ` [PATCH v5] " Tomeu Vizoso
2022-07-29 15:43         ` Rob Clark
2022-08-10 18:24         ` Rodrigo Siqueira Jordao
2022-08-10 22:08           ` Rob Clark
2022-08-11 10:10           ` Tomeu Vizoso
2022-08-16 15:37         ` [PATCH v6] " Tomeu Vizoso
2022-08-29  9:31           ` [PATCH v7] " Tomeu Vizoso
2022-09-09 14:15             ` [PATCH v8] " Tomeu Vizoso
2022-09-09 17:16               ` Daniel Stone
2022-10-25  7:32                 ` Daniel Vetter
2022-10-25 15:06                   ` Daniel Stone
2022-09-12  7:29               ` [PATCH v9] " Tomeu Vizoso
2022-10-14 17:10                 ` Rob Clark
2022-10-24 22:06                 ` Jessica Zhang
2022-05-11 14:26 ` [RFC] drm/msm: " Jani Nikula
2022-05-11 14:41   ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ynxv5WGMd0aJYM5a@mit.edu \
    --to=tytso@mit.edu \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel.daenzer@mailbox.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=tomeu.vizoso@collabora.com \
    --cc=torvalds@linux-foundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).