From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3853FC433EF for ; Thu, 19 May 2022 16:55:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E54B11A59D; Thu, 19 May 2022 16:55:24 +0000 (UTC) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by gabe.freedesktop.org (Postfix) with ESMTPS id A64A211A59D for ; Thu, 19 May 2022 16:55:22 +0000 (UTC) Received: by mail-pg1-x532.google.com with SMTP id g184so5608176pgc.1 for ; Thu, 19 May 2022 09:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fbRv1nP7pTqnBz+sNfZ4tvpe8QTnEEoJ7rGEyN4925Q=; b=NlEMnrL1wW3fdyUxfE79H9YKA08o4qU+R83BNF4EgYN1cw3zLCwLQRh0UUNy8jsgaW lh5GqvoVBqk+o21K5cK+qXjAuNRBqngjQJpCjNtE0H22z4d7gNLw9px10kbPevPTCOZo cm+d0+5Tl4z0B20qtEo97MXoLONED9j4gMp06GLYi8IioDmsnUosJWwH3R2UXeI50B+Y Dfz9rAnYpYkgl9qP8KnBJnRgCxNPwNbXvT5v7eDKy4noIKvXGL5S6mBSB33tJTkWiaIL eywS3+VPl8lSdoz2EXE2fdPxXfmOKy58HyUzW2znCkVQe921F9Kzhs0rUpz/ac4b69yM G7aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fbRv1nP7pTqnBz+sNfZ4tvpe8QTnEEoJ7rGEyN4925Q=; b=ryKNqHmtCbKJywuCikzYQea4RCiar8FLAvWX1aJXll5YXhf7SzdOYSK3d3O7Kd8SgY MICvxKS9CGMTl5fASTHRm8Fbl89xXmUEWnVacN+ZbrDpxmQHDzshaXA3837hzTcFX3Iz 5VNXVU5iCQ4iBnoQF88TC0fZbVcIz6zwgzqKKkGn7s29+lKRm38gGVyxptT1UO5kLr3V cRg93+YKhVeHnKbEYlD7HsSPbIRzwk/JEbKcfA2LG0MHX1VlhHBQ8raPsP9SZfbJpFC4 0Hznv2ITILLb8KS8b5Cxvc9m65ZSoYyapoPwrKoUGCeEcPGm+sh3p2Upa2FX3HQ/8E8c shnw== X-Gm-Message-State: AOAM532liAGKW8ekidr/TcJM/59xa9+0P8YN/J+NoOhZtml9Th9ouRNY eW3nFTthVGOpAfdUFRFoXdVPhw== X-Google-Smtp-Source: ABdhPJxhTLHIK7S/JfndVkiqYIReuohqOcVCUwV7I1Rl2NWw0SBdey4MuXGnvj/UoimJME0mze89Mg== X-Received: by 2002:a63:1347:0:b0:3f2:8963:ca0a with SMTP id 7-20020a631347000000b003f28963ca0amr4750270pgt.424.1652979321995; Thu, 19 May 2022 09:55:21 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id t9-20020aa79389000000b0051829b1595dsm4262274pfe.130.2022.05.19.09.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 09:55:21 -0700 (PDT) Date: Thu, 19 May 2022 16:55:18 +0000 From: Sean Christopherson To: Maxim Levitsky Subject: Re: [RFC PATCH v3 14/19] KVM: x86: rename .set_apic_access_page_addr to reload_apic_access_page Message-ID: References: <20220427200314.276673-1-mlevitsk@redhat.com> <20220427200314.276673-15-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427200314.276673-15-mlevitsk@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, David Airlie , Dave Hansen , dri-devel@lists.freedesktop.org, "H. Peter Anvin" , Brijesh Singh , Joerg Roedel , x86@kernel.org, Ingo Molnar , Zhi Wang , Tom Lendacky , intel-gfx@lists.freedesktop.org, Borislav Petkov , Rodrigo Vivi , Thomas Gleixner , intel-gvt-dev@lists.freedesktop.org, Jim Mattson , Tvrtko Ursulin , linux-kernel@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 27, 2022, Maxim Levitsky wrote: > This will be used on SVM to reload shadow page of the AVIC physid table > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index d2f73ce87a1e3..ad744ab99734c 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -9949,12 +9949,12 @@ void kvm_arch_mmu_notifier_invalidate_range(struct kvm *kvm, > kvm_make_all_cpus_request(kvm, KVM_REQ_APIC_PAGE_RELOAD); > } > > -static void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu) > +static void kvm_vcpu_reload_apic_pages(struct kvm_vcpu *vcpu) > { > if (!lapic_in_kernel(vcpu)) > return; > > - static_call_cond(kvm_x86_set_apic_access_page_addr)(vcpu); > + static_call_cond(kvm_x86_reload_apic_pages)(vcpu); > } > > void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu) > @@ -10071,7 +10071,7 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu) > if (kvm_check_request(KVM_REQ_LOAD_EOI_EXITMAP, vcpu)) > vcpu_load_eoi_exitmap(vcpu); > if (kvm_check_request(KVM_REQ_APIC_PAGE_RELOAD, vcpu)) > - kvm_vcpu_reload_apic_access_page(vcpu); > + kvm_vcpu_reload_apic_pages(vcpu); My vote is to add a new request and new kvm_x86_ops hook instead of piggybacking KVM_REQ_APIC_PAGE_RELOAD. The usage in kvm_arch_mmu_notifier_invalidate_range() very subtlies relies on the memslot and vma being allocated/controlled by KVM. The use in avic_physid_shadow_table_flush_memslot() is too similar in that it also deals with memslot changes, but at the same time is _very_ different in that it's dealing with user controlled memslots.