From: Vinod Koul <vkoul@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: quic_kalyant <quic_kalyant@quicinc.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
Rob Clark <robdclark@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-phy@lists.infradead.org, Stephen Boyd <swboyd@chromium.org>,
freedreno <freedreno@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy
Date: Thu, 16 Jun 2022 17:10:04 -0700 [thread overview]
Message-ID: <YqvGXNGIzVHp7QtV@matsya> (raw)
In-Reply-To: <CAD=FV=Wbi=CXhPpOUJj=1PdgB8i6Lf1Sfr=T7wrQsgBx790S_w@mail.gmail.com>
On 16-06-22, 08:35, Doug Anderson wrote:
> Hi,
>
> On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > We're supposed to list the supplies in the dt bindings but there are
> > none in the eDP PHY bindings.
> >
> > Looking at the driver in Linux, I can see that there seem to be two
> > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the
> > bindings.
> >
> > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not
> > immediately clear how to figure out how to fill in these supplies. The
> > only two eDP related supplies are simply described as "power for eDP
> > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and
> > from comparing how a similar PHY is hooked up on other similar
> > Qualcomm boards, I'll make the educated guess that the 1.2V supply
> > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use
> > that in the example here.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> >
> > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> Even though patch #1 in this series should be dropped, this patch
> (patch #2) is still valid. Vinod: I assume this would land in your
> tree along with the first two patches in Kuogee's series [1], which
> are related. Please let me know if you need me to re-send or anything.
I have applied this patch, thanks
> [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/
This needs rebase on phy split which I have picked
--
~Vinod
prev parent reply other threads:[~2022-06-17 0:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 21:06 [PATCH 0/2] dt-bindings: List supplies needed for sc7280 eDP Douglas Anderson
2022-04-25 21:06 ` [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings Douglas Anderson
2022-04-25 21:14 ` Stephen Boyd
2022-04-25 21:18 ` Doug Anderson
2022-05-05 18:02 ` Sankeerth Billakanti
2022-05-05 18:18 ` Stephen Boyd
2022-05-05 18:47 ` Sankeerth Billakanti (QUIC)
2022-05-05 19:06 ` Stephen Boyd
2022-05-06 13:36 ` Sankeerth Billakanti (QUIC)
2022-05-11 18:21 ` Doug Anderson
2022-04-25 21:06 ` [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy Douglas Anderson
2022-05-05 18:47 ` Sankeerth Billakanti (QUIC)
2022-06-16 15:35 ` Doug Anderson
2022-06-17 0:10 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqvGXNGIzVHp7QtV@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).