From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 957D4C433EF for ; Tue, 19 Jul 2022 06:10:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 959B410EA4C; Tue, 19 Jul 2022 06:10:24 +0000 (UTC) Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id A21BE10EA4C for ; Tue, 19 Jul 2022 06:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=jp83ii8nZk7L/6Omf0n4BRcep5/FTl5AylCpqXcA8og=; b=WnjNN/cAU+L0AjpbfV8SjfuiKoLjdeDZqGz+PxitCRZ1XVRYf08GY9tcYp6pcSMwWOz01FOUu2N6h b96epudXPxMrdn3oOuZvULn5w08GnIHia3PNr3J0iMnYnP+DGObCDAEZ+yUhMNw73DwXj8t5l2NbzX TNCOBIOBDjvDlzv2OaRWj7D/zReTsza3mksZ226C2QrIu7B80YE9RTBMO1G0YSzRnWu9EdbRG2qVej m5LWI96tW5sMTAzvA1QrVBwfqeqIntlgtCkw1KcgGLxl4JWNustLmc549k/6Y56Qru6Zvd+P+j8ucQ aGezmh3MifN9kjtJ4V+o9fGwSFDN//Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=jp83ii8nZk7L/6Omf0n4BRcep5/FTl5AylCpqXcA8og=; b=bbfXWbrl67vsOQUfGcA821e626nY1xPLige86Rb5YRxklcAmCxPAEeNf+NykN7CJ+C2b6Hl2uiMa6 HtfSmzkDQ== X-HalOne-Cookie: b83d0abb0da0665d4cfe7193d5f7c0eba89b2d78 X-HalOne-ID: 77b15885-0729-11ed-be7f-d0431ea8bb03 Received: from mailproxy2.cst.dirpod3-cph3.one.com (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 77b15885-0729-11ed-be7f-d0431ea8bb03; Tue, 19 Jul 2022 06:10:20 +0000 (UTC) Date: Tue, 19 Jul 2022 08:10:18 +0200 From: Sam Ravnborg To: Caleb Connolly Subject: Re: [PATCH 3/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel Message-ID: References: <20220718213051.1475108-1-caleb@connolly.tech> <20220718213051.1475108-4-caleb@connolly.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718213051.1475108-4-caleb@connolly.tech> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, Konrad Dybcio , Andy Gross , Rob Herring , Bjorn Andersson , Vinod Koul , Thierry Reding , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , phone-devel@vger.kernel.org, Sumit Semwal , linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Caleb, On Mon, Jul 18, 2022 at 10:30:50PM +0100, Caleb Connolly wrote: > From: Sumit Semwal > > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel. A few things to improve to this binding. Sam > > Signed-off-by: Vinod Koul > Signed-off-by: Sumit Semwal > [caleb: convert to yaml] > Signed-off-by: Caleb Connolly > --- > .../bindings/display/panel/lg,43408.yaml | 41 +++++++++++++++++++ > .../display/panel/panel-simple-dsi.yaml | 2 + > 2 files changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/lg,43408.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/lg,43408.yaml b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml > new file mode 100644 > index 000000000000..0529a3aa2692 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LG SW43408 1080x2160 DSI panel > + > +maintainers: > + - Caleb Connolly > + > +description: | > + This panel is used on the Pixel 3, it is a 60hz OLED panel which > + required DSC (Display Stream Compression) and has rounded corners. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - const: lg,sw43408 > + > + vddi-supply: true > + vpnl-supply: true > + reset-gpios: true > + > + backlight: false > + power-supply: false No need to say anything is false, this is covered by the statement below. Also, the driver uses backlight, so it should be true? > + > +additionalProperties: false > + > +required: > + - compatible > + - data-mapping > + - width-mm > + - height-mm > + - panel-timing > + - port > + > +... > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml > index 2c00813f5d20..4498078cb1ee 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml > @@ -45,6 +45,8 @@ properties: > - lg,acx467akm-7 > # LG Corporation 7" WXGA TFT LCD panel > - lg,ld070wx3-sl01 > + # LG Corporation sw43408 1080x2160 OLED > + - lg,sw43408 The panel uses three power-supplies, so it is not a "panel-simple" binding. And we cannot have the same compatible twice, so this must be dropped. Sam