From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Chris Paterson <Chris.Paterson2@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
David Airlie <airlied@linux.ie>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Biju Das <biju.das@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
Date: Sat, 27 Aug 2022 21:37:39 +0300 [thread overview]
Message-ID: <Ywpkc5ut97L3kTb1@pendragon.ideasonboard.com> (raw)
In-Reply-To: <OS0PR01MB592284D23CEF5354170765A886749@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Hi Biju,
On Sat, Aug 27, 2022 at 09:04:25AM +0000, Biju Das wrote:
> Subject: Re: [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format
> > On Thu, Aug 25, 2022 at 11:39:05AM +0100, Biju Das wrote:
> > > Replace use of struct rcar_du_format_info with %p4cc for printing 4CC
> > > formats.
> >
> > The code change looks good, but doesn't match the commit message. You're
> > not replacing usage of struct rcar_du_format_info. I propose the
> > following commit message:
> >
> > Use the %p4cc format specifier to print 4CCs, which will provide a more
> > readable message than the raw hex value.
>
> OK.
>
> > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > index 21881fb5e84a..8c2719efda2a 100644
> > > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > > @@ -405,8 +405,8 @@ rcar_du_fb_create(struct drm_device *dev, struct
> > > drm_file *file_priv,
> > >
> > > format = rcar_du_format_info(mode_cmd->pixel_format);
> > > if (format == NULL) {
> > > - dev_dbg(dev->dev, "unsupported pixel format %08x\n",
> > > - mode_cmd->pixel_format);
> > > + dev_dbg(dev->dev, "unsupported pixel format %p4cc\n",
> > > + &mode_cmd->pixel_format);
> > > return ERR_PTR(-EINVAL);
> > > }
> > >
> >
> > There are two other occurrences:
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > index 26b25ca58968..83631ee2fff1 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c
> > @@ -626,8 +626,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane
> > *plane,
> >
> > *format = rcar_du_format_info(state->fb->format->format);
> > if (*format == NULL) {
> > - dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > - state->fb->format->format);
> > + dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > __func__,
> > + &state->fb->format->format);
> > return -EINVAL;
> > }
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > index 25f50a297c11..8cd37d7b8ae2 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c
> > @@ -166,8 +166,8 @@ static int rcar_du_wb_enc_atomic_check(struct
> > drm_encoder *encoder,
> >
> > wb_state->format = rcar_du_format_info(fb->format->format);
> > if (wb_state->format == NULL) {
> > - dev_dbg(dev->dev, "%s: unsupported format %08x\n", __func__,
> > - fb->format->format);
> > + dev_dbg(dev->dev, "%s: unsupported format %p4cc\n",
> > __func__,
> > + &fb->format->format);
> > return -EINVAL;
> > }
> >
> > I can add these changes to the patch and update the commit message when
> > applying if you're fine with that. In that case,
>
> I am ok with it.
>
> Is it possible for you to share the git tree with latest RCar DU changes?
> so that I can rebase RCar DU lib and RZ/G2L DU work on top of that.
>
> Currently I am rebasing on top of drm_tip. Please let me know.
Sure. The tree is available at git://linuxtv.org/pinchartl/media.git,
and my drm next branch for the DU driver is drm/du/next.
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-08-27 18:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 10:39 [PATCH 1/2] drm: rcar-du: Drop unused encoder header files Biju Das
2022-08-25 10:39 ` [PATCH 2/2] drm: rcar-du: Use %p4cc to print 4CC format Biju Das
2022-08-26 23:47 ` Laurent Pinchart
2022-08-27 9:04 ` Biju Das
2022-08-27 18:37 ` Laurent Pinchart [this message]
2022-08-28 6:05 ` Biju Das
2022-08-26 23:42 ` [PATCH 1/2] drm: rcar-du: Drop unused encoder header files Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywpkc5ut97L3kTb1@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Chris.Paterson2@renesas.com \
--cc=airlied@linux.ie \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).