From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7FB8C6FA82 for ; Wed, 21 Sep 2022 16:10:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE2BD10E066; Wed, 21 Sep 2022 16:10:37 +0000 (UTC) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26ABC10E0C5 for ; Wed, 21 Sep 2022 16:10:33 +0000 (UTC) Received: by mail-qt1-x830.google.com with SMTP id g12so4459470qts.1 for ; Wed, 21 Sep 2022 09:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=AMTftBiMWZk2QAmHkrehOI1g5/daemu3hoROzAqo87c=; b=f/UulgVbJR9/vOmsWbt5U91/tnOJo2PNL7TKCK8SY11JbGK+VrMoYbcJhcnMEmf5jQ EovlYjMoktLgNatoK+CVy/Rs7kyV2UA6+8pOZJO7l4anbiUth706rX7MVcJm2FurqfvZ qefHdqd0c/ho17jos0I/MwJ0GFfLtiSQFIshBUoETfF+JIBKx/dTEV8P4MJcgAKTCfgw iOPIc2rXvMSMMVwnmZz1ld8coHSm6IkjdCY6psHq+gvZXV66Pty8+C6P9UseXBXGvQ70 r4tkHYuAgGQJeczB7XpAp+Yau+TWBCZJuVUu2BM/CB1qYJNCkA9RyP2l842CVcM2rxWG DOzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=AMTftBiMWZk2QAmHkrehOI1g5/daemu3hoROzAqo87c=; b=xndpAugXWpBaenB6EhFjYIODMnR9Mm1RJ1frXRU8vl93v0mO2ygdfpysmSMfHlqeto 3KyQIkRrWovO/eTRUaIgVMptfJFapv2bP61p7pBHmdKQ2g491+Pyh6BiLhbWVcFjnWB9 veVwGpmFQ/D5KYLlOmYWUlE0V7SIEZd7eh/7oRUmJPlpc4FcV811QGCw6hluYlOeBcHA 7N1kwjfYVvSDdwyHnBYK1JBYae0gHt7mLcLRM6luWu+Rq8oyk+0vBaRA3q5VXpjRt4ev egvF9xhw7ZKA606uHrux4Xl0evFdnXg8imGwCcLXoMYjhbMGzCNwNHgu6yUpwLM3dVt5 d2QQ== X-Gm-Message-State: ACrzQf2tngnNJx8/nb+aWLUeizLNIMtBkfFfZ8lDdDExVAbgPxNc6gIb ccJSLrsLnKfD64P2M57tBuLNGQ== X-Google-Smtp-Source: AMsMyM6D2XVUjaEeXTE0RkRp6giqAEccP/ds63pJ2ySWLbtpckoAq+4dbYsu8/rqDg2Hj9+Vy46RKw== X-Received: by 2002:ac8:7d10:0:b0:35c:d519:545 with SMTP id g16-20020ac87d10000000b0035cd5190545mr20896336qtb.537.1663776631727; Wed, 21 Sep 2022 09:10:31 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id l3-20020a05620a28c300b006b872b606b1sm2199206qkp.128.2022.09.21.09.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 09:10:30 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ob2Iv-000qCI-Hh; Wed, 21 Sep 2022 13:10:29 -0300 Date: Wed, 21 Sep 2022 13:10:29 -0300 From: Jason Gunthorpe To: "Tian, Kevin" Subject: Re: [PATCH v3 15/15] vfio: Add struct device to vfio_device Message-ID: References: <20220909102247.67324-1-kevin.tian@intel.com> <20220909102247.67324-16-kevin.tian@intel.com> <20220920142639.29b1bdc2.alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Rosato , David Airlie , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Kirti Wankhede , Vineeth Vijayan , Diana Craciun , Alexander Gordeev , Longfang Liu , Christoph Hellwig , "Liu, Yi L" , "kvm@vger.kernel.org" , Leon Romanovsky , Halil Pasic , Christian Borntraeger , "intel-gfx@lists.freedesktop.org" , "Wang, Zhi A" , Tony Krowiak , Eric Farman , Vasily Gorbik , "linux-s390@vger.kernel.org" , Heiko Carstens , Eric Auger , Alex Williamson , Harald Freudenberger , "Vivi, Rodrigo" , "intel-gvt-dev@lists.freedesktop.org" , Jason Herne , Tvrtko Ursulin , Yishai Hadas , Cornelia Huck , Peter Oberparleiter , Shameer Kolothum , Sven Schnelle , Abhishek Sahu Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 20, 2022 at 10:55:40PM +0000, Tian, Kevin wrote: > > From: Alex Williamson > > Sent: Wednesday, September 21, 2022 4:27 AM > > > > On Fri, 9 Sep 2022 18:22:47 +0800 > > Kevin Tian wrote: > > > > > From: Yi Liu > > > > > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the > > > sysfs path of the parent, indicating the device is bound to a vfio > > > driver, e.g.: > > > > > > /sys/devices/pci0000\:6f/0000\:6f\:01.0/vfio-dev/vfio0 > > > > > > It is also a preparatory step toward adding cdev for supporting future > > > device-oriented uAPI. > > > > > > Add Documentation/ABI/testing/sysfs-devices-vfio-dev. > > > > > > Also take this chance to rename chardev 'vfio' to 'vfio-group' in > > > /proc/devices. > > > > What's the risk/reward here, is this just more aesthetically pleasing > > symmetry vs 'vfio-dev'? The char major number to name association in > > /proc/devices seems pretty obscure, but what due diligence have we done > > to make sure this doesn't break anyone? Thanks, > > I'm not sure whether the content of /proc/devices is considered as ABI. > > @Jason? Ah, I've forgotten why we got here - didn't we have a naming conflict with the new stuff that is being introduced? ABI wise it is not a problem unless there is a real user, I'm not aware of anything scanning /proc, that has been obsoleted by sysfs a long time ago. Jason