[PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf()

[PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf()

[cgel.zte]

From: ye xingchen <ye.xingchen@zte.com.cn>

Replace the open-code with sysfs_emit() to simplify the code.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/video/backlight/lp8788_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c
index ba42f3fe0c73..00d79c0cfee9 100644
--- a/drivers/video/backlight/lp8788_bl.c
+++ b/drivers/video/backlight/lp8788_bl.c
@@ -240,7 +240,7 @@ static ssize_t lp8788_get_bl_ctl_mode(struct device *dev,
 	else
 		strmode = "Invalid mode";
 
-	return scnprintf(buf, PAGE_SIZE, "%s\n", strmode);
+	return sysfs_emit(buf, "%s\n", strmode);
 }
 
 static DEVICE_ATTR(bl_ctl_mode, S_IRUGO, lp8788_get_bl_ctl_mode, NULL);
-- 
2.25.1

Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf()

[Han Jingoo]

On Thu, Sep 22, 2022 <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han


> ---
>  drivers/video/backlight/lp8788_bl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c
> index ba42f3fe0c73..00d79c0cfee9 100644
> --- a/drivers/video/backlight/lp8788_bl.c
> +++ b/drivers/video/backlight/lp8788_bl.c
> @@ -240,7 +240,7 @@ static ssize_t lp8788_get_bl_ctl_mode(struct device *dev,
>         else
>                 strmode = "Invalid mode";
>
> -       return scnprintf(buf, PAGE_SIZE, "%s\n", strmode);
> +       return sysfs_emit(buf, "%s\n", strmode);
>  }
>
>  static DEVICE_ATTR(bl_ctl_mode, S_IRUGO, lp8788_get_bl_ctl_mode, NULL);
> --
> 2.25.1

Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf()

[Daniel Thompson]

On Fri, Sep 23, 2022 at 06:35:33AM +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/video/backlight/lp8788_bl.c | 2 +-

This one has the subject right and is a good change. However I'd still
prefer it as a single patchset that fixes *all* instances of this code
pattern.


Daniel.

Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf()

[Han Jingoo]

On Mon, Sep 26, 2022 Daniel Thompson <daniel.thompson@linaro.org> wrote:
>
> On Fri, Sep 23, 2022 at 06:35:33AM +0000, cgel.zte@gmail.com wrote:
> > From: ye xingchen <ye.xingchen@zte.com.cn>
> >
> > Replace the open-code with sysfs_emit() to simplify the code.
> >
> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> > ---
> >  drivers/video/backlight/lp8788_bl.c | 2 +-
>
> This one has the subject right and is a good change. However I'd still
> prefer it as a single patchset that fixes *all* instances of this code
> pattern.

Yes, I agree with Daniel's opinion.

Xingchen,
Please make a "Single" patch for including "ALL" fixes
for this pattern in the 'drivers/video/backlight' directory.
Thank you.

Best regards,
Jingoo Han

>
>
> Daniel.