From: Vinod Koul <vkoul@kernel.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: freedreno@lists.freedesktop.org,
Douglas Anderson <dianders@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jami Kettunen <jami.kettunen@somainline.org>,
Vladimir Lypak <vladimir.lypak@gmail.com>,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel@lists.freedesktop.org,
Javier Martinez Canillas <javierm@redhat.com>,
David Airlie <airlied@linux.ie>,
Martin Botka <martin.botka@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Alex Deucher <alexander.deucher@amd.com>,
phone-devel@vger.kernel.org, Sean Paul <sean@poorly.run>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] drm: Fix math issues in MSM DSC implementation
Date: Tue, 4 Oct 2022 10:12:58 +0530 [thread overview]
Message-ID: <Yzu50ly1AxZwmyvi@matsya> (raw)
In-Reply-To: <20221001190807.358691-1-marijn.suijten@somainline.org>
On 01-10-22, 21:08, Marijn Suijten wrote:
> Various removals of complex yet unnecessary math, fixing all uses of
> drm_dsc_config::bits_per_pixel to deal with the fact that this field
> includes four fractional bits, and finally an approach for dealing with
> dsi_host setting negative values in range_bpg_offset, resulting in
> overflow inside drm_dsc_pps_payload_pack().
>
> Note that updating the static bpg_offset array to limit the size of
> these negative values to 6 bits changes what would be written to the DPU
> hardware at register(s) DSC_RANGE_BPG_OFFSET, hence the choice has been
> made to cover up for this while packing the value into a smaller field
> instead.
Thanks for fixing these. I dont have my pixel3 availble but changes lgtm
Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Altogether this series is responsible for solving _all_ Display Stream
> Compression issues and artifacts on the Sony Tama (sdm845) Akatsuki
> smartphone (2880x1440p).
Does it need two dsi lanes?
--
~Vinod
next prev parent reply other threads:[~2022-10-04 4:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 19:08 [PATCH 0/5] drm: Fix math issues in MSM DSC implementation Marijn Suijten
2022-10-01 19:08 ` [PATCH 1/5] drm/msm/dsi: Remove useless math in DSC calculation Marijn Suijten
2022-10-01 20:19 ` Konrad Dybcio
2022-10-04 0:26 ` Bjorn Andersson
2022-10-04 14:33 ` [Freedreno] " Abhinav Kumar
2022-10-04 22:23 ` Marijn Suijten
2022-10-01 19:08 ` [PATCH 2/5] drm/msm/dsi: Remove repeated calculation of slice_per_intf Marijn Suijten
2022-10-01 20:22 ` Konrad Dybcio
2022-10-04 0:30 ` Bjorn Andersson
2022-10-04 14:41 ` Abhinav Kumar
2022-10-01 19:08 ` [PATCH 3/5] drm/msm/dsi: Account for DSC's bits_per_pixel having 4 fractional bits Marijn Suijten
2022-10-01 20:28 ` Konrad Dybcio
2022-10-01 20:37 ` Marijn Suijten
2022-10-04 14:45 ` Dmitry Baryshkov
2022-10-04 22:35 ` Marijn Suijten
2022-10-04 22:40 ` Dmitry Baryshkov
2022-10-04 22:56 ` Marijn Suijten
2022-10-01 19:08 ` [PATCH 4/5] drm/msm/dpu1: " Marijn Suijten
2022-10-04 14:35 ` Dmitry Baryshkov
2022-10-04 17:03 ` Abhinav Kumar
2022-10-04 22:11 ` Marijn Suijten
2022-10-05 14:19 ` Abhinav Kumar
2022-10-05 18:45 ` Marijn Suijten
2022-10-01 19:08 ` [PATCH 5/5] drm/dsc: Prevent negative BPG offsets from shadowing adjacent bitfields Marijn Suijten
2022-10-01 20:23 ` Marijn Suijten
2022-10-04 14:41 ` Dmitry Baryshkov
2022-10-04 21:48 ` Marijn Suijten
2022-10-04 20:22 ` Abhinav Kumar
2022-10-04 21:57 ` Marijn Suijten
2022-10-04 22:31 ` Abhinav Kumar
2022-10-04 22:39 ` Marijn Suijten
2022-10-05 15:33 ` Abhinav Kumar
2022-10-05 18:29 ` Marijn Suijten
2022-10-04 4:42 ` Vinod Koul [this message]
2022-10-04 9:51 ` [PATCH 0/5] drm: Fix math issues in MSM DSC implementation Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzu50ly1AxZwmyvi@matsya \
--to=vkoul@kernel.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=javierm@redhat.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
--cc=vladimir.lypak@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).