From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96D26EB64D8 for ; Wed, 14 Jun 2023 16:46:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17DF289364; Wed, 14 Jun 2023 16:46:24 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4968310E141 for ; Wed, 14 Jun 2023 16:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AR8QRqbW1yXBNO88g9z3TQccGrksSHt3oK1md7nsOUs=; b=AvM3MRfA5oxs5DIo1GFgpPpUAi uo7/bIe8f+e7jQ1KfRsxTsnXQTyPb8cBznbipFjmWJTS34KCF1BtbDFvOYRj4+m0jLcgaCFl7MM8K fjBFtFn3Btti8j7tkJQMgHr6yCPEza6ianXq8SRJB+CcOS8j9cFq2xlRIEVjVJIbWZ3nEys5Tz/Xx PSEqfIaKiMHI5snKJ2AjPF7FW8ZWK4W/NvuzcUKG6wAuW5A1+c5ca+7h9FyYjyaCA+CLnTYfYZfox KgUOC/lGfPgaJg9WED5dhqceRHtxBM8MmEgr2bKR5uVqbN4PWkK2xmH7mWC/NYRlbYq8JcEgnPg7M jbcwPHkg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50712) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q9TdP-000219-Lk; Wed, 14 Jun 2023 17:46:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q9TdO-0000aR-LS; Wed, 14 Jun 2023 17:46:14 +0100 Date: Wed, 14 Jun 2023 17:46:14 +0100 From: "Russell King (Oracle)" To: Lucas Stach Subject: Re: [PATCH] drm/etnaviv: disable MLCG and pulse eater on GPU reset Message-ID: References: <20230607125841.3518385-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607125841.3518385-1-l.stach@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@pengutronix.de, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jun 07, 2023 at 02:58:41PM +0200, Lucas Stach wrote: > Module level clock gating and the pulse eater might interfere with > the GPU reset, as they both have the potential to stop the clock > and thus reset propagation to parts of the GPU. > > Signed-off-by: Lucas Stach > --- > I'm not aware of any cases where this would have been an issue, but > it is what the downstream driver does and fundametally seems like > the right thing to do. Maybe Dove, where the PLLs generating the clock to the GPU can be changed, iirc? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!