From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DD0C433E0 for ; Wed, 3 Feb 2021 10:15:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EFA964F59 for ; Wed, 3 Feb 2021 10:15:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EFA964F59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=emersion.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF9436EA47; Wed, 3 Feb 2021 10:15:21 +0000 (UTC) Received: from mail1.protonmail.ch (mail1.protonmail.ch [185.70.40.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6888A6EA47 for ; Wed, 3 Feb 2021 10:15:21 +0000 (UTC) Date: Wed, 03 Feb 2021 10:15:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1612347318; bh=OcypwBC0JNKDbx1oN2N6fH8WJTtH+nQt0jXTr3U1tYg=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=UNEJjfm585zn+fUgtLB6O6sgaPNDT2u2V0Avj9SyPDhZ7mFUpL2Dpl/JOOqJiAurX +fSdW5ccKy0JWpuklyf/UOJW4y9o/5bHZcvA7dRT40fGTbaa1yfpL6oafMQexuJ1I+ pkDT4Rue3pcBWI87Mb2dtGVaYnC+zdWqrThuQMaFORgRKSUOmhU08qNBH9eOYZHkbV XwcZfafdWo5HDP6zgfsw0Z8ZsqstULXAKSRxFjFjgQ8lWW+8TS0hrrGt6Il78uDyjW 0vg/Oc8UKgs+xMDuxuMxQZFuruPeIITHPrz438/Y0lNS6UG2JHcV227TV6Bxz7UKdn Lx2I1w9ncaY5w== To: Emil Velikov From: Simon Ser Subject: Re: [PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard Message-ID: <_L67Dl3bTZirFqSulhWUeN215npWnjsPyUzg7Rb-2iffHxMbZ1-H6ex7R14gdkDqZfpRw9xLoiol8m5WtPKuJxiBN_FcnailoQHvW02qNI0=@emersion.fr> In-Reply-To: References: <20210202224704.2794318-1-emil.l.velikov@gmail.com> <1eXnpBNSePW1qsq6q5BR3IEa6Q4DGeWBmJ23QArM9eGt12sN9W2Mhpk2OkUwZj-fhRjAtf9XNne5vxJ-7_JjPl549Ml3wxwMo0hhKsojL_4=@emersion.fr> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: Pekka Paalanen , dri-devel , James Park Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wednesday, February 3rd, 2021 at 11:08 AM, Emil Velikov wrote: > On Wed, 3 Feb 2021 at 09:27, Simon Ser wrote: > > > > On Wednesday, February 3rd, 2021 at 1:56 AM, Emil Velikov emil.l.velikov@gmail.com wrote: > > > > > As summed in the commit message the burden is only applicable when all > > > of the following are set: > > > - non-linux > > > - force DRM_FOURCC_STANDALONE > > > - c99 -pedantic > > > > Oh, and FWIW, this is not a theoretical situation at all. All of these > > conditions happen to be true on my compositor. It has FreeBSD CI, > > -Werror, and will use DRM_FOURCC_STANDALONE when available. > > There are ways to disable [1] or silence [2] this - are you > intentionally ignoring them? We have a policy against pragma. However we already use -std=c11, so in fact wouldn't be affected by this change. > Or the goal here is to 'fix' the kernel for a very uncommon non-linux use-case? If the kernel doesn't care about non-Linux, why is there an #ifdef __linux__ in the first place? > [1] pragma GCC diagnostic warning "-Wpedantic" > [2] pragma GCC diagnostic ignored or -std=c11 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel