From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Jyri Sarha <jsarha@ti.com>, Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org
Cc: Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
David Airlie <airlied@linux.ie>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: hdmi-codec: Allow drivers to restrict sample sizes.
Date: Thu, 27 Jul 2017 13:04:16 +0100 [thread overview]
Message-ID: <a4452e1f-d5d6-4940-c7b4-9a78b92fe641@linaro.org> (raw)
In-Reply-To: <ea28ff3a-f688-fda3-908b-67fd49244b9b@ti.com>
On 27/07/17 11:34, Jyri Sarha wrote:
> On 07/17/17 17:02, srinivas.kandagatla@linaro.org wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> Currently hdmi client drivers does have means to limit the
>> sample sizes that it can only support. Having formats parameter
>> option would solve this.
>>
>> This issue was noticed on DB410c board when adv7511 hdmi codec driver
>> failed to play a 32 bits audio samples, as it does not support them.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> I left this feature out because I did not need it. All the HDMI encoders
> I have used are able to take all the i2s formats I am able to send.
>
> You should probably also update the comment above I2S_FORMATS
> definition. Othewise:
Make sense, I will update it and send a v2 patch.
>
> Reviewed-by: Jyri Sarha <jsarha@ti.com>
thanks
--srini
>
>
>> ---
>> include/sound/hdmi-codec.h | 1 +
>> sound/soc/codecs/hdmi-codec.c | 3 +++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h
>> index 9483c55f871b..89fc4cce5785 100644
>> --- a/include/sound/hdmi-codec.h
>> +++ b/include/sound/hdmi-codec.h
>> @@ -104,6 +104,7 @@ struct hdmi_codec_pdata {
>> uint i2s:1;
>> uint spdif:1;
>> int max_i2s_channels;
>> + u64 formats;
>> void *data;
>> };
>>
>> diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
>> index 22ed0dc88f0a..1ece73f4be92 100644
>> --- a/sound/soc/codecs/hdmi-codec.c
>> +++ b/sound/soc/codecs/hdmi-codec.c
>> @@ -780,6 +780,9 @@ static int hdmi_codec_probe(struct platform_device *pdev)
>> hcp->daidrv[i] = hdmi_i2s_dai;
>> hcp->daidrv[i].playback.channels_max =
>> hcd->max_i2s_channels;
>> +
>> + if (hcd->formats)
>> + hcp->daidrv[i].playback.formats = hcd->formats;
>> i++;
>> }
>>
>>
>
next prev parent reply other threads:[~2017-07-27 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 14:02 [PATCH 0/2] ASoC: hdmi-codec: Allow driver to restrict sample size srinivas.kandagatla
2017-07-17 14:02 ` [PATCH 1/2] ASoC: hdmi-codec: Allow drivers to restrict sample sizes srinivas.kandagatla
2017-07-27 10:34 ` Jyri Sarha
2017-07-27 12:04 ` Srinivas Kandagatla [this message]
2017-07-17 14:02 ` [PATCH 2/2] drm/bridge: adv7511: restrict audio " srinivas.kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4452e1f-d5d6-4940-c7b4-9a78b92fe641@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=architt@codeaurora.org \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).