From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4780AC433DB for ; Wed, 3 Feb 2021 14:07:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF66164E4E for ; Wed, 3 Feb 2021 14:07:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF66164E4E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E21226EACD; Wed, 3 Feb 2021 14:07:20 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65CE46EAC4; Wed, 3 Feb 2021 14:07:19 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0008FACB0; Wed, 3 Feb 2021 14:07:17 +0000 (UTC) Subject: Re: [PATCH v5 4/6] drm/qxl: handle shadow in primary destroy To: Gerd Hoffmann , dri-devel@lists.freedesktop.org References: <20210203131615.1714021-1-kraxel@redhat.com> <20210203131615.1714021-5-kraxel@redhat.com> From: Thomas Zimmermann Message-ID: Date: Wed, 3 Feb 2021 15:07:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210203131615.1714021-5-kraxel@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" Content-Type: multipart/mixed; boundary="===============0752386532==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0752386532== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zVkp2LbXeo9xdK24qHbVhhpFZXgl64cyQ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --zVkp2LbXeo9xdK24qHbVhhpFZXgl64cyQ Content-Type: multipart/mixed; boundary="VtRkb7Y62egMcaLwIsPWaCXoVqjlYGBKM"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie Message-ID: Subject: Re: [PATCH v5 4/6] drm/qxl: handle shadow in primary destroy References: <20210203131615.1714021-1-kraxel@redhat.com> <20210203131615.1714021-5-kraxel@redhat.com> In-Reply-To: <20210203131615.1714021-5-kraxel@redhat.com> --VtRkb7Y62egMcaLwIsPWaCXoVqjlYGBKM Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 03.02.21 um 14:16 schrieb Gerd Hoffmann: > qxl_primary_atomic_disable must check whenever the framebuffer bo has a= > shadow surface and in case it has check the shadow primary status. I believe you :) Acked-by: Thomas Zimmermann >=20 > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_display.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qx= l_display.c > index 60331e31861a..f5ee8cd72b5b 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -562,6 +562,8 @@ static void qxl_primary_atomic_disable(struct drm_p= lane *plane, > if (old_state->fb) { > struct qxl_bo *bo =3D gem_to_qxl_bo(old_state->fb->obj[0]); > =20 > + if (bo->shadow) > + bo =3D bo->shadow; > if (bo->is_primary) { > qxl_io_destroy_primary(qdev); > bo->is_primary =3D false; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --VtRkb7Y62egMcaLwIsPWaCXoVqjlYGBKM-- --zVkp2LbXeo9xdK24qHbVhhpFZXgl64cyQ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAarhQFAwAAAAAACgkQlh/E3EQov+B5 0Q//QF3+DxUtgM4jYfWiDkOHWVPkTilkocbU+UmeJ4FeVVTtpsBpmVkMnZgJINaapQhY1NUnpI6k hpvgCT+tekKDBOZutLQXWWPy5T1r7Smrhip8Db1BzElpkl7XK0ONQ5b2EqmfLCfVv53pBKR7nSov 1nFv8gCLQwmAUkeW5Rw1SRlXioQbs5ByeD5anVHUKsDMoovDyflyfgRG1P+z1KA9CB5d3vaH0wTS AHGednnr0q9GeVeLHN9UCKzIXF0zClSZ7DovbPgmcTYS3TDjU8JNPf8qfjMJyhocTS9n036At65X kIbK7HxblJtmUmJ2cTRkmxgou0mqtbD2PTYyHTvMEQwQCUP9kRU3/rMlhEVtiOxHpOw9RxcApXta GOTVQZSgHhZ/ukfZg65fltF7Gm5jCUSaaqSs/00tuUN9ACpoCyTEc2e/ubwxvx4J1vqDka9wpTZv 7BtAdpu+En5NjYYsSGrsr87OObNx334zYQN2knzyI1ah3lvQ5vs9qxkgmHcRzK+e7iop3HWqak3g MTn7DEK4X4A7ASH0F7c/bgMhtk5fAJAFNLXXid/7f2kiY0LeR0JwTGFUJBX0uzV7O0Bt7kW57Zpi LyCuF22UrSGlW5FOQN5EDqck5F9I4mNkB+WpbE3RiMx7jjTX3gL6K4/fSvDXbMo4ICW30BwvSKra 7sk= =dwrl -----END PGP SIGNATURE----- --zVkp2LbXeo9xdK24qHbVhhpFZXgl64cyQ-- --===============0752386532== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0752386532==--