From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDBDEC4727E for ; Wed, 7 Oct 2020 15:40:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78EA5216C4 for ; Wed, 7 Oct 2020 15:40:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78EA5216C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACD3A6E92E; Wed, 7 Oct 2020 15:39:47 +0000 (UTC) Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EE806E0B7 for ; Wed, 7 Oct 2020 08:55:28 +0000 (UTC) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C5p7y4fTgz1sKws; Wed, 7 Oct 2020 10:55:26 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C5p7y3S4Wz1qrg1; Wed, 7 Oct 2020 10:55:26 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id pVdtjYUFZmes; Wed, 7 Oct 2020 10:55:25 +0200 (CEST) X-Auth-Info: eiw9MaL2QKiNMyfl0i4guceaEjt7cfh6XMdWAsJFelo= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 7 Oct 2020 10:55:24 +0200 (CEST) Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML To: Lucas Stach , Laurent Pinchart , dri-devel@lists.freedesktop.org References: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com> <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> From: Marek Vasut Message-ID: Date: Wed, 7 Oct 2020 10:55:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Wed, 07 Oct 2020 15:39:39 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, =?UTF-8?Q?Guido_G=c3=bcnther?= , Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/7/20 10:43 AM, Lucas Stach wrote: > On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote: >> On 10/7/20 3:24 AM, Laurent Pinchart wrote: >> [...] >>> +properties: >>> + compatible: >>> + enum: >>> + - fsl,imx23-lcdif >>> + - fsl,imx28-lcdif >>> + - fsl,imx6sx-lcdif >>> + - fsl,imx8mq-lcdif >> >> There is no fsl,imx8mq-lcdif in drivers/gpu/drm/mxsfb/mxsfb_drv.c, >> so the DT must specify compatible = "fsl,imx8mq-lcdif", >> "fsl,imx28-lcdif" (since imx28 is the oldest SoC with LCDIF V4). >> >> Should the compatible be added to drivers/gpu/drm/mxsfb/mxsfb_drv.c or >> dropped from the YAML file or neither ? > > Neither. As far as we know the block is compatible, so the DT should > claim that it's compatible to "fsl,imx28-lcdif". However we don't know > if there are any surprises, so we add the SoC specific compatible to be > able to change the driver matching later without changing the DT if the > need arises. For the DT validation to pass the SoC specific compatible > needs to be documented, even if it currently unused by the driver. What in that binding says you should specify compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif"; and not e.g. "fsl,imx8mq-lcdif", "fsl,imx23-lcdif" or simply "fsl,imx8mq-lcdif" ? _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel