From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Bingham Subject: Re: [PATCH v6 11/18] media: vsp1: drm: Implement writeback support Date: Wed, 13 Mar 2019 11:42:34 +0000 Message-ID: References: <20190313000532.7087-1-laurent.pinchart+renesas@ideasonboard.com> <20190313000532.7087-12-laurent.pinchart+renesas@ideasonboard.com> Reply-To: kieran.bingham@ideasonboard.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB96E89E3E for ; Wed, 13 Mar 2019 11:42:39 +0000 (UTC) In-Reply-To: <20190313000532.7087-12-laurent.pinchart+renesas@ideasonboard.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Liviu Dudau , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgTGF1cmVudCwKCk9uIDEzLzAzLzIwMTkgMDA6MDUsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6 Cj4gRXh0ZW5kIHRoZSB2c3AxX2R1X2F0b21pY19mbHVzaCgpIEFQSSB3aXRoIHdyaXRlYmFjayBz dXBwb3J0IGJ5IGFkZGluZwo+IGZvcm1hdCwgcGl0Y2ggYW5kIG1lbW9yeSBhZGRyZXNzZXMgb2Yg dGhlIHdyaXRlYmFjayBmcmFtZWJ1ZmZlci4KPiBXcml0ZWJhY2sgY29tcGxldGlvbiBpcyByZXBv cnRlZCB0aHJvdWdoIHRoZSBleGlzdGluZyBmcmFtZSBjb21wbGV0aW9uCj4gY2FsbGJhY2sgd2l0 aCBhIG5ldyBWU1AxX0RVX1NUQVRVU19XUklURUJBQ0sgc3RhdHVzIGZsYWcuCj4gCj4gU2lnbmVk LW9mZi1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFz b25ib2FyZC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2Rs LmMgIHwgMTQgKysrKysrKysrKysrKysKPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3Zz cDFfZGwuaCAgfCAgMyArKy0KPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJt LmMgfCAyNSArKysrKysrKysrKysrKysrKysrKysrKystCj4gIGluY2x1ZGUvbWVkaWEvdnNwMS5o ICAgICAgICAgICAgICAgICAgIHwgMTUgKysrKysrKysrKysrKysrCj4gIDQgZmlsZXMgY2hhbmdl ZCwgNTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZv cm0vdnNwMS92c3AxX2RsLmMKPiBpbmRleCBlZDdjZGE0MTMwZjIuLjEwNGI2ZjUxNDUzNiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kbC5jCj4gKysrIGIv ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuYwo+IEBAIC05NTgsNiArOTU4LDkg QEAgdm9pZCB2c3AxX2RsX2xpc3RfY29tbWl0KHN0cnVjdCB2c3AxX2RsX2xpc3QgKmRsLCB1bnNp Z25lZCBpbnQgZGxfZmxhZ3MpCj4gICAqCj4gICAqIFRoZSBWU1AxX0RMX0ZSQU1FX0VORF9JTlRF Uk5BTCBmbGFnIGluZGljYXRlcyB0aGF0IHRoZSBkaXNwbGF5IGxpc3QgdGhhdCBqdXN0Cj4gICAq IGJlY2FtZSBhY3RpdmUgaGFkIGJlZW4gcXVldWVkIHdpdGggdGhlIGludGVybmFsIG5vdGlmaWNh dGlvbiBmbGFnLgo+ICsgKgo+ICsgKiBUaGUgVlNQMV9ETF9GUkFNRV9FTkRfV1JJVEVCQUNLIGZs YWcgaW5kaWNhdGVzIHRoYXQgdGhlIHByZXZpb3VzbHkgYWN0aXZlCj4gKyAqIGRpc3BsYXkgbGlz dCBoYWQgYmVlbiBxdWV1ZWQgd2l0aCB0aGUgd3JpdGViYWNrIGZsYWcuCgpIb3cgZG9lcyB0aGlz IGludGVyYWN0IHdpdGggdGhlIHBvc3NpYmlsaXR5IG9mIHRoZSB3cml0ZWJhY2sgYmVpbmcKZGlz YWJsZWQgYnkgdGhlIFdQRiBpbiB0aGUgZXZlbnQgb2YgaXQgZmFpbGluZyB0byBnZXQgYSBETC4K Ckl0J3Mgb25seSBhIHNtYWxsIGNvcm5lciBjYXNlLCBidXQgd2lsbCB0aGUgJ3dyaXRlYmFjaycg cmVwb3J0IGJhY2sgYXMKdGhvdWdoIGl0IHN1Y2NlZWRlZD8gKHdpdGhvdXQgd3JpdGluZyB0byBt ZW1vcnksIGFuZCB0aHVzIGdpdmluZyBhbgp1bm1vZGlmaWVkIGJ1ZmZlciBiYWNrPykKCgo+ICAg Ki8KPiAgdW5zaWduZWQgaW50IHZzcDFfZGxtX2lycV9mcmFtZV9lbmQoc3RydWN0IHZzcDFfZGxf bWFuYWdlciAqZGxtKQo+ICB7Cj4gQEAgLTk5NSw2ICs5OTgsMTcgQEAgdW5zaWduZWQgaW50IHZz cDFfZGxtX2lycV9mcmFtZV9lbmQoc3RydWN0IHZzcDFfZGxfbWFuYWdlciAqZGxtKQo+ICAJaWYg KHN0YXR1cyAmIFZJNl9TVEFUVVNfRkxEX1NURChkbG0tPmluZGV4KSkKPiAgCQlnb3RvIGRvbmU7 Cj4gIAo+ICsJLyoKPiArCSAqIElmIHRoZSBhY3RpdmUgZGlzcGxheSBsaXN0IGhhcyB0aGUgd3Jp dGViYWNrIGZsYWcgc2V0LCB0aGUgZnJhbWUKPiArCSAqIGNvbXBsZXRpb24gbWFya3MgdGhlIGVu ZCBvZiB0aGUgd3JpdGViYWNrIGNhcHR1cmUuIFJldHVybiB0aGUKPiArCSAqIFZTUDFfRExfRlJB TUVfRU5EX1dSSVRFQkFDSyBmbGFnIGFuZCByZXNldCB0aGUgZGlzcGxheSBsaXN0J3MKPiArCSAq IHdyaXRlYmFjayBmbGFnLgo+ICsJICovCj4gKwlpZiAoZGxtLT5hY3RpdmUgJiYgKGRsbS0+YWN0 aXZlLT5mbGFncyAmIFZTUDFfRExfRlJBTUVfRU5EX1dSSVRFQkFDSykpIHsKPiArCQlmbGFncyB8 PSBWU1AxX0RMX0ZSQU1FX0VORF9XUklURUJBQ0s7Cj4gKwkJZGxtLT5hY3RpdmUtPmZsYWdzICY9 IH5WU1AxX0RMX0ZSQU1FX0VORF9XUklURUJBQ0s7Cj4gKwl9Cj4gKwo+ICAJLyoKPiAgCSAqIFRo ZSBkZXZpY2Ugc3RhcnRzIHByb2Nlc3NpbmcgdGhlIHF1ZXVlZCBkaXNwbGF5IGxpc3QgcmlnaHQg YWZ0ZXIgdGhlCj4gIAkgKiBmcmFtZSBlbmQgaW50ZXJydXB0LiBUaGUgZGlzcGxheSBsaXN0IHRo dXMgYmVjb21lcyBhY3RpdmUuCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v dnNwMS92c3AxX2RsLmggYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kbC5oCj4g aW5kZXggZTBmZGIxNDVlNmVkLi40ZDdiY2ZkYzliZDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuaAo+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZv cm0vdnNwMS92c3AxX2RsLmgKPiBAQCAtMTgsNyArMTgsOCBAQCBzdHJ1Y3QgdnNwMV9kbF9saXN0 Owo+ICBzdHJ1Y3QgdnNwMV9kbF9tYW5hZ2VyOwo+ICAKPiAgI2RlZmluZSBWU1AxX0RMX0ZSQU1F X0VORF9DT01QTEVURUQJCUJJVCgwKQo+IC0jZGVmaW5lIFZTUDFfRExfRlJBTUVfRU5EX0lOVEVS TkFMCQlCSVQoMSkKPiArI2RlZmluZSBWU1AxX0RMX0ZSQU1FX0VORF9XUklURUJBQ0sJCUJJVCgx KQoKU28gYmVsb3cgQklUKDIpIChjb2RlIGFib3ZlKSB0aGUgZmxhZ3MgbWF0Y2ggdGhlIGV4dGVy bmFsbHkgZXhwb3NlZApiaXRmaWVsZCBmb3IgdGhlIFZTUDFfRFVfU1RBVFVTXwoKV2hpbGUgYWJv dmUgKGNvZGUgYmVsb3cpLCBhcmUgJ3ByaXZhdGUnIGJpdGZpZWxkcy4KClNob3VsZCB0aGlzIHJl cXVpcmVtZW50IGJlIGRvY3VtZW50ZWQgaGVyZSBzb21laG93PyBlc3BlY2lhbGx5IHRoZQptYXBw aW5nIG9mIEZSQU1FX0VORF97Q09NUExFVEVELFdSSVRFQkFDS30gdG8KRFVfU1RBVFVTX3tDT01Q TEVURUQsV1JJVEVCQUNLfS4KCgoKPiArI2RlZmluZSBWU1AxX0RMX0ZSQU1FX0VORF9JTlRFUk5B TAkJQklUKDIpCgoKPiAgCj4gIC8qKgo+ICAgKiBzdHJ1Y3QgdnNwMV9kbF9leHRfY21kIC0gRXh0 ZW5kZWQgRGlzcGxheSBjb21tYW5kCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZv cm0vdnNwMS92c3AxX2RybS5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJt LmMKPiBpbmRleCAwMzY3Zjg4MTM1YmYuLjE2ODI2YmYxODRjNyAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kcm0uYwo+ICsrKyBiL2RyaXZlcnMvbWVkaWEv cGxhdGZvcm0vdnNwMS92c3AxX2RybS5jCj4gQEAgLTM3LDcgKzM3LDkgQEAgc3RhdGljIHZvaWQg dnNwMV9kdV9waXBlbGluZV9mcmFtZV9lbmQoc3RydWN0IHZzcDFfcGlwZWxpbmUgKnBpcGUsCj4g IAo+ICAJaWYgKGRybV9waXBlLT5kdV9jb21wbGV0ZSkgewo+ICAJCXN0cnVjdCB2c3AxX2VudGl0 eSAqdWlmID0gZHJtX3BpcGUtPnVpZjsKPiAtCQl1bnNpZ25lZCBpbnQgc3RhdHVzID0gY29tcGxl dGlvbiAmIFZTUDFfRFVfU1RBVFVTX0NPTVBMRVRFOwo+ICsJCXVuc2lnbmVkIGludCBzdGF0dXMg PSBjb21wbGV0aW9uCj4gKwkJCQkgICAgJiAoVlNQMV9EVV9TVEFUVVNfQ09NUExFVEUgfAo+ICsJ CQkJICAgICAgIFZTUDFfRFVfU1RBVFVTX1dSSVRFQkFDSyk7Cj4gIAkJdTMyIGNyYzsKPiAgCj4g IAkJY3JjID0gdWlmID8gdnNwMV91aWZfZ2V0X2NyYyh0b191aWYoJnVpZi0+c3ViZGV2KSkgOiAw Owo+IEBAIC01NDEsNiArNTQzLDggQEAgc3RhdGljIHZvaWQgdnNwMV9kdV9waXBlbGluZV9jb25m aWd1cmUoc3RydWN0IHZzcDFfcGlwZWxpbmUgKnBpcGUpCj4gIAo+ICAJaWYgKGRybV9waXBlLT5m b3JjZV9icnhfcmVsZWFzZSkKPiAgCQlkbF9mbGFncyB8PSBWU1AxX0RMX0ZSQU1FX0VORF9JTlRF Uk5BTDsKPiArCWlmIChwaXBlLT5vdXRwdXQtPndyaXRlYmFjaykKPiArCQlkbF9mbGFncyB8PSBW U1AxX0RMX0ZSQU1FX0VORF9XUklURUJBQ0s7Cj4gIAo+ICAJZGwgPSB2c3AxX2RsX2xpc3RfZ2V0 KHBpcGUtPm91dHB1dC0+ZGxtKTsKPiAgCWRsYiA9IHZzcDFfZGxfbGlzdF9nZXRfYm9keTAoZGwp Owo+IEBAIC04NzAsMTIgKzg3NCwzMSBAQCB2b2lkIHZzcDFfZHVfYXRvbWljX2ZsdXNoKHN0cnVj dCBkZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGVfaW5kZXgsCj4gIAlzdHJ1Y3QgdnNwMV9k ZXZpY2UgKnZzcDEgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiAgCXN0cnVjdCB2c3AxX2RybV9w aXBlbGluZSAqZHJtX3BpcGUgPSAmdnNwMS0+ZHJtLT5waXBlW3BpcGVfaW5kZXhdOwo+ICAJc3Ry dWN0IHZzcDFfcGlwZWxpbmUgKnBpcGUgPSAmZHJtX3BpcGUtPnBpcGU7Cj4gKwlpbnQgcmV0Owo+ ICAKPiAgCWRybV9waXBlLT5jcmMgPSBjZmctPmNyYzsKPiAgCj4gIAltdXRleF9sb2NrKCZ2c3Ax LT5kcm0tPmxvY2spOwo+ICsKPiArCWlmIChwaXBlLT5vdXRwdXQtPmhhc193cml0ZWJhY2sgJiYg Y2ZnLT53cml0ZWJhY2sucGl4ZWxmb3JtYXQpIHsKCklzIHBpcGUtPm91dHB1dC0+aGFzX3dyaXRl YmFjayBuZWNlc3NhcnkgaGVyZT8gQ2FuCmNmZy0+d3JpdGViYWNrLnBpeGVsZm9ybWF0IGJlIHNl dCBpZiBwaXBlLT5vdXRwdXQtPmhhc193cml0ZWJhY2sgaXMgZmFsc2U/CgpIcm0gLi4uIGFjdHVh bGx5IC0gUGVyaGFwcyBpdCBpcyB1c2VmdWwuIEl0IHZhbGlkYXRlcyBib3RoIHNpZGVzIG9mIHRo ZQpzeXN0ZW0uCgpwaXBlLT5vdXRwdXQtPmhhc193cml0ZWJhY2sgaXMgYSBjYXBhYmlsaXR5IG9m IHRoZSBWU1AsIHdoZXJlIGFzCmNmZy0+d3JpdGViYWNrLnBpeGVsZm9ybWF0IGlzIGEgJ3JlcXVl c3QnIGZyb20gdGhlIERVLgoKCj4gKwkJY29uc3Qgc3RydWN0IHZzcDFfZHVfd3JpdGViYWNrX2Nv bmZpZyAqd2JfY2ZnID0gJmNmZy0+d3JpdGViYWNrOwo+ICsKPiArCQlyZXQgPSB2c3AxX2R1X3Bp cGVsaW5lX3NldF9yd3BmX2Zvcm1hdCh2c3AxLCBwaXBlLT5vdXRwdXQsCj4gKwkJCQkJCSAgICAg ICB3Yl9jZmctPnBpeGVsZm9ybWF0LAo+ICsJCQkJCQkgICAgICAgd2JfY2ZnLT5waXRjaCk7Cj4g KwkJaWYgKFdBUk5fT04ocmV0IDwgMCkpCj4gKwkJCWdvdG8gZG9uZTsKPiArCj4gKwkJcGlwZS0+ b3V0cHV0LT5tZW0uYWRkclswXSA9IHdiX2NmZy0+bWVtWzBdOwo+ICsJCXBpcGUtPm91dHB1dC0+ bWVtLmFkZHJbMV0gPSB3Yl9jZmctPm1lbVsxXTsKPiArCQlwaXBlLT5vdXRwdXQtPm1lbS5hZGRy WzJdID0gd2JfY2ZnLT5tZW1bMl07Cj4gKwkJcGlwZS0+b3V0cHV0LT53cml0ZWJhY2sgPSB0cnVl Owo+ICsJfQo+ICsKPiAgCXZzcDFfZHVfcGlwZWxpbmVfc2V0dXBfaW5wdXRzKHZzcDEsIHBpcGUp Owo+ICAJdnNwMV9kdV9waXBlbGluZV9jb25maWd1cmUocGlwZSk7Cj4gKwo+ICtkb25lOgo+ICAJ bXV0ZXhfdW5sb2NrKCZ2c3AxLT5kcm0tPmxvY2spOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0xfR1BM KHZzcDFfZHVfYXRvbWljX2ZsdXNoKTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9tZWRpYS92c3Ax LmggYi9pbmNsdWRlL21lZGlhL3ZzcDEuaAo+IGluZGV4IDg3NzQ5NjkzNjQ4Ny4uY2MxYjBkNDJj ZTk1IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbWVkaWEvdnNwMS5oCj4gKysrIGIvaW5jbHVkZS9t ZWRpYS92c3AxLmgKPiBAQCAtMTgsNiArMTgsNyBAQCBzdHJ1Y3QgZGV2aWNlOwo+ICBpbnQgdnNw MV9kdV9pbml0KHN0cnVjdCBkZXZpY2UgKmRldik7Cj4gIAo+ICAjZGVmaW5lIFZTUDFfRFVfU1RB VFVTX0NPTVBMRVRFCQlCSVQoMCkKPiArI2RlZmluZSBWU1AxX0RVX1NUQVRVU19XUklURUJBQ0sJ QklUKDEpCj4gIAo+ICAvKioKPiAgICogc3RydWN0IHZzcDFfZHVfbGlmX2NvbmZpZyAtIFZTUCBM SUYgY29uZmlndXJhdGlvbgo+IEBAIC04MywxMiArODQsMjYgQEAgc3RydWN0IHZzcDFfZHVfY3Jj X2NvbmZpZyB7Cj4gIAl1bnNpZ25lZCBpbnQgaW5kZXg7Cj4gIH07Cj4gIAo+ICsvKioKPiArICog c3RydWN0IHZzcDFfZHVfd3JpdGViYWNrX2NvbmZpZyAtIFZTUCB3cml0ZWJhY2sgY29uZmlndXJh dGlvbiBwYXJhbWV0ZXJzCj4gKyAqIEBwaXhlbGZvcm1hdDogcGxhbmUgcGl4ZWwgZm9ybWF0IChW NEwyIDRDQykKPiArICogQHBpdGNoOiBsaW5lIHBpdGNoIGluIGJ5dGVzIGZvciB0aGUgZmlyc3Qg cGxhbmUKPiArICogQG1lbTogRE1BIG1lbW9yeSBhZGRyZXNzIGZvciBlYWNoIHBsYW5lIG9mIHRo ZSBmcmFtZSBidWZmZXIKPiArICovCj4gK3N0cnVjdCB2c3AxX2R1X3dyaXRlYmFja19jb25maWcg ewo+ICsJdTMyIHBpeGVsZm9ybWF0Owo+ICsJdW5zaWduZWQgaW50IHBpdGNoOwo+ICsJZG1hX2Fk ZHJfdCBtZW1bM107Cj4gK307Cj4gKwo+ICAvKioKPiAgICogc3RydWN0IHZzcDFfZHVfYXRvbWlj X3BpcGVfY29uZmlnIC0gVlNQIGF0b21pYyBwaXBlIGNvbmZpZ3VyYXRpb24gcGFyYW1ldGVycwo+ ICAgKiBAY3JjOiBDUkMgY29tcHV0YXRpb24gY29uZmlndXJhdGlvbgo+ICsgKiBAd3JpdGViYWNr OiB3cml0ZWJhY2sgY29uZmlndXJhdGlvbgo+ICAgKi8KPiAgc3RydWN0IHZzcDFfZHVfYXRvbWlj X3BpcGVfY29uZmlnIHsKPiAgCXN0cnVjdCB2c3AxX2R1X2NyY19jb25maWcgY3JjOwo+ICsJc3Ry dWN0IHZzcDFfZHVfd3JpdGViYWNrX2NvbmZpZyB3cml0ZWJhY2s7Cj4gIH07Cj4gIAo+ICB2b2lk IHZzcDFfZHVfYXRvbWljX2JlZ2luKHN0cnVjdCBkZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBp cGVfaW5kZXgpOwo+IAoKLS0gClJlZ2FyZHMKLS0KS2llcmFuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==