From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v6 3/3] drm/i915/icl: Implement half float formats Date: Wed, 13 Mar 2019 08:25:51 +0100 Message-ID: References: <1552437513-22648-1-git-send-email-kevin.strasser@intel.com> <1552437513-22648-4-git-send-email-kevin.strasser@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1552437513-22648-4-git-send-email-kevin.strasser@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kevin Strasser , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: David Airlie , Daniel Vetter , Uma Shankar List-Id: dri-devel@lists.freedesktop.org T3AgMTMtMDMtMjAxOSBvbSAwMTozOCBzY2hyZWVmIEtldmluIFN0cmFzc2VyOgo+IDY0IGJwcCBo YWxmIGZsb2F0IGZvcm1hdHMgYXJlIHN1cHBvcnRlZCBvbiBoZHIgcGxhbmVzIG9ubHkgYW5kIGFy ZSBzdWJqZWN0Cj4gdG8gdGhlIGZvbGxvd2luZyByZXN0cmljdGlvbnM6Cj4gICAqIDkwLzI3MCBy b3RhdGlvbiBub3Qgc3VwcG9ydGVkCj4gICAqIFlmIFRpbGluZyBub3Qgc3VwcG9ydGVkCj4gICAq IEZyYW1lIEJ1ZmZlciBDb21wcmVzc2lvbiBub3Qgc3VwcG9ydGVkCj4gICAqIENvbG9yIEtleWlu ZyBub3Qgc3VwcG9ydGVkCj4KPiB2MjoKPiAtIERyb3AgaGFuZGxpbmcgcGl4ZWwgbm9ybWFsaXpl IHJlZ2lzdGVyCj4gLSBEb24ndCB1c2UgaWNsX2lzX2hkcl9wbGFuZSB0b28gZWFybHkKPgo+IHYz Ogo+IC0gVXNlIHJlZmFjdG9yZWQgaWNsX2lzX2hkcl9wbGFuZSAoVmlsbGUpCj4gLSBVc2UgdTMy IGluc3RlYWQgb2YgdWludDMyX3QgKFZpbGxlKQo+Cj4gdjY6Cj4gLSBSZWJhc2UgYW5kIGZpeCBt ZXJnZSBjb25mbGljdHMKPiAtIFJlb3JnYW5pemUgc3dpdGNoIHN0YXRlbWVudHMgdG8ga2VlcCBS R0IgZ3JvdXBlZCBzZXBhcmF0ZWx5IGZyb20gWVVWCj4KPiBDYzogVW1hIFNoYW5rYXIgPHVtYS5z aGFua2FyQGludGVsLmNvbT4KPiBDYzogU2hhc2hhbmsgU2hhcm1hIDxzaGFzaGFuay5zaGFybWFA aW50ZWwuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IERh bmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBLZXZpbiBTdHJhc3NlciA8a2V2aW4u c3RyYXNzZXJAaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBNYWFydGVuIExhbmtob3Jz dCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBBZGFt IEphY2tzb24gPGFqYXhAcmVkaGF0LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jIHwgMjIgKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfc3ByaXRlLmMgIHwgNzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t Cj4gIDIgZmlsZXMgY2hhbmdlZCwgOTEgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA2MGZiZTNhLi5lYWVkZjkx IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0yNjgwLDYgKzI2 ODAsMTggQEAgaW50IHNrbF9mb3JtYXRfdG9fZm91cmNjKGludCBmb3JtYXQsIGJvb2wgcmdiX29y ZGVyLCBib29sIGFscGhhKQo+ICAJCQlyZXR1cm4gRFJNX0ZPUk1BVF9YQkdSMjEwMTAxMDsKPiAg CQllbHNlCj4gIAkJCXJldHVybiBEUk1fRk9STUFUX1hSR0IyMTAxMDEwOwo+ICsJY2FzZSBQTEFO RV9DVExfRk9STUFUX1hSR0JfMTYxNjE2MTZGOgo+ICsJCWlmIChyZ2Jfb3JkZXIpIHsKPiArCQkJ aWYgKGFscGhhKQo+ICsJCQkJcmV0dXJuIERSTV9GT1JNQVRfQUJHUjE2MTYxNjE2RjsKPiArCQkJ ZWxzZQo+ICsJCQkJcmV0dXJuIERSTV9GT1JNQVRfWEJHUjE2MTYxNjE2RjsKPiArCQl9IGVsc2Ug ewo+ICsJCQlpZiAoYWxwaGEpCj4gKwkJCQlyZXR1cm4gRFJNX0ZPUk1BVF9BUkdCMTYxNjE2MTZG Owo+ICsJCQllbHNlCj4gKwkJCQlyZXR1cm4gRFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGOwo+ICsJ CX0KPiAgCX0KPiAgfQo+ICAKPiBAQCAtMzU3NSw2ICszNTg3LDEyIEBAIHN0YXRpYyB1MzIgc2ts X3BsYW5lX2N0bF9mb3JtYXQodTMyIHBpeGVsX2Zvcm1hdCkKPiAgCQlyZXR1cm4gUExBTkVfQ1RM X0ZPUk1BVF9YUkdCXzIxMDEwMTA7Cj4gIAljYXNlIERSTV9GT1JNQVRfWEJHUjIxMDEwMTA6Cj4g IAkJcmV0dXJuIFBMQU5FX0NUTF9PUkRFUl9SR0JYIHwgUExBTkVfQ1RMX0ZPUk1BVF9YUkdCXzIx MDEwMTA7Cj4gKwljYXNlIERSTV9GT1JNQVRfWEJHUjE2MTYxNjE2RjoKPiArCWNhc2UgRFJNX0ZP Uk1BVF9BQkdSMTYxNjE2MTZGOgo+ICsJCXJldHVybiBQTEFORV9DVExfRk9STUFUX1hSR0JfMTYx NjE2MTZGIHwgUExBTkVfQ1RMX09SREVSX1JHQlg7Cj4gKwljYXNlIERSTV9GT1JNQVRfWFJHQjE2 MTYxNjE2RjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9BUkdCMTYxNjE2MTZGOgo+ICsJCXJldHVybiBQ TEFORV9DVExfRk9STUFUX1hSR0JfMTYxNjE2MTZGOwo+ICAJY2FzZSBEUk1fRk9STUFUX1lVWVY6 Cj4gIAkJcmV0dXJuIFBMQU5FX0NUTF9GT1JNQVRfWVVWNDIyIHwgUExBTkVfQ1RMX1lVVjQyMl9Z VVlWOwo+ICAJY2FzZSBEUk1fRk9STUFUX1lWWVU6Cj4gQEAgLTUxNDMsNiArNTE2MSwxMCBAQCBz dGF0aWMgaW50IHNrbF91cGRhdGVfc2NhbGVyX3BsYW5lKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlLAo+ICAJY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4Ogo+ICAJY2FzZSBEUk1f Rk9STUFUX1hSR0IyMTAxMDEwOgo+ICAJY2FzZSBEUk1fRk9STUFUX1hCR1IyMTAxMDEwOgo+ICsJ Y2FzZSBEUk1fRk9STUFUX1hCR1IxNjE2MTYxNkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfQUJHUjE2 MTYxNjE2RjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9YUkdCMTYxNjE2MTZGOgo+ICsJY2FzZSBEUk1f Rk9STUFUX0FSR0IxNjE2MTYxNkY6Cj4gIAljYXNlIERSTV9GT1JNQVRfWVVZVjoKPiAgCWNhc2Ug RFJNX0ZPUk1BVF9ZVllVOgo+ICAJY2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfc3ByaXRlLmMKPiBpbmRleCA2MjI2NjlmLi5lMDA1NTlkIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBAQCAtMTUwOCw4ICsxNTA4LDYgQEAgc3RhdGljIGlu dCBza2xfcGxhbmVfY2hlY2tfZmIoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNf c3RhdGUsCj4gIAkJLyoKPiAgCQkgKiA5MC8yNzAgaXMgbm90IGFsbG93ZWQgd2l0aCBSR0I2NCAx NjoxNjoxNjoxNiBhbmQKPiAgCQkgKiBJbmRleGVkIDgtYml0LiBSR0IgMTYtYml0IDU6Njo1IGlz IGFsbG93ZWQgZ2VuMTEgb253YXJkcy4KPiAtCQkgKiBUQkQ6IEFkZCBSR0I2NCBjYXNlIG9uY2Ug aXRzIGFkZGVkIGluIHN1cHBvcnRlZCBmb3JtYXQKPiAtCQkgKiBsaXN0Lgo+ICAJCSAqLwo+ICAJ CXN3aXRjaCAoZmItPmZvcm1hdC0+Zm9ybWF0KSB7Cj4gIAkJY2FzZSBEUk1fRk9STUFUX1JHQjU2 NToKPiBAQCAtMTUxNyw2ICsxNTE1LDEwIEBAIHN0YXRpYyBpbnQgc2tsX3BsYW5lX2NoZWNrX2Zi KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJCQkJYnJlYWs7 Cj4gIAkJCS8qIGZhbGwgdGhyb3VnaCAqLwo+ICAJCWNhc2UgRFJNX0ZPUk1BVF9DODoKPiArCQlj YXNlIERSTV9GT1JNQVRfWFJHQjE2MTYxNjE2RjoKPiArCQljYXNlIERSTV9GT1JNQVRfWEJHUjE2 MTYxNjE2RjoKPiArCQljYXNlIERSTV9GT1JNQVRfQVJHQjE2MTYxNjE2RjoKPiArCQljYXNlIERS TV9GT1JNQVRfQUJHUjE2MTYxNjE2RjoKPiAgCQkJRFJNX0RFQlVHX0tNUygiVW5zdXBwb3J0ZWQg cGl4ZWwgZm9ybWF0ICVzIGZvciA5MC8yNzAhXG4iLAo+ICAJCQkJICAgICAgZHJtX2dldF9mb3Jt YXRfbmFtZShmYi0+Zm9ybWF0LT5mb3JtYXQsCj4gIAkJCQkJCQkgICZmb3JtYXRfbmFtZSkpOwo+ IEBAIC0xODM3LDYgKzE4MzksMzEgQEAgc3RhdGljIGNvbnN0IHVpbnQzMl90IGljbF9wbGFuZV9m b3JtYXRzW10gPSB7Cj4gIAlEUk1fRk9STUFUX1k0MTYsCj4gIH07Cj4gIAo+ICtzdGF0aWMgY29u c3QgdWludDMyX3QgaWNsX2hkcl9wbGFuZV9mb3JtYXRzW10gPSB7Cj4gKwlEUk1fRk9STUFUX0M4 LAo+ICsJRFJNX0ZPUk1BVF9SR0I1NjUsCj4gKwlEUk1fRk9STUFUX1hSR0I4ODg4LAo+ICsJRFJN X0ZPUk1BVF9YQkdSODg4OCwKPiArCURSTV9GT1JNQVRfQVJHQjg4ODgsCj4gKwlEUk1fRk9STUFU X0FCR1I4ODg4LAo+ICsJRFJNX0ZPUk1BVF9YUkdCMjEwMTAxMCwKPiArCURSTV9GT1JNQVRfWEJH UjIxMDEwMTAsCj4gKwlEUk1fRk9STUFUX1hSR0IxNjE2MTYxNkYsCj4gKwlEUk1fRk9STUFUX1hC R1IxNjE2MTYxNkYsCj4gKwlEUk1fRk9STUFUX0FSR0IxNjE2MTYxNkYsCj4gKwlEUk1fRk9STUFU X0FCR1IxNjE2MTYxNkYsCj4gKwlEUk1fRk9STUFUX1lVWVYsCj4gKwlEUk1fRk9STUFUX1lWWVUs Cj4gKwlEUk1fRk9STUFUX1VZVlksCj4gKwlEUk1fRk9STUFUX1ZZVVksCj4gKwlEUk1fRk9STUFU X1kyMTAsCj4gKwlEUk1fRk9STUFUX1kyMTIsCj4gKwlEUk1fRk9STUFUX1kyMTYsCj4gKwlEUk1f Rk9STUFUX1k0MTAsCj4gKwlEUk1fRk9STUFUX1k0MTIsCj4gKwlEUk1fRk9STUFUX1k0MTYsCj4g K307Cj4gKwo+ICBzdGF0aWMgY29uc3QgdTMyIHNrbF9wbGFuYXJfZm9ybWF0c1tdID0gewo+ICAJ RFJNX0ZPUk1BVF9DOCwKPiAgCURSTV9GT1JNQVRfUkdCNTY1LAo+IEBAIC0xODk3LDYgKzE5MjQs MzUgQEAgc3RhdGljIGNvbnN0IHVpbnQzMl90IGljbF9wbGFuYXJfZm9ybWF0c1tdID0gewo+ICAJ RFJNX0ZPUk1BVF9ZNDE2LAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0IHVpbnQzMl90IGljbF9o ZHJfcGxhbmFyX2Zvcm1hdHNbXSA9IHsKPiArCURSTV9GT1JNQVRfQzgsCj4gKwlEUk1fRk9STUFU X1JHQjU2NSwKPiArCURSTV9GT1JNQVRfWFJHQjg4ODgsCj4gKwlEUk1fRk9STUFUX1hCR1I4ODg4 LAo+ICsJRFJNX0ZPUk1BVF9BUkdCODg4OCwKPiArCURSTV9GT1JNQVRfQUJHUjg4ODgsCj4gKwlE Uk1fRk9STUFUX1hSR0IyMTAxMDEwLAo+ICsJRFJNX0ZPUk1BVF9YQkdSMjEwMTAxMCwKPiArCURS TV9GT1JNQVRfWFJHQjE2MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfWEJHUjE2MTYxNjE2RiwKPiAr CURSTV9GT1JNQVRfQVJHQjE2MTYxNjE2RiwKPiArCURSTV9GT1JNQVRfQUJHUjE2MTYxNjE2RiwK PiArCURSTV9GT1JNQVRfWVVZViwKPiArCURSTV9GT1JNQVRfWVZZVSwKPiArCURSTV9GT1JNQVRf VVlWWSwKPiArCURSTV9GT1JNQVRfVllVWSwKPiArCURSTV9GT1JNQVRfTlYxMiwKPiArCURSTV9G T1JNQVRfUDAxMCwKPiArCURSTV9GT1JNQVRfUDAxMiwKPiArCURSTV9GT1JNQVRfUDAxNiwKPiAr CURSTV9GT1JNQVRfWTIxMCwKPiArCURSTV9GT1JNQVRfWTIxMiwKPiArCURSTV9GT1JNQVRfWTIx NiwKPiArCURSTV9GT1JNQVRfWTQxMCwKPiArCURSTV9GT1JNQVRfWTQxMiwKPiArCURSTV9GT1JN QVRfWTQxNiwKPiArfTsKPiArCj4gIHN0YXRpYyBjb25zdCB1NjQgc2tsX3BsYW5lX2Zvcm1hdF9t b2RpZmllcnNfbm9jY3NbXSA9IHsKPiAgCUk5MTVfRk9STUFUX01PRF9ZZl9USUxFRCwKPiAgCUk5 MTVfRk9STUFUX01PRF9ZX1RJTEVELAo+IEBAIC0yMDQ5LDYgKzIxMDUsMTAgQEAgc3RhdGljIGJv b2wgc2tsX3BsYW5lX2Zvcm1hdF9tb2Rfc3VwcG9ydGVkKHN0cnVjdCBkcm1fcGxhbmUgKl9wbGFu ZSwKPiAgCQkJcmV0dXJuIHRydWU7Cj4gIAkJLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIERS TV9GT1JNQVRfQzg6Cj4gKwljYXNlIERSTV9GT1JNQVRfWEJHUjE2MTYxNjE2RjoKPiArCWNhc2Ug RFJNX0ZPUk1BVF9BQkdSMTYxNjE2MTZGOgo+ICsJY2FzZSBEUk1fRk9STUFUX1hSR0IxNjE2MTYx NkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfQVJHQjE2MTYxNjE2RjoKPiAgCQlpZiAobW9kaWZpZXIg PT0gRFJNX0ZPUk1BVF9NT0RfTElORUFSIHx8Cj4gIAkJICAgIG1vZGlmaWVyID09IEk5MTVfRk9S TUFUX01PRF9YX1RJTEVEIHx8Cj4gIAkJICAgIG1vZGlmaWVyID09IEk5MTVfRk9STUFUX01PRF9Z X1RJTEVEKQo+IEBAIC0yMTg1LDcgKzIyNDUsMTAgQEAgc2tsX3VuaXZlcnNhbF9wbGFuZV9jcmVh dGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCXBsYW5lLT51cGRhdGVf c2xhdmUgPSBpY2xfdXBkYXRlX3NsYXZlOwo+ICAKPiAgCWlmIChza2xfcGxhbmVfaGFzX3BsYW5h cihkZXZfcHJpdiwgcGlwZSwgcGxhbmVfaWQpKSB7Cj4gLQkJaWYgKElOVEVMX0dFTihkZXZfcHJp dikgPj0gMTEpIHsKPiArCQlpZiAoaWNsX2lzX2hkcl9wbGFuZShkZXZfcHJpdiwgcGxhbmVfaWQp KSB7Cj4gKwkJCWZvcm1hdHMgPSBpY2xfaGRyX3BsYW5hcl9mb3JtYXRzOwo+ICsJCQludW1fZm9y bWF0cyA9IEFSUkFZX1NJWkUoaWNsX2hkcl9wbGFuYXJfZm9ybWF0cyk7Cj4gKwkJfSBlbHNlIGlm IChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKSB7Cj4gIAkJCWZvcm1hdHMgPSBpY2xfcGxhbmFy X2Zvcm1hdHM7Cj4gIAkJCW51bV9mb3JtYXRzID0gQVJSQVlfU0laRShpY2xfcGxhbmFyX2Zvcm1h dHMpOwo+ICAJCX0gZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA9PSAxMCB8fCBJU19HRU1J TklMQUtFKGRldl9wcml2KSkgewo+IEBAIC0yMTk1LDYgKzIyNTgsOSBAQCBza2xfdW5pdmVyc2Fs X3BsYW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCWZv cm1hdHMgPSBza2xfcGxhbmFyX2Zvcm1hdHM7Cj4gIAkJCW51bV9mb3JtYXRzID0gQVJSQVlfU0la RShza2xfcGxhbmFyX2Zvcm1hdHMpOwo+ICAJCX0KPiArCX0gZWxzZSBpZiAoaWNsX2lzX2hkcl9w bGFuZShkZXZfcHJpdiwgcGxhbmVfaWQpKSB7Cj4gKwkJZm9ybWF0cyA9IGljbF9oZHJfcGxhbmVf Zm9ybWF0czsKPiArCQludW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoaWNsX2hkcl9wbGFuZV9mb3Jt YXRzKTsKClRoaXMgaHVuayBpcyB1bnJlYWNoYWJsZSBiZWNhdXNlIGlzX2hkcl9wbGFuZSBpcyBh IHN1YnNldCBvZiBza2xfcGxhbmVfaGFzX3BsYW5hciwgSSB3aWxsIGRyb3AgaXQgYW5kIGNvbW1p dC4gOikKClRoYW5rcywKCn5NYWFydGVuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWw=