From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Bingham Subject: Re: [PATCH v6 17/18] drm: rcar-du: vsp: Extract framebuffer (un)mapping to separate functions Date: Wed, 13 Mar 2019 11:54:18 +0000 Message-ID: References: <20190313000532.7087-1-laurent.pinchart+renesas@ideasonboard.com> <20190313000532.7087-18-laurent.pinchart+renesas@ideasonboard.com> Reply-To: kieran.bingham@ideasonboard.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D5FD6E0A6 for ; Wed, 13 Mar 2019 11:54:23 +0000 (UTC) In-Reply-To: <20190313000532.7087-18-laurent.pinchart+renesas@ideasonboard.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Liviu Dudau , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgTGF1cmVudCwKCk9uIDEzLzAzLzIwMTkgMDA6MDUsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6 Cj4gVGhlIHJjYXJfZHVfdnNwX3BsYW5lX3ByZXBhcmVfZmIoKSBhbmQgcmNhcl9kdV92c3BfcGxh bmVfY2xlYW51cF9mYigpCj4gZnVuY3Rpb25zIGltcGxlbWVudCB0aGUgRFJNIHBsYW5lIC5wcmVw YXJlX2ZiKCkgYW5kIC5jbGVhbnVwX2ZiKCkKPiBvcGVyYXRpb25zLiBUaGV5IG1hcCBhbmQgdW5t YXAgdGhlIGZyYW1lYnVmZmVyIHRvL2Zyb20gdGhlIFZTUAo+IGludGVybmFsbHksIHdoaWNoIHdp bGwgYmUgdXNlZnVsIHRvIGltcGxlbWVudCB3cml0ZWJhY2sgc3VwcG9ydC4gU3BsaXQKPiB0aGUg bWFwcGluZyBhbmQgdW5tYXBwaW5nIG91dCB0byBzZXBhcmF0ZSBmdW5jdGlvbnMuCj4gCj4gU2ln bmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlk ZWFzb25ib2FyZC5jb20+CgpMb29rcyBnb29kIHRvIG1lLCBKdXN0IGEgcmVmYWN0b3IgYW5kIG5v dGhpbmcgY29udHJvdmVyc2lhbC4KClJldmlld2VkLWJ5OiBLaWVyYW4gQmluZ2hhbSA8a2llcmFu LmJpbmdoYW0rcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgoKCgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vcmNhci1kdS9yY2FyX2R1X3ZzcC5jIHwgNjggKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfdnNwLmggfCAxNyArKysrKysr Cj4gIDIgZmlsZXMgY2hhbmdlZCwgNTggaW5zZXJ0aW9ucygrKSwgMjcgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfdnNwLmMgYi9k cml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X3ZzcC5jCj4gaW5kZXggMjlhMDhmN2IwNzYx Li4wODA2YTY5YzQ2NzkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNh cl9kdV92c3AuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfdnNwLmMK PiBAQCAtMTczLDI2ICsxNzMsMTYgQEAgc3RhdGljIHZvaWQgcmNhcl9kdV92c3BfcGxhbmVfc2V0 dXAoc3RydWN0IHJjYXJfZHVfdnNwX3BsYW5lICpwbGFuZSkKPiAgCQkJICAgICAgcGxhbmUtPmlu ZGV4LCAmY2ZnKTsKPiAgfQo+ICAKPiAtc3RhdGljIGludCByY2FyX2R1X3ZzcF9wbGFuZV9wcmVw YXJlX2ZiKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+IC0JCQkJCXN0cnVjdCBkcm1fcGxhbmVf c3RhdGUgKnN0YXRlKQo+ICtpbnQgcmNhcl9kdV92c3BfbWFwX2ZiKHN0cnVjdCByY2FyX2R1X3Zz cCAqdnNwLCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiArCQkgICAgICAgc3RydWN0IHNn X3RhYmxlIHNnX3RhYmxlc1szXSkKPiAgewo+IC0Jc3RydWN0IHJjYXJfZHVfdnNwX3BsYW5lX3N0 YXRlICpyc3RhdGUgPSB0b19yY2FyX3ZzcF9wbGFuZV9zdGF0ZShzdGF0ZSk7Cj4gLQlzdHJ1Y3Qg cmNhcl9kdV92c3AgKnZzcCA9IHRvX3JjYXJfdnNwX3BsYW5lKHBsYW5lKS0+dnNwOwo+ICAJc3Ry dWN0IHJjYXJfZHVfZGV2aWNlICpyY2R1ID0gdnNwLT5kZXY7Cj4gIAl1bnNpZ25lZCBpbnQgaTsK PiAgCWludCByZXQ7Cj4gIAo+IC0JLyoKPiAtCSAqIFRoZXJlJ3Mgbm8gbmVlZCB0byBwcmVwYXJl IChhbmQgdW5wcmVwYXJlKSB0aGUgZnJhbWVidWZmZXIgd2hlbiB0aGUKPiAtCSAqIHBsYW5lIGlz IG5vdCB2aXNpYmxlLCBhcyBpdCB3aWxsIG5vdCBiZSBkaXNwbGF5ZWQuCj4gLQkgKi8KPiAtCWlm ICghc3RhdGUtPnZpc2libGUpCj4gLQkJcmV0dXJuIDA7Cj4gLQo+IC0JZm9yIChpID0gMDsgaSA8 IHJzdGF0ZS0+Zm9ybWF0LT5wbGFuZXM7ICsraSkgewo+IC0JCXN0cnVjdCBkcm1fZ2VtX2NtYV9v YmplY3QgKmdlbSA9Cj4gLQkJCWRybV9mYl9jbWFfZ2V0X2dlbV9vYmooc3RhdGUtPmZiLCBpKTsK PiAtCQlzdHJ1Y3Qgc2dfdGFibGUgKnNndCA9ICZyc3RhdGUtPnNnX3RhYmxlc1tpXTsKPiArCWZv ciAoaSA9IDA7IGkgPCBmYi0+Zm9ybWF0LT5udW1fcGxhbmVzOyArK2kpIHsKPiArCQlzdHJ1Y3Qg ZHJtX2dlbV9jbWFfb2JqZWN0ICpnZW0gPSBkcm1fZmJfY21hX2dldF9nZW1fb2JqKGZiLCBpKTsK PiArCQlzdHJ1Y3Qgc2dfdGFibGUgKnNndCA9ICZzZ190YWJsZXNbaV07Cj4gIAo+ICAJCXJldCA9 IGRtYV9nZXRfc2d0YWJsZShyY2R1LT5kZXYsIHNndCwgZ2VtLT52YWRkciwgZ2VtLT5wYWRkciwK PiAgCQkJCSAgICAgIGdlbS0+YmFzZS5zaXplKTsKPiBAQCAtMjA3LDE1ICsxOTcsMTEgQEAgc3Rh dGljIGludCByY2FyX2R1X3ZzcF9wbGFuZV9wcmVwYXJlX2ZiKHN0cnVjdCBkcm1fcGxhbmUgKnBs YW5lLAo+ICAJCX0KPiAgCX0KPiAgCj4gLQlyZXQgPSBkcm1fZ2VtX2ZiX3ByZXBhcmVfZmIocGxh bmUsIHN0YXRlKTsKPiAtCWlmIChyZXQpCj4gLQkJZ290byBmYWlsOwo+IC0KPiAgCXJldHVybiAw Owo+ICAKPiAgZmFpbDoKPiAgCXdoaWxlIChpLS0pIHsKPiAtCQlzdHJ1Y3Qgc2dfdGFibGUgKnNn dCA9ICZyc3RhdGUtPnNnX3RhYmxlc1tpXTsKPiArCQlzdHJ1Y3Qgc2dfdGFibGUgKnNndCA9ICZz Z190YWJsZXNbaV07Cj4gIAo+ICAJCXZzcDFfZHVfdW5tYXBfc2codnNwLT52c3AsIHNndCk7Cj4g IAkJc2dfZnJlZV90YWJsZShzZ3QpOwo+IEBAIC0yMjQsMjIgKzIxMCw1MCBAQCBzdGF0aWMgaW50 IHJjYXJfZHVfdnNwX3BsYW5lX3ByZXBhcmVfZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4g IAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IHJjYXJfZHVfdnNwX3BsYW5lX3By ZXBhcmVfZmIoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gKwkJCQkJc3RydWN0IGRybV9wbGFu ZV9zdGF0ZSAqc3RhdGUpCj4gK3sKPiArCXN0cnVjdCByY2FyX2R1X3ZzcF9wbGFuZV9zdGF0ZSAq cnN0YXRlID0gdG9fcmNhcl92c3BfcGxhbmVfc3RhdGUoc3RhdGUpOwo+ICsJc3RydWN0IHJjYXJf ZHVfdnNwICp2c3AgPSB0b19yY2FyX3ZzcF9wbGFuZShwbGFuZSktPnZzcDsKPiArCWludCByZXQ7 Cj4gKwo+ICsJLyoKPiArCSAqIFRoZXJlJ3Mgbm8gbmVlZCB0byBwcmVwYXJlIChhbmQgdW5wcmVw YXJlKSB0aGUgZnJhbWVidWZmZXIgd2hlbiB0aGUKPiArCSAqIHBsYW5lIGlzIG5vdCB2aXNpYmxl LCBhcyBpdCB3aWxsIG5vdCBiZSBkaXNwbGF5ZWQuCj4gKwkgKi8KPiArCWlmICghc3RhdGUtPnZp c2libGUpCj4gKwkJcmV0dXJuIDA7CgpXaGF0IGFib3V0IHdyaXRlYmFjaz8KCi0gTmV2ZXIgbWlu ZCAtIHRoYXQgZG9lc24ndCBjYWxsIHRocm91Z2ggaGVyZS4KCj4gKwo+ICsJcmV0ID0gcmNhcl9k dV92c3BfbWFwX2ZiKHZzcCwgc3RhdGUtPmZiLCByc3RhdGUtPnNnX3RhYmxlcyk7Cj4gKwlpZiAo cmV0IDwgMCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCXJldHVybiBkcm1fZ2VtX2ZiX3ByZXBh cmVfZmIocGxhbmUsIHN0YXRlKTsKPiArfQo+ICsKPiArdm9pZCByY2FyX2R1X3ZzcF91bm1hcF9m YihzdHJ1Y3QgcmNhcl9kdV92c3AgKnZzcCwgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4g KwkJCSAgc3RydWN0IHNnX3RhYmxlIHNnX3RhYmxlc1szXSkKPiArewo+ICsJdW5zaWduZWQgaW50 IGk7Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IGZiLT5mb3JtYXQtPm51bV9wbGFuZXM7ICsraSkg ewo+ICsJCXN0cnVjdCBzZ190YWJsZSAqc2d0ID0gJnNnX3RhYmxlc1tpXTsKPiArCj4gKwkJdnNw MV9kdV91bm1hcF9zZyh2c3AtPnZzcCwgc2d0KTsKPiArCQlzZ19mcmVlX3RhYmxlKHNndCk7Cj4g Kwl9Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIHJjYXJfZHVfdnNwX3BsYW5lX2NsZWFudXBfZmIo c3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJCQkJIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUg KnN0YXRlKQo+ICB7Cj4gIAlzdHJ1Y3QgcmNhcl9kdV92c3BfcGxhbmVfc3RhdGUgKnJzdGF0ZSA9 IHRvX3JjYXJfdnNwX3BsYW5lX3N0YXRlKHN0YXRlKTsKPiAgCXN0cnVjdCByY2FyX2R1X3ZzcCAq dnNwID0gdG9fcmNhcl92c3BfcGxhbmUocGxhbmUpLT52c3A7Cj4gLQl1bnNpZ25lZCBpbnQgaTsK PiAgCj4gIAlpZiAoIXN0YXRlLT52aXNpYmxlKQo+ICAJCXJldHVybjsKPiAgCj4gLQlmb3IgKGkg PSAwOyBpIDwgcnN0YXRlLT5mb3JtYXQtPnBsYW5lczsgKytpKSB7Cj4gLQkJc3RydWN0IHNnX3Rh YmxlICpzZ3QgPSAmcnN0YXRlLT5zZ190YWJsZXNbaV07Cj4gLQo+IC0JCXZzcDFfZHVfdW5tYXBf c2codnNwLT52c3AsIHNndCk7Cj4gLQkJc2dfZnJlZV90YWJsZShzZ3QpOwo+IC0JfQo+ICsJcmNh cl9kdV92c3BfdW5tYXBfZmIodnNwLCBzdGF0ZS0+ZmIsIHJzdGF0ZS0+c2dfdGFibGVzKTsKPiAg fQo+ICAKPiAgc3RhdGljIGludCByY2FyX2R1X3ZzcF9wbGFuZV9hdG9taWNfY2hlY2soc3RydWN0 IGRybV9wbGFuZSAqcGxhbmUsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1 L3JjYXJfZHVfdnNwLmggYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X3ZzcC5oCj4g aW5kZXggZGIyMzIwMzdmMjRhLi45YjQ3MjQxNTkzNzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2Fy LWR1L3JjYXJfZHVfdnNwLmgKPiBAQCAtMTIsOCArMTIsMTAgQEAKPiAgCj4gICNpbmNsdWRlIDxk cm0vZHJtX3BsYW5lLmg+Cj4gIAo+ICtzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyOwo+ICBzdHJ1Y3Qg cmNhcl9kdV9mb3JtYXRfaW5mbzsKPiAgc3RydWN0IHJjYXJfZHVfdnNwOwo+ICtzdHJ1Y3Qgc2df dGFibGU7Cj4gIAo+ICBzdHJ1Y3QgcmNhcl9kdV92c3BfcGxhbmUgewo+ICAJc3RydWN0IGRybV9w bGFuZSBwbGFuZTsKPiBAQCAtNjAsNiArNjIsMTAgQEAgdm9pZCByY2FyX2R1X3ZzcF9lbmFibGUo c3RydWN0IHJjYXJfZHVfY3J0YyAqY3J0Yyk7Cj4gIHZvaWQgcmNhcl9kdV92c3BfZGlzYWJsZShz dHJ1Y3QgcmNhcl9kdV9jcnRjICpjcnRjKTsKPiAgdm9pZCByY2FyX2R1X3ZzcF9hdG9taWNfYmVn aW4oc3RydWN0IHJjYXJfZHVfY3J0YyAqY3J0Yyk7Cj4gIHZvaWQgcmNhcl9kdV92c3BfYXRvbWlj X2ZsdXNoKHN0cnVjdCByY2FyX2R1X2NydGMgKmNydGMpOwo+ICtpbnQgcmNhcl9kdV92c3BfbWFw X2ZiKHN0cnVjdCByY2FyX2R1X3ZzcCAqdnNwLCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwK PiArCQkgICAgICAgc3RydWN0IHNnX3RhYmxlIHNnX3RhYmxlc1szXSk7Cj4gK3ZvaWQgcmNhcl9k dV92c3BfdW5tYXBfZmIoc3RydWN0IHJjYXJfZHVfdnNwICp2c3AsIHN0cnVjdCBkcm1fZnJhbWVi dWZmZXIgKmZiLAo+ICsJCQkgIHN0cnVjdCBzZ190YWJsZSBzZ190YWJsZXNbM10pOwo+ICAjZWxz ZQo+ICBzdGF0aWMgaW5saW5lIGludCByY2FyX2R1X3ZzcF9pbml0KHN0cnVjdCByY2FyX2R1X3Zz cCAqdnNwLAo+ICAJCQkJICAgc3RydWN0IGRldmljZV9ub2RlICpucCwKPiBAQCAtNzEsNiArNzcs MTcgQEAgc3RhdGljIGlubGluZSB2b2lkIHJjYXJfZHVfdnNwX2VuYWJsZShzdHJ1Y3QgcmNhcl9k dV9jcnRjICpjcnRjKSB7IH07Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCByY2FyX2R1X3ZzcF9kaXNh YmxlKHN0cnVjdCByY2FyX2R1X2NydGMgKmNydGMpIHsgfTsKPiAgc3RhdGljIGlubGluZSB2b2lk IHJjYXJfZHVfdnNwX2F0b21pY19iZWdpbihzdHJ1Y3QgcmNhcl9kdV9jcnRjICpjcnRjKSB7IH07 Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCByY2FyX2R1X3ZzcF9hdG9taWNfZmx1c2goc3RydWN0IHJj YXJfZHVfY3J0YyAqY3J0YykgeyB9Owo+ICtzdGF0aWMgaW5saW5lIGludCByY2FyX2R1X3ZzcF9t YXBfZmIoc3RydWN0IHJjYXJfZHVfdnNwICp2c3AsCj4gKwkJCQkgICAgIHN0cnVjdCBkcm1fZnJh bWVidWZmZXIgKmZiLAo+ICsJCQkJICAgICBzdHJ1Y3Qgc2dfdGFibGUgc2dfdGFibGVzWzNdKQo+ ICt7Cj4gKwlyZXR1cm4gLUVOWElPOwo+ICt9Cj4gK3N0YXRpYyBpbmxpbmUgdm9pZCByY2FyX2R1 X3ZzcF91bm1hcF9mYihzdHJ1Y3QgcmNhcl9kdV92c3AgKnZzcCwKPiArCQkJCQlzdHJ1Y3QgZHJt X2ZyYW1lYnVmZmVyICpmYiwKPiArCQkJCQlzdHJ1Y3Qgc2dfdGFibGUgc2dfdGFibGVzWzNdKQo+ ICt7Cj4gK30KPiAgI2VuZGlmCj4gIAo+ICAjZW5kaWYgLyogX19SQ0FSX0RVX1ZTUF9IX18gKi8K PiAKCi0tIApSZWdhcmRzCi0tCktpZXJhbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWw=