From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51CBFC33CA1 for ; Mon, 20 Jan 2020 17:09:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F2D022314 for ; Mon, 20 Jan 2020 17:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F2D022314 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 59E0B6EA1C; Mon, 20 Jan 2020 17:09:14 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 0458B6EA1C for ; Mon, 20 Jan 2020 17:09:12 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78A5531B; Mon, 20 Jan 2020 09:09:12 -0800 (PST) Received: from [10.1.194.52] (e112269-lin.cambridge.arm.com [10.1.194.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3FCC83F68E; Mon, 20 Jan 2020 09:09:10 -0800 (PST) Subject: Re: [PATCH v3 4/7] drm/panfrost: Add support for multiple regulators To: Mark Brown References: <20200114071602.47627-1-drinkcat@chromium.org> <20200114071602.47627-5-drinkcat@chromium.org> <7e82cac2-efbf-806b-8c2e-04dbd0482b50@arm.com> <20200120170343.GE6852@sirena.org.uk> From: Steven Price Message-ID: Date: Mon, 20 Jan 2020 17:09:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200120170343.GE6852@sirena.org.uk> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Nicolas Boichat , Tomeu Vizoso , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Liam Girdwood , Rob Herring , linux-mediatek@lists.infradead.org, Alyssa Rosenzweig , hsinyi@chromium.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 20/01/2020 17:03, Mark Brown wrote: > On Mon, Jan 20, 2020 at 02:43:10PM +0000, Steven Price wrote: > >> From discussions offline, I think I've come round to the view that >> having a "soft PDC" in device tree isn't the right solution. Device tree >> should be describing the hardware and that isn't actually a hardware >> component. > > You can use an implementation like that separately to it being in the > device tree, it is perfectly possible to instantiate devices that have > no representation at all in device tree based on other things that are > there like board or SoC information, or as subdevices of things that are > there. Yes - and I may yet implement a "soft PDC" device if this turns out to be more than a 'quirk' for a very small number of device. But like you say - it doesn't need to be (and shouldn't be) in the actual device tree. For now though I think the code Nicolas has written works well enough and it's only really worth 'fixing' if we end up with too many 'quirky' devices. Steve _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel