From: Ralph Campbell <rcampbell@nvidia.com>
To: "Christoph Hellwig" <hch@lst.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Dan Williams" <dan.j.williams@intel.com>,
"Bharata B Rao" <bharata@linux.ibm.com>,
"Christian König" <christian.koenig@amd.com>,
"Ben Skeggs" <bskeggs@redhat.com>
Cc: kvm-ppc@vger.kernel.org, nouveau@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
Jerome Glisse <jglisse@redhat.com>,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] memremap: add an owner field to struct dev_pagemap
Date: Mon, 16 Mar 2020 13:55:40 -0700 [thread overview]
Message-ID: <afaadfde-94b1-5b7d-802b-812b0b448b78@nvidia.com> (raw)
In-Reply-To: <20200316193216.920734-2-hch@lst.de>
On 3/16/20 12:32 PM, Christoph Hellwig wrote:
> Add a new opaque owner field to struct dev_pagemap, which will allow
> the hmm and migrate_vma code to identify who owns ZONE_DEVICE memory,
> and refuse to work on mappings not owned by the calling entity.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
This looks like a reasonable approach to take.
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
> ---
> arch/powerpc/kvm/book3s_hv_uvmem.c | 2 ++
> drivers/gpu/drm/nouveau/nouveau_dmem.c | 1 +
> include/linux/memremap.h | 4 ++++
> mm/memremap.c | 4 ++++
> 4 files changed, 11 insertions(+)
>
> diff --git a/arch/powerpc/kvm/book3s_hv_uvmem.c b/arch/powerpc/kvm/book3s_hv_uvmem.c
> index 79b1202b1c62..67fefb03b9b7 100644
> --- a/arch/powerpc/kvm/book3s_hv_uvmem.c
> +++ b/arch/powerpc/kvm/book3s_hv_uvmem.c
> @@ -779,6 +779,8 @@ int kvmppc_uvmem_init(void)
> kvmppc_uvmem_pgmap.type = MEMORY_DEVICE_PRIVATE;
> kvmppc_uvmem_pgmap.res = *res;
> kvmppc_uvmem_pgmap.ops = &kvmppc_uvmem_ops;
> + /* just one global instance: */
> + kvmppc_uvmem_pgmap.owner = &kvmppc_uvmem_pgmap;
> addr = memremap_pages(&kvmppc_uvmem_pgmap, NUMA_NO_NODE);
> if (IS_ERR(addr)) {
> ret = PTR_ERR(addr);
> diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c
> index 0ad5d87b5a8e..a4682272586e 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c
> @@ -526,6 +526,7 @@ nouveau_dmem_init(struct nouveau_drm *drm)
> drm->dmem->pagemap.type = MEMORY_DEVICE_PRIVATE;
> drm->dmem->pagemap.res = *res;
> drm->dmem->pagemap.ops = &nouveau_dmem_pagemap_ops;
> + drm->dmem->pagemap.owner = drm->dev;
> if (IS_ERR(devm_memremap_pages(device, &drm->dmem->pagemap)))
> goto out_free;
>
> diff --git a/include/linux/memremap.h b/include/linux/memremap.h
> index 6fefb09af7c3..60d97e8fd3c0 100644
> --- a/include/linux/memremap.h
> +++ b/include/linux/memremap.h
> @@ -103,6 +103,9 @@ struct dev_pagemap_ops {
> * @type: memory type: see MEMORY_* in memory_hotplug.h
> * @flags: PGMAP_* flags to specify defailed behavior
> * @ops: method table
> + * @owner: an opaque pointer identifying the entity that manages this
> + * instance. Used by various helpers to make sure that no
> + * foreign ZONE_DEVICE memory is accessed.
> */
> struct dev_pagemap {
> struct vmem_altmap altmap;
> @@ -113,6 +116,7 @@ struct dev_pagemap {
> enum memory_type type;
> unsigned int flags;
> const struct dev_pagemap_ops *ops;
> + void *owner;
> };
>
> static inline struct vmem_altmap *pgmap_altmap(struct dev_pagemap *pgmap)
> diff --git a/mm/memremap.c b/mm/memremap.c
> index 09b5b7adc773..9b2c97ceb775 100644
> --- a/mm/memremap.c
> +++ b/mm/memremap.c
> @@ -181,6 +181,10 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid)
> WARN(1, "Missing migrate_to_ram method\n");
> return ERR_PTR(-EINVAL);
> }
> + if (!pgmap->owner) {
> + WARN(1, "Missing owner\n");
> + return ERR_PTR(-EINVAL);
> + }
> break;
> case MEMORY_DEVICE_FS_DAX:
> if (!IS_ENABLED(CONFIG_ZONE_DEVICE) ||
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next parent reply other threads:[~2020-03-16 20:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200316193216.920734-1-hch@lst.de>
[not found] ` <20200316193216.920734-2-hch@lst.de>
2020-03-16 20:55 ` Ralph Campbell [this message]
[not found] ` <20200316193216.920734-3-hch@lst.de>
2020-03-16 21:43 ` [PATCH 2/4] mm: handle multiple owners of device private pages in migrate_vma Ralph Campbell
[not found] ` <20200316193216.920734-4-hch@lst.de>
2020-03-16 19:59 ` [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Jason Gunthorpe
2020-03-16 22:49 ` Ralph Campbell
2020-03-17 12:15 ` Jason Gunthorpe
[not found] ` <20200317122445.GA11662@lst.de>
[not found] ` <20200317122813.GA11866@lst.de>
2020-03-17 12:47 ` Jason Gunthorpe
[not found] ` <20200317125955.GA12847@lst.de>
2020-03-17 17:32 ` Jason Gunthorpe
2020-03-17 23:14 ` Ralph Campbell
2020-03-19 18:17 ` Jason Gunthorpe
2020-03-19 22:56 ` Ralph Campbell
2020-03-20 0:03 ` Jason Gunthorpe
2020-03-20 0:14 ` Jason Gunthorpe
2020-03-20 1:33 ` Ralph Campbell
2020-03-20 12:58 ` Jason Gunthorpe
[not found] ` <20200317073454.GA5843@lst.de>
2020-03-17 22:43 ` Ralph Campbell
2020-03-19 0:28 ` ensure device private pages have an owner v2 Jason Gunthorpe
[not found] ` <20200319071633.GA32522@lst.de>
2020-03-19 11:50 ` Jason Gunthorpe
2020-03-19 18:50 ` Jason Gunthorpe
[not found] ` <20200316193216.920734-5-hch@lst.de>
2020-03-16 19:49 ` [PATCH 4/4] mm: check the device private page owner in hmm_range_fault Jason Gunthorpe
2020-03-16 23:11 ` Ralph Campbell
2020-03-20 13:41 ` Jason Gunthorpe
[not found] ` <20200321082236.GB28613@lst.de>
2020-03-21 12:38 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afaadfde-94b1-5b7d-802b-812b0b448b78@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).