From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD0FC433B4 for ; Sat, 15 May 2021 16:33:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B76861185 for ; Sat, 15 May 2021 16:33:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B76861185 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D9326E418; Sat, 15 May 2021 16:33:00 +0000 (UTC) Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by gabe.freedesktop.org (Postfix) with ESMTP id E5F5A6E418 for ; Sat, 15 May 2021 16:32:59 +0000 (UTC) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 93FDE92009C; Sat, 15 May 2021 18:32:58 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 8C64692009B; Sat, 15 May 2021 18:32:58 +0200 (CEST) Date: Sat, 15 May 2021 18:32:58 +0200 (CEST) From: "Maciej W. Rozycki" To: Tetsuo Handa Subject: Re: [PATCH v2] tty: vt: always invoke vc->vc_sw->con_resize callback In-Reply-To: Message-ID: References: <0000000000006bbd0c05c14f1b09@google.com> <6e21483c-06f6-404b-4018-e00ee85c456c@i-love.sakura.ne.jp> <87d928e4-b2b9-ad30-f3f0-1dfb8e4e03ed@i-love.sakura.ne.jp> <05acdda8-dc1c-5119-4326-96eed24bea0c@i-love.sakura.ne.jp> <97f1d292-c3a8-f4d6-0651-b4f5571ecb72@i-love.sakura.ne.jp> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Fbdev development list , Jiri Slaby , Bartlomiej Zolnierkiewicz , Jani Nikula , Greg Kroah-Hartman , syzkaller-bugs , Linux Kernel Mailing List , dri-devel , Colin King , Linus Torvalds , syzbot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 15 May 2021, Maciej W. Rozycki wrote: > On Sat, 15 May 2021, Tetsuo Handa wrote: > > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > > index 3406067985b1..22bb3892f6bd 100644 > > --- a/drivers/video/fbdev/core/fbcon.c > > +++ b/drivers/video/fbdev/core/fbcon.c > > @@ -2019,7 +2019,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width, > > return -EINVAL; > > > > pr_debug("resize now %ix%i\n", var.xres, var.yres); > > - if (con_is_visible(vc)) { > > + if (con_is_visible(vc) && vc->vc_mode == KD_TEXT) { > > var.activate = FB_ACTIVATE_NOW | > > FB_ACTIVATE_FORCE; > > fb_set_var(info, &var); > > LGTM, although I'll yet try to verify it with hardware. But it'll have > to wait another week or so as I'm currently away from my lab and this > requires physical presence. NB I suggest that you request your change to be backported, i.e. post v3 with: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org # v2.6.12+ Maciej