From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90439C4BA3B for ; Thu, 27 Feb 2020 13:00:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 678A62469A for ; Thu, 27 Feb 2020 13:00:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JvjpWo76" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 678A62469A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 771C26ECB5; Thu, 27 Feb 2020 12:59:42 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id E02366EC99 for ; Thu, 27 Feb 2020 12:24:01 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id c84so3174271wme.4 for ; Thu, 27 Feb 2020 04:24:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=jp5suxB8PwckKllUEmHtSKALSA4mXRMI2T39pt6o9kw=; b=JvjpWo76pRAiBmY2lyeQmsaLrQZ4mkX9aCLLvAw/4cQmfro8qn2QJbyZIf4LlQxDSb OGHOPDhDLa3UhXV8oOX/fTg8Oxa7UXEqa+zLOSMI5UZgDI+tdhAZv5Y34MVIUXSpPW6Y ZAe754fYrRw17tvJUjByXRCnvQSyu0QxiLB+nC+UzDu/zLgeutxmNWB73QPlUFofVdxF yaSWMCcCyfgMrsk42vUVvuZ1dC+eDsJjrgw/loMlqHXOAmvUtpHW/WtVjn2sGQ2b121M FVmudIXCXLJ4KoSzSu62z3icEDZSxz39TLkoiyG0KuKQ13di6ysdPUVEaC//zUno9dNX EcZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=jp5suxB8PwckKllUEmHtSKALSA4mXRMI2T39pt6o9kw=; b=IbQe1ekC7U9RXEXvZIWWW/U7yzA1jIrTuNzAJn/hk0KCua+hqdO2NmhA+NeRFOL7FO 2FAtuQTwqp1Lj9rmPrOrrcDX5mlcA2nhxe0qcd1k1NSwKPPLhFHAx6FXs95gcLngn/Mg RJ+FmxJCZmPHmFgWernZw4YB7TLE9OOoWzONznYvXdj+LqNt/JfM2zc2BmSJwaN4Ehtf PkZPtOxngocnDes6lHIQZ9QSdX+xvEXbcBzsiyoj2oAkxFKXFAJczT0SUAN5BGVDZIL+ aVmAF4CxHcT2lWUaiPfM9I6TIyOoZrb5MR8+r699en30ORj95o8ya+f6e6XhJG0eUkRc ++lA== X-Gm-Message-State: APjAAAWtp/og2HUbXogFU0PjQxUPya9SBL5jOsPN/Fm0b0jvfhKZcF4X lhYsNsfrksrWCdI7sfu0Gfc= X-Google-Smtp-Source: APXvYqy39CoQckRdV3i+42Rb9LPh5sCIUZPJ+vwEjuH0gGJK8KzCgsnF6pz5SR10++NHKt/Z7Aq3zg== X-Received: by 2002:a1c:4c8:: with SMTP id 191mr4978787wme.148.1582806240616; Thu, 27 Feb 2020 04:24:00 -0800 (PST) Received: from wambui.local ([197.237.61.225]) by smtp.googlemail.com with ESMTPSA id w19sm7017934wmc.22.2020.02.27.04.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 04:24:00 -0800 (PST) From: Wambui Karuga X-Google-Original-From: Wambui Karuga Date: Thu, 27 Feb 2020 15:23:31 +0300 (EAT) To: Jyri Sarha Subject: Re: [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions. In-Reply-To: <614d42f2-881e-6e4e-f3c4-c247a86d9262@ti.com> Message-ID: References: <20200227120232.19413-1-wambui.karugax@gmail.com> <20200227120232.19413-18-wambui.karugax@gmail.com> <614d42f2-881e-6e4e-f3c4-c247a86d9262@ti.com> User-Agent: Alpine 2.21.99999 (LNX 375 2019-10-29) MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 27 Feb 2020 12:59:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , Wambui Karuga Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 27 Feb 2020, Jyri Sarha wrote: > On 27/02/2020 14:02, Wambui Karuga wrote: >> Since 987d65d01356 (drm: debugfs: make >> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never >> fails. Therefore, remove the check and error handling of the return >> value of drm_debugfs_create_files() as it is not needed in >> tilcdc_debugfs_init(). >> >> Also remove local variables that are not used after the changes, and >> declare tilcdc_debugfs_init() as void. >> >> Signed-off-by: Wambui Karuga > > > Ok, so this is a part of a bigger series. > Yes, this was converted to a series after initial feedback. Thanks for your review wambui karuga. > Acked-by: Jyri Sarha > > I assume the series will be merged as one without my involvement. Please > let me know if that is not the case. > > BR, > Jyri > >> --- >> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 17 ++++------------- >> 1 file changed, 4 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c >> index 0791a0200cc3..78c1877d13a8 100644 >> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c >> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c >> @@ -478,26 +478,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = { >> { "mm", tilcdc_mm_show, 0 }, >> }; >> >> -static int tilcdc_debugfs_init(struct drm_minor *minor) >> +static void tilcdc_debugfs_init(struct drm_minor *minor) >> { >> - struct drm_device *dev = minor->dev; >> struct tilcdc_module *mod; >> - int ret; >> >> - ret = drm_debugfs_create_files(tilcdc_debugfs_list, >> - ARRAY_SIZE(tilcdc_debugfs_list), >> - minor->debugfs_root, minor); >> + drm_debugfs_create_files(tilcdc_debugfs_list, >> + ARRAY_SIZE(tilcdc_debugfs_list), >> + minor->debugfs_root, minor); >> >> list_for_each_entry(mod, &module_list, list) >> if (mod->funcs->debugfs_init) >> mod->funcs->debugfs_init(mod, minor); >> - >> - if (ret) { >> - dev_err(dev->dev, "could not install tilcdc_debugfs_list\n"); >> - return ret; >> - } >> - >> - return ret; >> } >> #endif >> >> > > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel